fix(settings): keep press prefetch, guard fork direction switch, tighten docs

- Restore the sidebar link's press-time route prefetch. Measured with a realistic ~90ms press, the prefetch mousedown starts completes before the click commits, so removing it slowed every navigation (commit ~105ms -> ~190ms after mousedown).
- Route the fork sync direction switch through the unsaved-changes guard: switching Push/Pull drops the in-session mapping choices, so unsaved edits confirm first.
- Give SettingsNavigationProvider a props interface, and scope the section layout's 404/307 note to section authorization, which is what an unknown or legacy segment skips.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/settings/[section]/layout.tsx

@@ -26,8 +26,8 @@ const TOP_LEVEL_REDIRECTS: Readonly<Record<string, (workspaceId: string) => stri
  * the shell instead of waiting on the body's lazily-loaded chunk.
  *
  * Whether a segment names a section at all is decided here too, before the shell renders, so a
- * bad or legacy URL loaded directly answers 404 or 307 without touching the database. Whether
- * the *viewer* may open a section is a different question and stays in the page, where it
+ * bad or legacy URL loaded directly answers 404 or 307 without running section authorization.
+ * Whether the *viewer* may open a section is a different question and stays in the page, where it
  * belongs; those checks need the database and are reached almost entirely by client navigation.
  *
  * There is deliberately no sibling `loading.tsx`, and the page renders its body under no Suspense
@@ -36,9 +36,9 @@ const TOP_LEVEL_REDIRECTS: Readonly<Record<string, (workspaceId: string) => stri
  * `<Suspense>` around the code-split body — put that floor under every section switch. Without
  * one, a switch is a transition: the sidebar moves its selection and the settings layout paints
  * the incoming heading over the outgoing section, which stays mounted but invisible until the
- * incoming section and its chunk are ready. A boundary above
- * this layout (a `settings/loading.tsx`, or a `<Suspense>` in the settings layout) would also
- * swallow the 404 and 307 above.
+ * incoming section and its chunk are ready. A boundary above this layout (a
+ * `settings/loading.tsx`, or a `<Suspense>` in the settings layout) would also swallow the 404
+ * and 307 above.
  *
  * Authentication is already enforced by the ancestor workspace layout, so this runs only for a
  * signed-in viewer.

apps/sim/components/settings/settings-intent-link.tsx

@@ -80,24 +80,12 @@ function IntentAwareSettingsLink({
     prefetchTimerRef.current = null
   }, [])
 
-  /** Runs the caller's intent warmer; the route payload is left to the navigation. */
-  const warmForIntent = () => {
+  const prefetchForIntent = () => {
     cancelScheduledPrefetch()
     if (isCurrentRoute || navigationIntentRef.current) return
     navigationIntentRef.current = true
-    onIntent?.()
-  }
-
-  /**
-   * Hover and focus land well ahead of a click, so they also prefetch the route payload. A press
-   * does not: the navigation follows within a frame or two, and a prefetch started then is a
-   * second request the navigation ends up waiting on (tree, then data) instead of its own one.
-   */
-  const prefetchForIntent = () => {
-    cancelScheduledPrefetch()
-    if (isCurrentRoute) return
-    warmForIntent()
     setShouldPrefetchRoute(true)
+    onIntent?.()
   }
 
   const schedulePrefetch = () => {
@@ -139,13 +127,13 @@ function IntentAwareSettingsLink({
       onPointerDown={(event) => {
         onPointerDown?.(event)
         if (event.pointerType === 'mouse' && isUnmodifiedPrimaryPointer(event)) {
-          warmForIntent()
+          prefetchForIntent()
         }
       }}
       onPointerUp={(event) => {
         onPointerUp?.(event)
         if (event.pointerType !== 'mouse' && isUnmodifiedPrimaryPointer(event)) {
-          warmForIntent()
+          prefetchForIntent()
         }
       }}
       onPointerCancel={(event) => {
@@ -164,7 +152,7 @@ function IntentAwareSettingsLink({
           !isCurrentRoute &&
           !navigationIntentRef.current
         ) {
-          warmForIntent()
+          prefetchForIntent()
         }
       }}
     />

apps/sim/components/settings/settings-navigation-provider.tsx

@@ -30,6 +30,10 @@ interface SettingsNavigationState {
 
 const SettingsNavigationContext = createContext<SettingsNavigationState | null>(null)
 
+interface SettingsNavigationProviderProps {
+  children: ReactNode
+}
+
 /**
  * Shares an in-flight settings section navigation between the sidebar that starts it and the
  * content area that previews it.
@@ -40,7 +44,7 @@ const SettingsNavigationContext = createContext<SettingsNavigationState | null>(
  * settles — on commit, and equally when the server redirects back or the navigation fails — and
  * because it is state rather than a Suspense fallback, the incoming section is never held back.
  */
-export function SettingsNavigationProvider({ children }: { children: ReactNode }) {
+export function SettingsNavigationProvider({ children }: SettingsNavigationProviderProps) {
   const router = useRouter()
   const [pendingSection, setPendingSection] = useOptimistic<string | null>(null)
   const [, startTransition] = useTransition()

apps/sim/ee/workspace-forking/components/fork-sync-detail-view/fork-sync-detail-view.tsx

@@ -114,7 +114,8 @@ export function ForkSyncDetailView({
       >
         <ForkSyncView
           controller={controller}
-          onDirectionChange={(next) => void setDirection(next)}
+          // A direction switch drops the in-session mapping choices, so unsaved edits confirm first.
+          onDirectionChange={(next) => guard.guardBack(() => void setDirection(next))}
         />
       </SettingsPanel>