fix(confluence): keep the 500 status when cancelling an errored response body

Author: waleedlatif1

apps/sim/connectors/confluence/attachments.test.ts

@@ -288,6 +288,13 @@ describe('Confluence attachment listing', () => {
     it.each([
       ['a complete body', () => 'upstream error'],
       ['a body that never finishes', () => new ReadableStream<Uint8Array>()],
+      [
+        'a body stream that already errored',
+        () =>
+          new ReadableStream<Uint8Array>({
+            start: (controller) => controller.error(new Error('connection reset')),
+          }),
+      ],
     ])('retries a transient 500 with %s instead of failing the listing', async (_, body) => {
       let failed = false
       fetchMock.mockImplementation(async () => {

apps/sim/connectors/confluence/attachments.ts

@@ -163,7 +163,7 @@ const METADATA_RETRY_OPTIONS: RetryOptions = {
       requestId: opaqueHeader(response, 'x-arequestid'),
     })
     if (response.status !== 500) return response
-    await response.body?.cancel()
+    await response.body?.cancel().catch(() => undefined)
     throw metadataServerError(response.status)
   },
   retryCondition: (error) =>
@@ -196,7 +196,7 @@ function isServerFailure(error: unknown): error is Error & { status: number } {
 async function readMetadata(response: Response): Promise<unknown> {
   if (!response.ok) {
     if (response.status === 401) throw await unauthorizedAttachmentError(response)
-    await response.body?.cancel()
+    await response.body?.cancel().catch(() => undefined)
     if (response.status >= 500) throw metadataServerError(response.status)
     throw new Error(
       response.status === 403