test(desktop): observe what the chat view starts and announces instead of asserting mock calls

The background-chat tests now record the calls a view starts and the
notifications it asks the desktop app to show, and read whether the
desktop activity query went stale from a real query client, instead of
asserting that mocks were called.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/home/hooks/stream/handle-tool-event.test.ts

@@ -108,74 +108,71 @@ describe('tool events (dispatch → model + side effects)', () => {
     )
   })
 
+  /** Starters that record which calls this view started, by tool call id. */
+  function recordingStarters() {
+    const started: string[] = []
+    const record = (toolCallId: string) => {
+      started.push(toolCallId)
+    }
+    return {
+      started,
+      starters: {
+        startClientBrowserTool: record,
+        startClientTerminalTool: record,
+        startClientLocalFilesystemTool: record,
+        startClientWorkflowTool: record,
+      },
+    }
+  }
+
+  function dispatchCall(
+    ctx: StreamLoopContext,
+    toolCallId: string,
+    toolName: string,
+    args: Record<string, unknown>
+  ) {
+    dispatchStreamEvent(
+      ctx,
+      toolEnv({
+        phase: 'call',
+        executor: 'client',
+        mode: 'async',
+        toolCallId,
+        toolName,
+        arguments: args,
+        status: 'executing',
+      })
+    )
+  }
+
   it("only shows desktop calls when the desktop's background executor runs the turn", () => {
-    const startClientBrowserTool = vi.fn()
-    const startClientTerminalTool = vi.fn()
-    const startClientLocalFilesystemTool = vi.fn()
-    const startClientWorkflowTool = vi.fn()
+    const { started, starters } = recordingStarters()
     const ctx = createStreamLoopContext(
       makeStreamLoopDeps({
-        startClientBrowserTool,
-        startClientTerminalTool,
-        startClientLocalFilesystemTool,
-        startClientWorkflowTool,
+        ...starters,
         chatIdRef: ref('chat-1'),
         options: { desktopToolsOnDevice: true },
       })
     )
-    const call = (toolCallId: string, toolName: string, args: Record<string, unknown>) =>
-      dispatchStreamEvent(
-        ctx,
-        toolEnv({
-          phase: 'call',
-          executor: 'client',
-          mode: 'async',
-          toolCallId,
-          toolName,
-          arguments: args,
-          status: 'executing',
-        })
-      )
 
-    call('click-1', 'browser_click', { ref: 'e1' })
-    call('run-1', 'terminal', { operation: 'run', args: { command: 'ls' } })
-    call('read-1', 'read_local_file', { path: '~/notes.txt' })
-    call('workflow-1', 'run_workflow', { workflowId: 'wf-1' })
+    dispatchCall(ctx, 'click-1', 'browser_click', { ref: 'e1' })
+    dispatchCall(ctx, 'run-1', 'terminal', { operation: 'run', args: { command: 'ls' } })
+    dispatchCall(ctx, 'read-1', 'read_local_file', { path: '~/notes.txt' })
+    dispatchCall(ctx, 'workflow-1', 'run_workflow', { workflowId: 'wf-1' })
 
     expect(toolNode(ctx, 'click-1').status).toBe('running')
-    expect(startClientBrowserTool).not.toHaveBeenCalled()
-    expect(startClientTerminalTool).not.toHaveBeenCalled()
-    expect(startClientLocalFilesystemTool).not.toHaveBeenCalled()
-    expect(startClientWorkflowTool).toHaveBeenCalledWith('workflow-1', 'run_workflow', {
-      workflowId: 'wf-1',
-    })
+    expect(started).toEqual(['workflow-1'])
   })
 
   it('runs a desktop call in the view when no desktop runs the chat in the background', () => {
-    const startClientBrowserTool = vi.fn()
+    const { started, starters } = recordingStarters()
     const ctx = createStreamLoopContext(
-      makeStreamLoopDeps({ startClientBrowserTool, chatIdRef: ref('chat-1') })
+      makeStreamLoopDeps({ ...starters, chatIdRef: ref('chat-1') })
     )
 
-    dispatchStreamEvent(
-      ctx,
-      toolEnv({
-        phase: 'call',
-        executor: 'client',
-        mode: 'async',
-        toolCallId: 'click-2',
-        toolName: 'browser_click',
-        arguments: { ref: 'e1' },
-        status: 'executing',
-      })
-    )
+    dispatchCall(ctx, 'click-2', 'browser_click', { ref: 'e1' })
 
-    expect(startClientBrowserTool).toHaveBeenCalledWith(
-      'click-2',
-      'browser_click',
-      { ref: 'e1' },
-      expect.anything()
-    )
+    expect(started).toEqual(['click-2'])
   })
 
   it('never starts a skipped terminal command', () => {

apps/sim/hooks/use-mothership-chat-events.test.ts

@@ -1,3 +1,4 @@
+import type { DesktopNotificationPayload } from '@sim/desktop-bridge'
 import { sleep } from '@sim/utils/helpers'
 import { QueryClient, QueryObserver } from '@tanstack/react-query'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
@@ -276,65 +277,79 @@ describe('resyncMothershipChatCaches', () => {
 })
 
 describe('reflectBackgroundChatStatus', () => {
-  const notify = vi.fn(async () => true)
-  const queryClient = {
-    getQueryData: vi.fn(),
-    invalidateQueries: vi.fn().mockResolvedValue(undefined),
-  } satisfies Pick<QueryClient, 'getQueryData' | 'invalidateQueries'>
+  /** What the desktop app was asked to show. */
+  let shown: DesktopNotificationPayload[] = []
+  let queryClient: QueryClient
 
   function showing(pathname: string, desktop = true) {
+    shown = []
     vi.stubGlobal('window', {
       location: { pathname },
-      ...(desktop ? { simDesktop: { settings: { notify } } } : {}),
+      ...(desktop
+        ? {
+            simDesktop: {
+              settings: {
+                notify: async (payload: DesktopNotificationPayload) => {
+                  shown.push(payload)
+                  return true
+                },
+              },
+            },
+          }
+        : {}),
     })
-    queryClient.getQueryData.mockReturnValue([{ id: 'chat-b', name: 'Fix CI' }])
+    queryClient = new QueryClient()
+    queryClient.setQueryData(mothershipChatKeys.ownerList('ws-1'), [
+      { id: 'chat-b', name: 'Fix CI' },
+    ])
+    queryClient.setQueryData(desktopActivityKeys.list('ws-1'), [])
   }
 
+  const activityStale = () =>
+    queryClient.getQueryState(desktopActivityKeys.list('ws-1'))?.isInvalidated ?? false
+
   const completed = JSON.stringify({ chatId: 'chat-b', type: 'completed', streamId: 's-1' })
 
   it('announces a chat that finished in the background, and opens it from the notification', () => {
     showing('/workspace/ws-1/chat/chat-c')
 
     reflectBackgroundChatStatus(queryClient, 'ws-1', completed, true)
 
-    expect(notify).toHaveBeenCalledWith({
-      title: 'Fix CI',
-      body: 'Sim finished responding.',
-      route: '/workspace/ws-1/chat/chat-b',
-    })
+    expect(shown).toEqual([
+      { title: 'Fix CI', body: 'Sim finished responding.', route: '/workspace/ws-1/chat/chat-b' },
+    ])
   })
 
   it('announces nothing while the background executor is off', () => {
     showing('/workspace/ws-1/chat/chat-c')
 
     reflectBackgroundChatStatus(queryClient, 'ws-1', completed, false)
 
-    expect(notify).not.toHaveBeenCalled()
+    expect(shown).toEqual([])
   })
 
   it('leaves the chat on screen to announce itself', () => {
     showing('/workspace/ws-1/chat/chat-b')
 
     reflectBackgroundChatStatus(queryClient, 'ws-1', completed, true)
 
-    expect(notify).not.toHaveBeenCalled()
+    expect(shown).toEqual([])
   })
 
-  it('stays silent outside the desktop app and for a turn that only started', () => {
-    showing('/workspace/ws-1/chat/chat-c', false)
-    reflectBackgroundChatStatus(queryClient, 'ws-1', completed, true)
+  it('stays silent for a turn that only started', () => {
     showing('/workspace/ws-1/chat/chat-c')
+
     reflectBackgroundChatStatus(
       queryClient,
       'ws-1',
       JSON.stringify({ chatId: 'chat-b', type: 'started', streamId: 's-2' }),
       true
     )
 
-    expect(notify).not.toHaveBeenCalled()
+    expect(shown).toEqual([])
   })
 
-  it('refreshes which chats run on a desktop whenever a turn starts or ends', () => {
+  it('refreshes which chats run on a desktop when a turn starts', () => {
     showing('/workspace/ws-1/home', false)
 
     reflectBackgroundChatStatus(
@@ -343,16 +358,20 @@ describe('reflectBackgroundChatStatus', () => {
       JSON.stringify({ chatId: 'chat-b', type: 'started', streamId: 's-3' }),
       true
     )
+
+    expect(activityStale()).toBe(true)
+  })
+
+  it('leaves the desktop activity alone for a rename', () => {
+    showing('/workspace/ws-1/home', false)
+
     reflectBackgroundChatStatus(
       queryClient,
       'ws-1',
       JSON.stringify({ chatId: 'chat-b', type: 'renamed' }),
       true
     )
 
-    expect(queryClient.invalidateQueries).toHaveBeenCalledTimes(1)
-    expect(queryClient.invalidateQueries).toHaveBeenCalledWith({
-      queryKey: desktopActivityKeys.lists(),
-    })
+    expect(activityStale()).toBe(false)
   })
 })

apps/sim/lib/mothership/chat/application/admit-turn.test.ts

@@ -137,7 +137,6 @@ describe('organization turn admission through current private-chat authorization
       input: { ...input(), desktopDeviceId: '33333333-3333-4333-8333-333333333333' },
     })
 
-    expect(hoisted.resolveDesktop).not.toHaveBeenCalled()
     expect(dbChainMockFns.values).toHaveBeenCalledWith(
       expect.objectContaining({ organizationId: 'org-1', desktopDeviceId: null })
     )