Commit 218eca1
committed
fix(cli): disclose a truncated burst, and clear a stale retry notice
Two review findings in `logs follow`, both verified against the code first.
The page budget bounds one poll so an enormous burst cannot stall the follow,
but on reaching it the live cursor was discarded: the remainder is older than
everything collected and the next poll restarts at the newest page, so those
runs were never printed and nothing said so. The budget stays — draining
without one trades a bounded poll for unbounded buffering in a process meant
to run for hours — but hitting it now warns on stderr, naming the count and
pointing at `sim logs list`. That notice is written even off a terminal,
because a piped log is where an unexplained hole is hardest to spot.
The retry notice was cleared after the empty-rows check, so a poll that
recovered but found nothing left "retrying in Ns…" on screen while the follow
was already healthy. Clearing now happens as soon as a poll succeeds.
The second test needed two failures to be worth anything: the teardown clears
the line either way, so what separates fixed from broken is whether a bare
erase lands before the second notice or only at the end. The first version
passed against the bug.1 parent aa0a1fe commit 218eca1
2 files changed
Lines changed: 103 additions & 15 deletions
Lines changed: 45 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
250 | 295 | | |
251 | 296 | | |
252 | 297 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
250 | 259 | | |
251 | 260 | | |
252 | 261 | | |
| |||
265 | 274 | | |
266 | 275 | | |
267 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
268 | 284 | | |
269 | 285 | | |
270 | 286 | | |
| |||
370 | 386 | | |
371 | 387 | | |
372 | 388 | | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
373 | 402 | | |
374 | 403 | | |
375 | 404 | | |
376 | 405 | | |
377 | 406 | | |
378 | 407 | | |
379 | 408 | | |
380 | | - | |
381 | | - | |
| 409 | + | |
| 410 | + | |
382 | 411 | | |
| 412 | + | |
383 | 413 | | |
384 | 414 | | |
385 | 415 | | |
386 | 416 | | |
387 | 417 | | |
388 | | - | |
389 | | - | |
390 | | - | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
391 | 421 | | |
392 | 422 | | |
393 | | - | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
394 | 428 | | |
395 | 429 | | |
396 | | - | |
| 430 | + | |
397 | 431 | | |
398 | 432 | | |
399 | 433 | | |
| |||
511 | 545 | | |
512 | 546 | | |
513 | 547 | | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
518 | 552 | | |
519 | 553 | | |
520 | 554 | | |
| |||
524 | 558 | | |
525 | 559 | | |
526 | 560 | | |
527 | | - | |
| 561 | + | |
528 | 562 | | |
529 | 563 | | |
530 | 564 | | |
| |||
544 | 578 | | |
545 | 579 | | |
546 | 580 | | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
547 | 585 | | |
548 | | - | |
549 | 586 | | |
550 | | - | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
551 | 594 | | |
552 | 595 | | |
553 | | - | |
| 596 | + | |
554 | 597 | | |
555 | 598 | | |
556 | 599 | | |
| |||
0 commit comments