Skip to content

Commit 2af5443

Browse files
authored
chore(ci): remove the flaky-test issue workflow (#9156)
1 parent f4daf59 commit 2af5443

5 files changed

Lines changed: 4 additions & 714 deletions

File tree

‎.claude/rules/sim-testing.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,8 @@ the report.
6767

6868
## Flaky tests
6969

70-
A daily job (`.github/workflows/ci-flakes.yml`) files a `ci-flake` issue for every test or job
71-
that failed on a CI attempt and passed when the same commit was re-run, and reopens it if the
72-
flake recurs after it was closed. Fix the nondeterminism it names: pin the clock
70+
When a test or job fails on a CI attempt and passes when the same commit is re-run, fix the
71+
nondeterminism behind it: pin the clock
7372
(`vi.useFakeTimers({ toFake: ['Date'] })` + `vi.setSystemTime`), give each test its own ids and
7473
rows, wait on the condition rather than a delay, and keep cold imports out of a test's timeout by
7574
importing statically. Never add a retry, a skip, or a longer timeout to make one pass; raise a

‎.cursor/rules/sim-testing.mdc‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ the report.
6565

6666
## Flaky tests
6767

68-
A daily job (`.github/workflows/ci-flakes.yml`) files a `ci-flake` issue for every test or job
69-
that failed on a CI attempt and passed when the same commit was re-run, and reopens it if the
70-
flake recurs after it was closed. Fix the nondeterminism it names: pin the clock
68+
When a test or job fails on a CI attempt and passes when the same commit is re-run, fix the
69+
nondeterminism behind it: pin the clock
7170
(`vi.useFakeTimers({ toFake: ['Date'] })` + `vi.setSystemTime`), give each test its own ids and
7271
rows, wait on the condition rather than a delay, and keep cold imports out of a test's timeout by
7372
importing statically. Never add a retry, a skip, or a longer timeout to make one pass; raise a

‎.github/workflows/ci-flakes.yml‎

Lines changed: 0 additions & 55 deletions
This file was deleted.

‎scripts/report-ci-flakes.test.ts‎

Lines changed: 0 additions & 214 deletions
This file was deleted.

0 commit comments

Comments
 (0)