fix(desktop): reach every overdue desktop call, and declare the desktop tool names as const

A 24 h horizon on the lapsed deadline meant a call the backstop missed for a
day was never settled. The sweep starts from the few unsettled (pending or
running) calls in persistence order, so it needs no horizon to stay small.

The desktop tool names are a literal array declared as const, and the lookup
set is derived from it.

Author: waleedlatif1

apps/sim/lib/desktop/executor/bound-turn.integration.ts

@@ -794,6 +794,27 @@ describe.runIf(Boolean(redisUrl))("a turn bound to a desktop's background execut
     TURN_WAIT_MS
   )
 
+  it(
+    'still settles a call that stayed overdue for days, however long the backstop missed it',
+    async () => {
+      const desktop = await signedInDesktop()
+      const run = await boundRun(desktop)
+      const toolCallId = generateId()
+      await db.insert(copilotAsyncToolCalls).values({
+        runId: run.runId,
+        toolCallId,
+        toolName: 'browser_click',
+        args: { ref: 'e1' },
+        createdAt: new Date(Date.now() - 2 * 24 * 3_600_000),
+      })
+
+      await runCleanupStaleExecutions()
+
+      expect((await storedCall(toolCallId)).status).toBe('failed')
+    },
+    TURN_WAIT_MS
+  )
+
   it(
     'settles a call whose window lapsed recently on a run that started long ago',
     async () => {

apps/sim/lib/desktop/executor/repository.ts

@@ -422,12 +422,12 @@ export type DesktopToolCallDeadlines = NonNullable<
 /**
  * Bound desktop calls a deadline passed for at least `slackMs` ago: unclaimed past their pickup
  * deadline (offered or not), or claimed by the executor with a lapsed lease. A live waiter settles
- * these within its 5 s poll, so anything this finds lost its waiter. Only deadlines that lapsed
- * within the inbox's horizon are scanned, whatever the run's age, oldest calls first.
+ * these within its 5 s poll, so anything this finds lost its waiter. The scan starts from the
+ * few unsettled calls (pending or running), in persistence order, so however long a call stayed
+ * overdue it is still reached.
  */
 export async function listOverdueDesktopToolCalls(input: { slackMs: number; limit: number }) {
   const overdue = sql`clock_timestamp() - ${input.slackMs} * interval '1 millisecond'`
-  const horizon = sql`clock_timestamp() - make_interval(hours => ${DESKTOP_INBOX_HORIZON_HOURS})`
   const rows = await db
     .select({ toolCallId: copilotAsyncToolCalls.toolCallId })
     .from(copilotAsyncToolCalls)
@@ -437,14 +437,13 @@ export async function listOverdueDesktopToolCalls(input: { slackMs: number; limi
         isNotNull(copilotRuns.desktopDeviceId),
         isDesktopToolCallRow,
         or(
-          and(pickupOverdueAt(overdue), sql`${pickupDeadline} > ${horizon}`),
+          pickupOverdueAt(overdue),
           and(
             eq(copilotAsyncToolCalls.status, ASYNC_TOOL_STATUS.running),
             inArray(copilotAsyncToolCalls.claimedBy, Object.values(DESKTOP_TOOL_CLAIM_OWNER)),
             isNotNull(copilotAsyncToolCalls.executionOwnerToken),
             isNull(copilotAsyncToolCalls.executionRevokedAt),
-            sql`${copilotAsyncToolCalls.executionLeaseExpiresAt} < ${overdue}`,
-            sql`${copilotAsyncToolCalls.executionLeaseExpiresAt} > ${horizon}`
+            sql`${copilotAsyncToolCalls.executionLeaseExpiresAt} < ${overdue}`
           )
         )
       )

apps/sim/lib/mothership/tools/desktop-tools.ts

@@ -15,12 +15,15 @@ import { isUserLocalVfsToolCall } from '@/lib/mothership/tools/local-filesystem'
 export type DesktopToolClaimOwner =
   (typeof DESKTOP_TOOL_CLAIM_OWNER)[keyof typeof DESKTOP_TOOL_CLAIM_OWNER]
 
-const DESKTOP_TOOL_NAMES: ReadonlySet<string> = new Set([
+/** The tools that run through the desktop app by name alone; local VFS reads also depend on args. */
+export const NAMED_DESKTOP_TOOL_NAMES = [
   ...CURRENT_BROWSER_TOOL_NAMES,
   TERMINAL_TOOL_NAME,
   'import_local_files',
   'read_local_file',
-])
+] as const
+
+const DESKTOP_TOOL_NAMES: ReadonlySet<string> = new Set(NAMED_DESKTOP_TOOL_NAMES)
 
 /** Whether a call runs through the desktop app, including VFS reads of a granted local folder. */
 export function isDesktopToolCall(toolName: string, args: Record<string, unknown> | undefined) {
@@ -68,9 +71,6 @@ export function isClaimedOnPickup(
   )
 }
 
-/** The tools that run through the desktop app by name alone; local VFS reads also depend on args. */
-export const NAMED_DESKTOP_TOOL_NAMES: readonly string[] = [...DESKTOP_TOOL_NAMES]
-
 /**
  * The claim owner a desktop background executor records. It is the per-surface owner the chat
  * view's claim records, so file transfer and download admission recognize it, with local reads