improvement(search-mcp): log the field names a rejected tool call's arguments carry

Author: waleedlatif1

apps/sim/lib/knowledge/mcp/tool-arguments.test.ts

@@ -0,0 +1,28 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import { toolCallInputIssues } from '@/lib/knowledge/mcp/tool-arguments'
+
+const searchCall = (args: Record<string, unknown>) => ({
+  jsonrpc: '2.0',
+  id: 1,
+  method: 'tools/call',
+  params: { name: 'search', arguments: args },
+})
+
+describe('toolCallInputIssues', () => {
+  it('names the fields a native query carries that the schema does not know', () => {
+    const issues = toolCallInputIssues(
+      searchCall({
+        query: 'roadmap',
+        nativeQueries: [{ provider: 'jira', query: 'roadmap', limit: 5 }],
+      })
+    )
+    expect(issues?.issues).toContainEqual({
+      code: 'unrecognized_keys',
+      path: 'nativeQueries.0',
+      keys: ['limit'],
+    })
+  })
+})

apps/sim/lib/knowledge/mcp/tool-arguments.ts

@@ -87,9 +87,15 @@ export function repairToolCallMessage(message: Record<string, unknown>) {
   return { message: { ...message, params: { ...call, arguments: args } }, repairs: [...repairs] }
 }
 
+/** Unrecognized field names a rejection records, each cut short, so a log line stays bounded. */
+const MAX_LOGGED_KEYS = 5
+const MAX_LOGGED_KEY_CHARACTERS = 64
+
 /**
  * Where a tool call's arguments fail its input schema, as field paths and issue codes without
- * values. The SDK rejects such a call before the tool runs, so nothing else records it.
+ * values, plus the names of fields the schema does not know, so a repeated client mistake can be
+ * told apart from a new one. The SDK rejects such a call before the tool runs, so nothing else
+ * records it.
  */
 export function toolCallInputIssues(message: Record<string, unknown>) {
   const call = readToolCall(message)
@@ -99,6 +105,14 @@ export function toolCallInputIssues(message: Record<string, unknown>) {
   if (parsed.success) return undefined
   return {
     toolName: call.name,
-    issues: parsed.error.issues.map(({ code, path }) => ({ code, path: path.join('.') })),
+    issues: parsed.error.issues.map((issue) => ({
+      code: issue.code,
+      path: issue.path.join('.'),
+      ...(issue.code === 'unrecognized_keys' && {
+        keys: issue.keys
+          .slice(0, MAX_LOGGED_KEYS)
+          .map((key) => key.slice(0, MAX_LOGGED_KEY_CHARACTERS)),
+      }),
+    })),
   }
 }