test(workday): assert Get_Organizations element order in the XML sent to Workday

Author: waleedlatif1

apps/sim/lib/internal/workday/client.test.ts

@@ -4,6 +4,7 @@ import {
   createWorkdaySoapClient,
   extractRefId,
 } from '@/lib/internal/workday/client'
+import { executeWorkdayGetOrganizations } from '@/lib/internal/workday/operations'
 
 const SUCCESS_RESPONSE = `<?xml version="1.0" encoding="UTF-8"?>
 <env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:wd="urn:com.workday/bsvc">
@@ -39,6 +40,31 @@ describe('Workday SOAP client', () => {
     )
   })
 
+  it('sends Get_Organizations criteria before the response filter, in schema order', async () => {
+    fetchMock.mockResolvedValue(
+      new Response(
+        '<env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:wd="urn:com.workday/bsvc"><env:Body><wd:Get_Organizations_Response/></env:Body></env:Envelope>',
+        { status: 200 }
+      )
+    )
+
+    await executeWorkdayGetOrganizations({
+      tenantUrl: 'https://wd2-impl-services1.workday.com',
+      tenant: 'example',
+      username: 'user',
+      password: 'password',
+      type: 'Supervisory',
+    })
+
+    const body = String(fetchMock.mock.calls[0]?.[1]?.body)
+    const criteria = body.indexOf('<wd:Request_Criteria>')
+    const filter = body.indexOf('<wd:Response_Filter>')
+    const group = body.indexOf('<wd:Response_Group>')
+    expect(criteria).toBeGreaterThan(-1)
+    expect(criteria).toBeLessThan(filter)
+    expect(filter).toBeLessThan(group)
+  })
+
   it('passes cancellation to fetch, escapes XML, and parses SOAP responses', async () => {
     fetchMock.mockResolvedValue(new Response(SUCCESS_RESPONSE, { status: 200 }))
     const controller = new AbortController()

apps/sim/lib/internal/workday/operations.test.ts

@@ -173,18 +173,6 @@ describe('Workday operations', () => {
     })
   })
 
-  it('sends the organization type criteria before the response filter, in schema order', async () => {
-    clientMocks.Get_OrganizationsAsync.mockResolvedValue([{ Response_Data: {} }])
-
-    await executeWorkdayGetOrganizations({ ...CREDENTIALS, type: 'Supervisory' })
-
-    expect(Object.keys(firstCallArgs(clientMocks.Get_OrganizationsAsync))).toEqual([
-      'Request_Criteria',
-      'Response_Filter',
-      'Response_Group',
-    ])
-  })
-
   it('sends personal information changes under Change_Personal_Information_Data', async () => {
     await executeWorkdayUpdateWorker({
       ...CREDENTIALS,