Skip to content

Commit 496fd61

Browse files
authored
ci(desktop): run the live suite's lease-lapse test on its own runner (#8980)
1 parent 2b4fa54 commit 496fd61

2 files changed

Lines changed: 14 additions & 4 deletions

File tree

‎.github/workflows/checks.yml‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,12 +332,22 @@ jobs:
332332

333333
# Desktop tools in the real Electron app against a local app, on its own runner: the
334334
# Electron app, the dev app and its realtime server together outgrow the e2e runner.
335+
# Two runners: the lease-lapse test sleeps through a long import and then a lease (~3 min), as
336+
# long as the rest of the spec together, so on one runner it set the time for every run.
335337
desktop-live:
336-
name: desktop-live
338+
name: desktop-live (${{ matrix.tests }})
337339
needs: changes
338340
if: needs.changes.outputs.desktop_live == 'true'
339341
runs-on: ${{ (vars.CI_PROVIDER == '' || vars.CI_PROVIDER == 'blacksmith') && 'blacksmith-16vcpu-ubuntu-2404' || 'ubuntu-latest' }}
340342
timeout-minutes: 30
343+
strategy:
344+
fail-fast: false
345+
matrix:
346+
include:
347+
- tests: lease-lapse
348+
filter: --grep @lease-lapse
349+
- tests: rest
350+
filter: --grep-invert @lease-lapse
341351
services:
342352
postgres:
343353
image: pgvector/pgvector:pg17
@@ -503,13 +513,13 @@ jobs:
503513
SIM_DESKTOP_E2E_REDIS_URL="$REDIS_URL" \
504514
SIM_DESKTOP_E2E_AUTH_SECRET="$BETTER_AUTH_SECRET" \
505515
xvfb-run -a -s '-screen 0 1920x1200x24' bunx playwright test e2e/desktop-tools-live-sim.spec.ts \
506-
--output "$report_dir/desktop-tools-results" --retries=0
516+
${{ matrix.filter }} --output "$report_dir/desktop-tools-results" --retries=0
507517
508518
- name: Upload Electron E2E results and server logs
509519
if: failure()
510520
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
511521
with:
512-
name: desktop-live-e2e-results
522+
name: desktop-live-e2e-results-${{ matrix.tests }}
513523
path: ${{ runner.temp }}/e2e/
514524
if-no-files-found: ignore
515525
retention-days: 7

‎apps/desktop/e2e/desktop-tools-live-sim.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ test.describe('desktop tools against a live Sim', () => {
546546
expect(await callState(chatId)).toMatch(/^completed/)
547547
})
548548

549-
test('a long import whose window crashed settles as outcome unknown about one lease later', async () => {
549+
test('a long import whose window crashed settles as outcome unknown about one lease later @lease-lapse', async () => {
550550
test.setTimeout(420_000)
551551
const user = await db.seedUser(['Crashing import chat'])
552552
const { callId } = await slowImport(user, 'Crashing import chat', '[crash-import]')

0 commit comments

Comments
 (0)