refactor(uploads): move the external URL fetch out of the workspace files module

Author: waleedlatif1

.agents/skills/memory-load-check/SKILL.md

@@ -45,7 +45,7 @@ Read these when doing a deeper pass:
   - dispatch concrete chunks (`workspaceIds`, retention, label) instead of one giant scope
   - prefer Trigger.dev queue/concurrency keys when available
   - execute inline fallback chunks sequentially, not with unbounded `Promise.all`
-- File parse pattern in `apps/sim/lib/internal/file/parser.ts` and `apps/sim/lib/uploads/contexts/workspace/fetch-external-url.ts`
+- File parse pattern in `apps/sim/lib/internal/file/parser.ts` and `apps/sim/lib/uploads/utils/fetch-external-url.server.ts`
   - cap downloads and parsed output separately
   - preserve partial results when a later item exceeds the cap
   - never read untrusted response bodies without a byte cap

apps/sim/lib/internal/file/parser.ts

@@ -35,13 +35,16 @@ import {
 } from '@/lib/internal/file/operations'
 import { isUsingCloudStorage, StorageService } from '@/lib/uploads'
 import { uploadExecutionFile } from '@/lib/uploads/contexts/execution'
-import { ExternalUrlValidationError, fetchExternalUrl } from '@/lib/uploads/contexts/workspace'
 import {
   getBoundWorkspaceFileSecretProvenance,
   type WorkspaceFileSecretProvenance,
 } from '@/lib/uploads/contexts/workspace/workspace-file-secret-provenance'
 import { UPLOAD_DIR_SERVER } from '@/lib/uploads/core/setup.server'
 import { isWorkspaceScopedContext } from '@/lib/uploads/shared/types'
+import {
+  ExternalUrlValidationError,
+  fetchExternalUrl,
+} from '@/lib/uploads/utils/fetch-external-url.server'
 import {
   extractCleanFilename,
   extractStorageKey,

apps/sim/lib/uploads/contexts/workspace/index.ts

@@ -1,3 +1,2 @@
-export * from './fetch-external-url'
 export * from './workspace-file-folder-manager'
 export * from './workspace-file-manager'

…xts/workspace/fetch-external-url.test.ts …/utils/fetch-external-url.server.test.tsapps/sim/lib/uploads/contexts/workspace/fetch-external-url.test.ts renamed to apps/sim/lib/uploads/utils/fetch-external-url.server.test.ts apps/sim/lib/uploads/contexts/workspace/fetch-external-url.test.ts renamed to apps/sim/lib/uploads/utils/fetch-external-url.server.test.ts

@@ -11,7 +11,7 @@ import * as inputValidation from '@/lib/core/security/input-validation.server'
 import {
   ExternalUrlValidationError,
   fetchExternalUrl,
-} from '@/lib/uploads/contexts/workspace/fetch-external-url'
+} from '@/lib/uploads/utils/fetch-external-url.server'
 
 let validateUrlWithDNSSpy: MockInstance<typeof inputValidation.validateUrlWithDNS>
 let secureFetchWithPinnedIPSpy: MockInstance<typeof inputValidation.secureFetchWithPinnedIP>

…contexts/workspace/fetch-external-url.ts …loads/utils/fetch-external-url.server.tsapps/sim/lib/uploads/contexts/workspace/fetch-external-url.ts renamed to apps/sim/lib/uploads/utils/fetch-external-url.server.ts apps/sim/lib/uploads/contexts/workspace/fetch-external-url.ts renamed to apps/sim/lib/uploads/utils/fetch-external-url.server.ts

@@ -1044,7 +1044,6 @@ export {
   workspaceForkingMappingStoreMockFns,
 } from './workspace-forking-mapping-store.mock'
 export {
-  MockExternalUrlValidationError,
   MockWorkspaceFileFolderConflictError,
   MockWorkspaceFileItemsNotFoundError,
   MockWorkspaceFileMoveConflictError,

packages/testing/src/mocks/index.ts

@@ -41,14 +41,6 @@ export class MockWorkspaceFileItemsNotFoundError extends Error {
   }
 }
 
-/** Real `ExternalUrlValidationError` stand-in: same `name` and message. */
-export class MockExternalUrlValidationError extends Error {
-  constructor(message: string) {
-    super(message)
-    this.name = 'ExternalUrlValidationError'
-  }
-}
-
 /** Structural stand-in for a folder row passed to `buildWorkspaceFileFolderPathMap`. */
 interface MockFolderPathRow {
   id: string
@@ -57,7 +49,7 @@ interface MockFolderPathRow {
 }
 
 /**
- * Controllable mock functions for the folder-manager and external-URL halves of the
+ * Controllable mock functions for the folder-manager half of the
  * `@/lib/uploads/contexts/workspace` barrel. The file-manager half is
  * `workspaceFileManagerMockFns` (re-exported here as `...workspaceFileManagerMockFns`).
  *
@@ -75,7 +67,6 @@ interface MockFolderPathRow {
  */
 export const workspaceUploadsMockFns = {
   ...workspaceFileManagerMockFns,
-  mockFetchExternalUrl: vi.fn(),
   mockLoadWorkspaceFileOperationContext: vi.fn(),
   mockAssertWorkspaceFileItemsBelongToWorkspace: vi.fn(),
   mockNormalizeWorkspaceFileItemName: vi.fn((name: string, itemLabel: 'File' | 'Folder') => {
@@ -128,7 +119,7 @@ const fns = workspaceUploadsMockFns
 
 /**
  * Static mock module for the `@/lib/uploads/contexts/workspace` barrel
- * (`workspace-file-manager` + `workspace-file-folder-manager` + `fetch-external-url`).
+ * (`workspace-file-manager` + `workspace-file-folder-manager`).
  *
  * The error classes extend `Error`, not `OrchestrationError`: their `name`, `code` and
  * message match production, but `instanceof OrchestrationError` is false.
@@ -140,11 +131,9 @@ const fns = workspaceUploadsMockFns
  */
 export const workspaceUploadsMock = {
   ...workspaceFileManagerMock,
-  ExternalUrlValidationError: MockExternalUrlValidationError,
   WorkspaceFileFolderConflictError: MockWorkspaceFileFolderConflictError,
   WorkspaceFileMoveConflictError: MockWorkspaceFileMoveConflictError,
   WorkspaceFileItemsNotFoundError: MockWorkspaceFileItemsNotFoundError,
-  fetchExternalUrl: fns.mockFetchExternalUrl,
   loadWorkspaceFileOperationContext: fns.mockLoadWorkspaceFileOperationContext,
   assertWorkspaceFileItemsBelongToWorkspace: fns.mockAssertWorkspaceFileItemsBelongToWorkspace,
   normalizeWorkspaceFileItemName: fns.mockNormalizeWorkspaceFileItemName,