test(logs): pin the logged mark and attribution at the block executor

Asserts the block executor's thrown error is already logged and attributed
(database failure internal, user Stop user), switches the tool-boundary test
to the central jsonResponse helper, and updates exact-argument log
assertions for the added failureKind and executionId fields.

Author: waleedlatif1

apps/sim/background/async-preprocessing-correlation.test.ts

@@ -493,7 +493,7 @@ describe('async preprocessing correlation threading', () => {
     })
     expect(workflowExecutionLogger.error).toHaveBeenCalledWith(
       '[request-fault] Workflow execution failed: workflow-1',
-      { executionId: 'execution-fault', error: projectedError }
+      { executionId: 'execution-fault', error: projectedError, failureKind: 'internal' }
     )
     const loggerPayload = JSON.stringify(workflowExecutionLogger.error.mock.calls)
     expect(loggerPayload).not.toContain(secret)

apps/sim/background/webhook-execution.test.ts

@@ -482,11 +482,17 @@ describe('executeWebhookJob fault vs error handling', () => {
     expect(loggingSessionMockFns.mockSafeCompleteWithError).toHaveBeenCalled()
     expect(loggingSessionMockFns.mockProjectDiagnosticError).toHaveBeenCalledWith(rawError, {
       workflowId: 'workflow-1',
+      executionId: 'execution-1',
       provider: 'gmail',
     })
     expect(webhookExecutionLogger.error).toHaveBeenCalledWith(
       '[request-1] Webhook execution failed',
-      { workflowId: 'workflow-1', provider: 'gmail', error: projectedError }
+      {
+        workflowId: 'workflow-1',
+        provider: 'gmail',
+        error: projectedError,
+        failureKind: 'internal',
+      }
     )
     const loggerPayload = JSON.stringify(webhookExecutionLogger.error.mock.calls)
     expect(loggerPayload).not.toContain(secret)

apps/sim/executor/execution/block-executor.test.ts

@@ -5,6 +5,7 @@ import { storageServiceMockFns } from '@sim/testing/mocks/storage-service.mock'
 import { uploadsMock } from '@sim/testing/mocks/uploads.mock'
 import { DrizzleQueryError } from 'drizzle-orm/errors'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { classifyFailure, wasFailureLogged } from '@/lib/core/errors/failure-log'
 import { clearLargeValueCacheForTests } from '@/lib/execution/payloads/cache'
 import { createLargeArrayManifest } from '@/lib/execution/payloads/large-array-manifest'
 import { isLargeValueRef } from '@/lib/execution/payloads/large-value-ref'
@@ -496,6 +497,9 @@ describe('BlockExecutor', () => {
       expect.objectContaining({ cause: expect.objectContaining({ code: 'ECONNRESET' }) })
     )
     expect(JSON.stringify(logged)).not.toContain('owner-secret-id')
+    /** Logged here at error, so the engine and the run surfaces must see it as already logged. */
+    expect(classifyFailure(thrown)).toBe('internal')
+    expect(wasFailureLogged(thrown)).toBe(true)
   })
 
   it('fires block completion callbacks for pausing blocks so clients receive pause output', async () => {
@@ -614,11 +618,15 @@ describe('BlockExecutor', () => {
     const ctx = createContext(state)
     ctx.abortSignal = abortController.signal
 
-    await expect(executor.execute(ctx, createNode(block), block)).rejects.toThrow(/abort/i)
+    const thrown = await executor.execute(ctx, createNode(block), block).catch((error) => error)
+    expect(thrown).toBeInstanceOf(Error)
+    expect(thrown.message).toMatch(/abort/i)
 
     const output = state.getBlockOutput(block.id)
     expect(output?.error).toBeTruthy()
     expect(output).not.toEqual({ content: '' })
+    /** A user Stop is not a Sim fault, so it must not page at error. */
+    expect(classifyFailure(thrown)).toBe('user')
   })
 
   it('keeps Sim Chat secret policy in runtime inputs and out of trace inputs', async () => {

apps/sim/tools/index.test.ts

@@ -1,4 +1,5 @@
 import { createSessionPrincipal } from '@sim/testing/factories/principal.factory'
+import { jsonResponse } from '@sim/testing/helpers/http'
 import { apiKeyByokMock, apiKeyByokMockFns } from '@sim/testing/mocks/api-key-byok.mock'
 import { authInternalMock, authInternalMockFns } from '@sim/testing/mocks/auth-internal.mock'
 import { billingUsageLogMock } from '@sim/testing/mocks/billing-usage-log.mock'
@@ -5832,20 +5833,13 @@ describe('Centralized Error Handling', () => {
       return buildBlockExecutionError({ block: apiBlock, error: thrown as Error })
     }
 
-    function jsonResponse(status: number, body: unknown): Response {
-      return new Response(JSON.stringify(body), {
-        status,
-        headers: { 'content-type': 'application/json' },
-      })
-    }
-
     it.each([
       [404, 'third_party_client'],
       [503, 'third_party_server'],
     ] as const)(
       'attributes an upstream %i to the third party, logged once by the tool layer',
       async (status, kind) => {
-        const blockError = await failApiBlock(jsonResponse(status, { error: 'rejected' }))
+        const blockError = await failApiBlock(jsonResponse({ error: 'rejected' }, status))
         expect(classifyFailure(blockError)).toBe(kind)
         expect(wasFailureLogged(blockError)).toBe(true)
       }
@@ -5864,7 +5858,7 @@ describe('Centralized Error Handling', () => {
         throw transformError
       }
       try {
-        const blockError = await failApiBlock(jsonResponse(200, { ok: false }))
+        const blockError = await failApiBlock(jsonResponse({ ok: false }))
         expect(classifyFailure(blockError)).toBe(kind)
         expect(wasFailureLogged(blockError)).toBe(true)
       } finally {