fix(changelog): keep notes open on a failed save, reject out-of-range cursors

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/changelog/changelog.tsx

@@ -54,10 +54,13 @@ function ChangelogContent({ workspaceId }: ChangelogProps) {
       ) : (
         <div
           ref={setScrollElement}
-          className={cn('@container/changelog min-h-0 flex-1 overflow-y-auto', scrollFadeClass)}
+          className={cn(
+            '@container/changelog min-h-0 flex-1 overflow-y-auto py-10',
+            scrollFadeClass
+          )}
           {...scrollFadeAttributes(edges)}
         >
-          <div className='mx-auto flex max-w-[960px] flex-col gap-12 px-8 py-10'>
+          <div className='mx-auto flex max-w-[960px] flex-col gap-12 px-8'>
             {releases.map((release) => (
               <ReleaseEntry
                 key={release.id}

apps/sim/app/workspace/[workspaceId]/changelog/components/release-entry/release-entry.tsx

@@ -31,6 +31,7 @@ const DATE_FORMAT = new Intl.DateTimeFormat('en-US', { month: 'short', day: 'num
 /** One shipped release: the date and version rail, then its title, body, and change lines. */
 export function ReleaseEntry({ workspaceId, release, canEdit, onEditDetails }: ReleaseEntryProps) {
   const saveRef = useRef<(() => Promise<void>) | null>(null)
+  const saveFailedRef = useRef(false)
   const [editingBody, setEditingBody] = useState(false)
   const [savingBody, setSavingBody] = useState(false)
   const file = useAddressedWorkspaceFileRecord(workspaceId, release.fileId)
@@ -60,14 +61,17 @@ export function ReleaseEntry({ workspaceId, release, canEdit, onEditDetails }: R
                 disabled={savingBody}
                 onClick={async () => {
                   setSavingBody(true)
+                  saveFailedRef.current = false
                   try {
                     await saveRef.current?.()
-                    setEditingBody(false)
                   } catch (error) {
-                    toast.error(getErrorMessage(error, 'Failed to save notes'))
+                    if (!saveFailedRef.current)
+                      toast.error(getErrorMessage(error, 'Failed to save notes'))
+                    saveFailedRef.current = true
                   } finally {
                     setSavingBody(false)
                   }
+                  if (!saveFailedRef.current) setEditingBody(false)
                 }}
               >
                 {savingBody ? 'Saving...' : 'Done'}
@@ -106,6 +110,10 @@ export function ReleaseEntry({ workspaceId, release, canEdit, onEditDetails }: R
               canEdit={editingBody}
               readOnly={!editingBody}
               saveRef={saveRef}
+              onSaveError={(error) => {
+                saveFailedRef.current = true
+                toast.error(getErrorMessage(error, 'Failed to save notes'))
+              }}
             />
           </div>
         ) : null}

apps/sim/lib/changelog/application/changelog.ts

@@ -119,9 +119,10 @@ function decodeCursor(cursor: string): ReleaseCursor {
   const separator = cursor.indexOf(':')
   const millis = Number(cursor.slice(0, separator))
   const id = cursor.slice(separator + 1)
-  if (separator < 1 || !Number.isSafeInteger(millis) || id.length === 0)
+  const publishedAt = new Date(millis)
+  if (separator < 1 || Number.isNaN(publishedAt.getTime()) || id.length === 0)
     throw new OrchestrationError('validation', 'cursor must be the nextCursor from a list')
-  return { publishedAt: new Date(millis), id }
+  return { publishedAt, id }
 }
 
 async function assertChangesInWorkspace(