fix(google): tighten Docs tab/number parsing, normalize Slides soft breaks, reuse jsonResponse helper

Author: waleedlatif1

apps/sim/tools/google_docs/utils.ts

@@ -22,7 +22,8 @@ export function resolveDocumentId(params: {
  * request targets the document's first tab, matching the API default.
  */
 export function resolveTabId(tabId: unknown): string | undefined {
-  if (typeof tabId !== 'string') return undefined
+  if (tabId === undefined || tabId === null) return undefined
+  if (typeof tabId !== 'string') throw new Error('Tab ID must be a string')
   const trimmed = tabId.trim()
   return trimmed || undefined
 }
@@ -32,7 +33,8 @@ export function resolveTabId(tabId: unknown): string | undefined {
  * string (agent tool-calls). Returns `undefined` when absent or not finite.
  */
 export function parseOptionalNumber(value: unknown): number | undefined {
-  if (value === undefined || value === null || value === '') return undefined
+  if (value === undefined || value === null) return undefined
+  if (typeof value === 'string' && value.trim() === '') return undefined
   const parsed = Number(value)
   return Number.isFinite(parsed) ? parsed : undefined
 }

apps/sim/tools/google_drive/get_content.test.ts

@@ -1,3 +1,4 @@
+import { jsonResponse } from '@sim/testing/helpers/http'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import { getContentTool } from '@/tools/google_drive/get_content'
 import { MAX_EXPORT_BYTES } from '@/tools/google_drive/utils'
@@ -6,10 +7,6 @@ const transform = getContentTool.transformResponse as NonNullable<
   typeof getContentTool.transformResponse
 >
 
-function metadataResponse(metadata: Record<string, unknown>): Response {
-  return new Response(JSON.stringify(metadata), { status: 200 })
-}
-
 function streamOf(totalBytes: number, chunkBytes = 1024 * 1024): ReadableStream<Uint8Array> {
   let sent = 0
   return new ReadableStream({
@@ -36,7 +33,7 @@ describe('google_drive_get_content byte limits', () => {
   it('refuses a binary file whose declared size exceeds the download cap before fetching it', async () => {
     await expect(
       transform(
-        metadataResponse({
+        jsonResponse({
           id: 'file-1',
           name: 'huge.bin',
           mimeType: 'application/octet-stream',
@@ -56,7 +53,7 @@ describe('google_drive_get_content byte limits', () => {
 
     await expect(
       transform(
-        metadataResponse({
+        jsonResponse({
           id: 'doc-1',
           name: 'Doc',
           mimeType: 'application/vnd.google-apps.document',

apps/sim/tools/google_slides/utils.ts

@@ -135,14 +135,14 @@ export function authJsonHeaders(accessToken: string) {
  */
 export function slidesPresentationUrl(
   presentationId: string | undefined,
-  pageObjectId?: string,
+  pageObjectId?: string | number,
   suffix = ''
 ): string {
   const id = presentationId?.trim()
   if (!id) throw new Error('Presentation ID is required')
   const base = `https://slides.googleapis.com/v1/presentations/${safeUrlPathSegment(id, 'presentationId')}`
   if (pageObjectId === undefined) return `${base}${suffix}`
-  const pageId = pageObjectId.trim()
+  const pageId = String(pageObjectId).trim()
   if (!pageId) throw new Error('Page Object ID is required')
   return `${base}/pages/${safeUrlPathSegment(pageId, 'pageObjectId')}${suffix}`
 }
@@ -177,6 +177,7 @@ function textContentToString(text: SlidesTextContent | undefined): string {
   return elements
     .map((element) => element.textRun?.content ?? element.autoText?.content ?? '')
     .join('')
+    .replace(/\v/g, '\n')
 }
 
 function pageElementText(element: SlidesPageElement): string[] {