test(logs): assert only the boundary behavior in the execute-workflow case

Author: waleedlatif1

apps/sim/executor/types.ts

@@ -489,7 +489,7 @@ export interface ExecutionContext {
   resolvedSecretTraceRegistry?: ResolvedSecretTraceRegistry
   /** Exact candidates that may be carried by this block's terminal error, never its normal output. */
   errorResolvedSecretTraceRegistry?: ResolvedSecretTraceRegistry
-  /** The provider call behind this block's terminal error, for its failure line; set per block. */
+  /** Provider and model behind this block's terminal error, added to its failure line. */
   errorDiagnosticDetails?: { provider?: string; model?: string }
   workflowVariables?: Record<string, any>
   workflowVariableResolvedSecretTraceProvenance?: Record<string, ResolvedSecretTraceProvenanceV1>

apps/sim/lib/workflows/executor/execute-workflow.test.ts

@@ -7,7 +7,7 @@ import { posthogServerMock } from '@sim/testing/mocks/posthog-server.mock'
 import { tableEventsMock } from '@sim/testing/mocks/table-events.mock'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 import type { BillingAttributionSnapshot } from '@/lib/billing/core/billing-attribution'
-import { classifyFailure, logFailureOnce } from '@/lib/core/errors/failure-log'
+import { logFailureOnce } from '@/lib/core/errors/failure-log'
 import { CredentialRevokedError } from '@/lib/oauth/credential-revoked'
 import type { ExecutionSnapshot } from '@/executor/execution/snapshot'
 import type { ExecutionCallbacks } from '@/executor/execution/types'
@@ -267,13 +267,9 @@ describe('executeWorkflow', () => {
   })
 
   it.each([
-    [
-      'a revoked credential, attributed to its owner,',
-      new CredentialRevokedError('Reconnect your account'),
-      'user',
-    ],
-    ['an internal fault', new Error('connection pool exhausted'), 'internal'],
-  ] as const)('logs %s once for its execution', async (_name, executionError, kind) => {
+    ['a revoked credential', new CredentialRevokedError('Reconnect your account')],
+    ['an internal fault', new Error('connection pool exhausted')],
+  ] as const)('logs %s once for its execution', async (_name, executionError) => {
     executeWorkflowCoreMock.mockRejectedValueOnce(executionError)
 
     await expect(
@@ -287,7 +283,6 @@ describe('executeWorkflow', () => {
       )
     ).rejects.toBe(executionError)
 
-    expect(classifyFailure(executionError)).toBe(kind)
     /** The boundary logged it for this execution, so a later boundary in the same run skips it. */
     expect(
       logFailureOnce(createLogger('OuterBoundary'), 'probe', executionError, {