test(design): colocate conformance suites

Author: Bill Leoutsakos

package.json

@@ -18,10 +18,10 @@
     "test:setup": "bun run --cwd packages/sim-setup test",
     "test:integration": "bun --no-env-file scripts/test-integration.ts",
     "test:search-performance": "KNOWLEDGE_SEARCH_PERFORMANCE_TEST=true bun --no-env-file scripts/test-integration.ts search-latency",
-    "format": "biome format --write scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance*.ts scripts/generate-design-contracts*.ts && turbo run format",
-    "format:check": "biome format scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance*.ts scripts/generate-design-contracts*.ts && turbo run format:check",
-    "lint": "biome check --write scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance*.ts scripts/generate-design-contracts*.ts && turbo run lint",
-    "lint:check": "biome check scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance*.ts scripts/generate-design-contracts*.ts && turbo run lint:check",
+    "format": "biome format --write scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance.ts && turbo run format",
+    "format:check": "biome format scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance.ts && turbo run format:check",
+    "lint": "biome check --write scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance.ts && turbo run lint",
+    "lint:check": "biome check scripts/design-conformance scripts/design-scan scripts/design-studio tools/design-studio scripts/check-design-conformance.ts && turbo run lint:check",
     "lint:helm": "helm lint helm/sim --strict --values helm/sim/ci/default-values.yaml",
     "lint:all": "bun run lint && bun run lint:helm",
     "check": "bun run format:check",

scripts/check-script-test-coverage.ts

@@ -1,13 +1,13 @@
 #!/usr/bin/env bun
 /**
- * Asserts every `scripts/*.test.ts` file is collected by the scripts Vitest config.
+ * Asserts script tests are collected by the scripts Vitest config.
  *
  * The root `test` script once chained a hand-maintained list of `test:*` entries, and a
  * hand-maintained list silently drifts from the files on disk: a test added without a matching
  * entry never runs, in CI or locally, and nothing reports it. `scripts/check-migrations-safety.test.ts`
  * sat unreferenced and green for exactly that reason. `scripts/vitest.config.ts` now collects
- * the directory by glob, so drift can only come from a file the glob does not match (a test in a
- * subdirectory, a different suffix) or from the `test` script no longer chaining `test:scripts`.
+ * the root and tooling directories by glob. This guard walks script subdirectories so a new
+ * test outside those globs cannot be silently skipped. `scripts/openapi` has its own suite.
  * This guard checks both by asking Vitest which files it would run.
  *
  * `run-audits.ts` derives its own list from the `check:*` namespace precisely so a new audit is
@@ -57,10 +57,15 @@ const collected = new Set(
   )
 )
 
-const onDisk = readdirSync(path.join(ROOT, 'scripts'))
-  .filter((file) => file.endsWith('.test.ts'))
-  .map((file) => `scripts/${file}`)
-  .sort()
+function scriptTests(directory: string): string[] {
+  return readdirSync(path.join(ROOT, directory), { withFileTypes: true }).flatMap((entry) => {
+    const file = `${directory}/${entry.name}`
+    if (entry.isDirectory()) return file === 'scripts/openapi' ? [] : scriptTests(file)
+    return entry.isFile() && /\.test\.(?:ts|mjs)$/.test(entry.name) ? [file] : []
+  })
+}
+
+const onDisk = scriptTests('scripts').sort()
 
 const orphaned = onDisk.filter((file) => !collected.has(file))
 if (orphaned.length > 0) {

…n-conformance-colour-assignments.test.ts …n-conformance/colour-assignments.test.tsscripts/check-design-conformance-colour-assignments.test.ts renamed to scripts/design-conformance/colour-assignments.test.ts scripts/check-design-conformance-colour-assignments.test.ts renamed to scripts/design-conformance/colour-assignments.test.ts

@@ -22,8 +22,8 @@ import { GitSource } from '#design-conformance/worktree-source'
 
 const temp = mkdtempSync(path.join(os.tmpdir(), 'design-command-'))
 afterAll(() => rmSync(temp, { recursive: true, force: true }))
-const cli = fileURLToPath(new URL('./check-design-conformance.ts', import.meta.url))
-const ci = fileURLToPath(new URL('./design-conformance/ci.ts', import.meta.url))
+const cli = fileURLToPath(new URL('../check-design-conformance.ts', import.meta.url))
+const ci = fileURLToPath(new URL('./ci.ts', import.meta.url))
 const ui = 'apps/sim/components/example.tsx'
 
 function fixture() {
@@ -1167,10 +1167,7 @@ test('the relocated registry remains a central-system change and formatting stay
   const file = 'scripts/design-conformance/contracts.json'
   expect(isRegistry(file)).toBe(true)
   expect(isRegistry('scripts/other/contracts.json')).toBe(false)
-  const registry = readFileSync(
-    new URL('./design-conformance/contracts.json', import.meta.url),
-    'utf8'
-  )
+  const registry = readFileSync(new URL('./contracts.json', import.meta.url), 'utf8')
   expect(hash(registry)).toBe(contractsHash)
   const entry = { path: TOKEN_FILE, blob: 'a'.repeat(40), mode: '100644' }
   const compare = (before: string, after: string) =>