chore(notion): replace non-null assertions in tests and shrink the explicit-any baseline

Author: waleedlatif1

apps/sim/tools/notion/responses.test.ts

@@ -1,10 +1,15 @@
-import { afterEach, describe, expect, it, vi } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import { notionCreateCommentTool } from '@/tools/notion/create_comment'
 import { notionCreatePageTool, notionCreatePageV2Tool } from '@/tools/notion/create_page'
 import { notionReadTool, notionReadV2Tool } from '@/tools/notion/read'
 import { notionUpdatePageTool, notionUpdatePageV2Tool } from '@/tools/notion/update_page'
 import { notionWriteTool } from '@/tools/notion/write'
 
+function defined<T>(value: T | undefined): T {
+  if (value === undefined) throw new Error('Expected the tool to define this handler')
+  return value
+}
+
 const PAGE_TITLE = 'Project Apollo'
 
 function pageResponse(): Response {
@@ -75,14 +80,18 @@ describe('Notion rich text length limit', () => {
       id: notionWriteTool.id,
       richText: () =>
         paragraphRichText(
-          notionWriteTool.request.body!({ accessToken: 't', pageId: 'p', content: longText })
+          defined(notionWriteTool.request.body)({
+            accessToken: 't',
+            pageId: 'p',
+            content: longText,
+          })
         ),
     },
     {
       id: notionCreatePageTool.id,
       richText: () =>
         paragraphRichText(
-          notionCreatePageTool.request.body!({
+          defined(notionCreatePageTool.request.body)({
             accessToken: 't',
             parentId: 'p',
             content: longText,
@@ -93,7 +102,7 @@ describe('Notion rich text length limit', () => {
       id: notionCreateCommentTool.id,
       richText: () =>
         (
-          notionCreateCommentTool.request.body!({
+          defined(notionCreateCommentTool.request.body)({
             accessToken: 't',
             pageId: 'p',
             content: longText,
@@ -111,10 +120,6 @@ describe('Notion rich text length limit', () => {
 })
 
 describe('Notion read page content pagination', () => {
-  afterEach(() => {
-    vi.unstubAllGlobals()
-  })
-
   it('follows next_cursor past the first 100 blocks', async () => {
     const paragraph = (text: string) => ({
       type: 'paragraph',
@@ -130,7 +135,7 @@ describe('Notion read page content pagination', () => {
       )
     vi.stubGlobal('fetch', fetchMock)
 
-    const result = await notionReadV2Tool.transformResponse!(pageResponse(), {
+    const result = await defined(notionReadV2Tool.transformResponse)(pageResponse(), {
       accessToken: 't',
       pageId: 'page-1',
     })

scripts/check-explicit-any.baseline.json

@@ -77,7 +77,6 @@
     "apps/sim/background/workflow-execution.ts": 2,
     "apps/sim/blocks/blocks/agent.test.ts": 1,
     "apps/sim/blocks/blocks/agent.ts": 6,
-    "apps/sim/blocks/blocks/airtable.ts": 5,
     "apps/sim/blocks/blocks/apify.ts": 2,
     "apps/sim/blocks/blocks/browser_use.ts": 2,
     "apps/sim/blocks/blocks/context_dev.ts": 1,
@@ -743,7 +742,6 @@
     "apps/sim/tools/notion/list_comments.ts": 1,
     "apps/sim/tools/notion/list_users.ts": 1,
     "apps/sim/tools/notion/query_database.ts": 4,
-    "apps/sim/tools/notion/read.ts": 16,
     "apps/sim/tools/notion/read_database.ts": 4,
     "apps/sim/tools/notion/retrieve_block.ts": 1,
     "apps/sim/tools/notion/retrieve_block_children.ts": 1,