test(search): normalize Jira fake rows before filtering

Author: waleedlatif1

apps/sim/lib/sim-search/live/atlassian.test.ts

@@ -334,7 +334,7 @@ describe('Confluence plain search ranking', () => {
 
 describe('Jira plain search ranking', () => {
   const search = '/ex/jira/cloud/rest/api/3/search/jql'
-  /** `outsideMatch` marks an issue whose text lacks a query term, so an all-terms clause excludes it. */
+  /** `outsideMatch`: the issue lacks a query term, so a `text ~` all-terms clause drops it. */
   type Issue = string | { key: string; summary: string; outsideMatch?: boolean }
   /**
    * Answers the all-terms query with `exact`, the all-terms summary query with `titled`, and the
@@ -345,7 +345,8 @@ describe('Jira plain search ranking', () => {
     titled: Issue[] | (() => never),
     half: Issue[] | (() => never) = []
   ) {
-    const toRow = (row: Issue) => (typeof row === 'string' ? { key: row, summary: row } : row)
+    const toRow = (row: Issue): Exclude<Issue, string> =>
+      typeof row === 'string' ? { key: row, summary: row } : row
     const issues = (rows: Issue[]) =>
       rows.map(toRow).map(({ key, summary }) => ({ key, fields: { summary } }))
     const json = vi.fn(
@@ -355,9 +356,9 @@ describe('Jira plain search ranking', () => {
         const jql = options?.body?.jql ?? ''
         if (jql.includes('summary ~')) {
           const rows = jql.includes(' OR ') ? half : titled
-          const picked = (typeof rows === 'function' ? rows() : rows).filter(
-            (row) => !jql.includes('text ~') || typeof row === 'string' || !row.outsideMatch
-          )
+          const picked = (typeof rows === 'function' ? rows() : rows)
+            .map(toRow)
+            .filter((row) => !(row.outsideMatch && jql.includes('text ~')))
           return { issues: issues(picked).slice(0, options?.body?.maxResults) }
         }
         return { issues: issues(exact.ids), ...(exact.more ? { nextPageToken: 'page-2' } : {}) }