fix(files): normalize previews and avoid oversized retries

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-category.ts

@@ -1,4 +1,5 @@
 import { getFileExtension } from '@/lib/uploads/utils/file-utils'
+import { normalizeMimeType } from '@/lib/uploads/utils/mime'
 import { SUPPORTED_CODE_EXTENSIONS } from '@/lib/uploads/utils/validation'
 
 const TEXT_EDITABLE_MIME_TYPES = new Set([
@@ -132,7 +133,7 @@ export type FileCategory =
   | 'unsupported'
 
 export function resolveFileCategory(mimeType: string | null, filename: string): FileCategory {
-  mimeType = mimeType?.split(';', 1)[0].trim().toLowerCase() ?? null
+  mimeType = normalizeMimeType(mimeType)
   if (mimeType && TEXT_EDITABLE_MIME_TYPES.has(mimeType)) return 'text-editable'
   if (mimeType && IFRAME_PREVIEWABLE_MIME_TYPES.has(mimeType)) return 'iframe-previewable'
   if (mimeType && IMAGE_PREVIEWABLE_MIME_TYPES.has(mimeType)) return 'image-previewable'
@@ -147,15 +148,15 @@ export function resolveFileCategory(mimeType: string | null, filename: string):
   const sourceName = filename.replace(/\.(example|template|sample|dist|default)$/i, '')
   const nameKey = getFileExtension(sourceName) || sourceName.toLowerCase()
   if (TEXT_EDITABLE_EXTENSIONS.has(nameKey)) return 'text-editable'
-  if (/^\.?env(?: \(\d+\))*(?:\.[\w.-]+)?$/i.test(filename)) return 'text-editable'
-  if (/^dockerfile\.[\w.-]+$/i.test(filename)) return 'text-editable'
   if (IFRAME_PREVIEWABLE_EXTENSIONS.has(ext)) return 'iframe-previewable'
   if (IMAGE_PREVIEWABLE_EXTENSIONS.has(ext)) return 'image-previewable'
   if (AUDIO_PREVIEWABLE_EXTENSIONS.has(ext)) return 'audio-previewable'
   if (VIDEO_PREVIEWABLE_EXTENSIONS.has(ext)) return 'video-previewable'
   if (DOCX_PREVIEWABLE_EXTENSIONS.has(ext)) return 'docx-previewable'
   if (PPTX_PREVIEWABLE_EXTENSIONS.has(ext)) return 'pptx-previewable'
   if (XLSX_PREVIEWABLE_EXTENSIONS.has(ext)) return 'xlsx-previewable'
+  if (/^\.?env(?: \(\d+\))*(?:\.[\w.-]+)?$/i.test(filename)) return 'text-editable'
+  if (/^dockerfile\.[\w.-]+$/i.test(filename)) return 'text-editable'
 
   return 'unsupported'
 }

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/preview-panel.tsx

@@ -6,6 +6,7 @@ import { useTheme } from 'next-themes'
 import '@sim/emcn/components/code/code.css'
 import { CSV_PREVIEW_MAX_ROWS } from '@/lib/api/contracts/workspace-file-table'
 import { getFileExtension } from '@/lib/uploads/utils/file-utils'
+import { normalizeMimeType } from '@/lib/uploads/utils/mime'
 import {
   SIM_ARTIFACT_SHELL,
   SIM_ARTIFACT_STYLESHEET,
@@ -50,6 +51,7 @@ const PREVIEWABLE_EXTENSIONS: Record<string, PreviewType> = {
 export const RICH_PREVIEWABLE_EXTENSIONS = new Set(Object.keys(PREVIEWABLE_EXTENSIONS))
 
 export function resolvePreviewType(mimeType: string | null, filename: string): PreviewType {
+  mimeType = normalizeMimeType(mimeType)
   if (mimeType && PREVIEWABLE_MIME_TYPES[mimeType]) return PREVIEWABLE_MIME_TYPES[mimeType]
   const ext = getFileExtension(filename)
   return PREVIEWABLE_EXTENSIONS[ext] ?? null

apps/sim/hooks/queries/workspace-files.test.tsx

@@ -290,7 +290,9 @@ describe('useWorkspaceFileContent while a superseded key is being re-resolved',
       return { success: true, files: [] }
     })
 
-    const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } })
+    const queryClient = new QueryClient({
+      defaultOptions: { queries: { retry: false, retryDelay: 0 } },
+    })
     const root: Root = createRoot(document.createElement('div'))
     let result: WorkspaceFileContentResult | undefined
 

apps/sim/hooks/queries/workspace-files.ts

@@ -25,7 +25,7 @@ import {
   updateWorkspaceFileDimensionsContract,
 } from '@/lib/api/contracts/workspace-files'
 import { uploadWorkspaceFileSession } from '@/lib/uploads/client/session-upload'
-import { readFileText } from '@/lib/uploads/client/text-content'
+import { FileTextSizeError, readFileText } from '@/lib/uploads/client/text-content'
 import type { UploadProgressEvent } from '@/lib/uploads/client/types'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
 import type { UserFile } from '@/executor/types'
@@ -337,6 +337,7 @@ export function useWorkspaceFileContent(
     },
     enabled: !!workspaceId && !!fileId && !!key,
     staleTime: WORKSPACE_FILE_CONTENT_STALE_TIME,
+    retry: (failureCount, error) => failureCount < 1 && !(error instanceof FileTextSizeError),
     refetchOnWindowFocus: options?.refetchOnWindowFocus === false ? false : 'always',
     refetchInterval: options?.refetchInterval ?? false,
   })

apps/sim/lib/uploads/client/download.ts

@@ -3,6 +3,8 @@ import { requestRaw } from '@/lib/api/client/request'
 import { downloadWorkspaceFileItemsContract } from '@/lib/api/contracts/workspace-file-folders'
 import { exportWorkspaceFileSnapshotContract } from '@/lib/api/contracts/workspace-files'
 import type { WorkspaceFileRecord } from '@/lib/uploads/contexts/workspace'
+import { isMarkdownFile } from '@/lib/uploads/utils/file-utils'
+import { normalizeMimeType } from '@/lib/uploads/utils/mime'
 
 /** Action-time content from the mounted viewer, scoped so another file cannot consume it. */
 export interface FileDownloadSource {
@@ -43,10 +45,7 @@ export async function triggerFileDownload(
   record: WorkspaceFileRecord,
   source?: FileDownloadSource | null
 ): Promise<void> {
-  const isMarkdown =
-    record.type === 'text/markdown' ||
-    record.type === 'text/x-markdown' ||
-    /\.(?:md|markdown)$/i.test(record.name)
+  const isMarkdown = isMarkdownFile(record) || normalizeMimeType(record.type) === 'text/x-markdown'
 
   const content =
     isMarkdown &&

apps/sim/lib/uploads/client/text-content.ts

@@ -5,7 +5,8 @@ export const MAX_TEXT_PREVIEW_BYTES = PASTE_LIMITS.TEXT_EDITOR_BYTES
 export const TEXT_PREVIEW_SIZE_MESSAGE =
   'This file is too large to preview. Download it to view its contents.'
 
-class FileTextSizeError extends Error {
+/** A deterministic preview limit failure that must not trigger a download retry. */
+export class FileTextSizeError extends Error {
   constructor() {
     super(TEXT_PREVIEW_SIZE_MESSAGE)
     this.name = 'FileTextSizeError'

apps/sim/lib/uploads/utils/file-utils.ts

@@ -1,6 +1,7 @@
 import type { Logger } from '@sim/logger'
 import { omit } from '@sim/utils/object'
 import type { StorageContext } from '@/lib/uploads'
+import { normalizeMimeType } from '@/lib/uploads/utils/mime'
 import {
   ACCEPTED_FILE_TYPES,
   isAlphanumericExtension,
@@ -199,7 +200,7 @@ export function getFileExtension(filename: string): string {
  * merge) to exactly the files that can be open in that editor.
  */
 export function isMarkdownFile(file: { type?: string | null; name: string }): boolean {
-  if (file.type === 'text/markdown') return true
+  if (normalizeMimeType(file.type) === 'text/markdown') return true
   const ext = getFileExtension(file.name)
   return ext === 'md' || ext === 'markdown'
 }

apps/sim/lib/uploads/utils/mime.ts

@@ -0,0 +1,4 @@
+/** Returns the lowercase media type without parameters for format matching. */
+export function normalizeMimeType(mimeType: string | null | undefined): string {
+  return mimeType?.split(';', 1)[0].trim().toLowerCase() ?? ''
+}

packages/testing/src/mocks/file-utils.mock.ts

@@ -507,7 +507,7 @@ export const fileUtilsMockFns = {
   mockCreateFileContentFromBase64: vi.fn(createFileContentFromBase64),
   mockGetFileExtension: vi.fn(getFileExtension),
   mockIsMarkdownFile: vi.fn((file: { type?: string | null; name: string }) => {
-    if (file.type === 'text/markdown') return true
+    if (file.type?.split(';', 1)[0].trim().toLowerCase() === 'text/markdown') return true
     const ext = getFileExtension(file.name)
     return ext === 'md' || ext === 'markdown'
   }),