chore(webhooks): tighten poll comments and backoff tests

Poll outcome docs describe what a skipped poll actually does, source failures
keep logging the full error object as the pollers did before, the backoff table
pins the clock past the poll start so it proves the window is anchored there,
and the RSS rate-limit test drives a Retry-After header.

Author: waleedlatif1

apps/sim/lib/webhooks/polling/rss.test.ts

@@ -160,9 +160,10 @@ describe('RSS polling against refusals and rate limits', () => {
 
   it("records a rate-limited fetch as one failure carrying the source's requested wait", async () => {
     mockFetch.mockResolvedValue(
-      new Response('{"ok":false,"description":"Too Many Requests: FLOOD_WAIT_12"}', {
+      new Response('Too Many Requests', {
         status: 429,
         statusText: 'Too Many Requests',
+        headers: { 'Retry-After': '12' },
       })
     )
 

apps/sim/lib/webhooks/polling/rss.ts

@@ -285,10 +285,7 @@ async function fetchNewRssItems(
       return false
     }
 
-    /**
-     * A cached feed can reveal an item after its publication time. Only the fixed
-     * subscription boundary excludes history; the last poll time is not a delivery cursor.
-     */
+    // Cached feeds reveal items late; only the subscription boundary excludes history, never the last poll.
     if (item.isoDate) {
       const itemDate = new Date(item.isoDate)
       if (itemDate <= subscriptionStartedAt) {

apps/sim/lib/webhooks/polling/types.ts

@@ -2,15 +2,15 @@ import type { webhook, workflow } from '@sim/db/schema'
 import type { Logger } from '@sim/logger'
 import { toRecord } from '@sim/utils/object'
 
-/** Outcome of one webhook's poll; `skipped` polls fetched nothing and changed no state. */
+/** Outcome of one webhook's poll; a `skipped` poll counts as neither a success nor a failure. */
 export type PollOutcome = 'success' | 'failure' | 'skipped'
 
 /** Summary returned after polling all webhooks for a provider. */
 export interface PollSummary {
   total: number
   successful: number
   failed: number
-  /** Not polled this tick: backing off after failures, or the payer is over its usage limit. */
+  /** Not polled this tick (source backoff or a recorded admission refusal), or stopped mid-poll on one. */
   skipped: number
 }
 
@@ -55,7 +55,7 @@ export interface PollingProviderHandler {
   /**
    * Process a single webhook entry.
    * Return 'success' (even if 0 new items), 'failure', or 'skipped' when the
-   * poll stopped without consuming anything (an admission rejection mid-poll).
+   * poll stopped on an admission refusal and left the rest for a later poll.
    */
   pollWebhook(ctx: PollWebhookContext): Promise<PollOutcome>
 }

apps/sim/lib/webhooks/polling/utils.test.ts

@@ -1,6 +1,6 @@
 import { dbChainMockFns, resetDbChainMock } from '@sim/testing'
 import { authOAuthUtilsMock } from '@sim/testing/mocks/auth-oauth-utils.mock'
-import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { afterAll, afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 vi.mock('@/lib/oauth/credential-service', () => authOAuthUtilsMock)
 vi.mock('@/triggers/constants', () => ({ MAX_CONSECUTIVE_FAILURES: 5 }))
@@ -58,6 +58,11 @@ describe('poll source backoff', () => {
 
   beforeEach(() => {
     resetDbChainMock()
+    vi.useFakeTimers({ now: pollStartedAt + minutes(5) })
+  })
+
+  afterEach(() => {
+    vi.useRealTimers()
   })
 
   /** Records one source failure on a webhook whose config carries `previousFailures`, returning the merged config update. */
@@ -95,9 +100,9 @@ describe('poll source backoff', () => {
     }
   )
 
-  it('keeps a webhook backed off until its window ends', async () => {
-    const stored = await failOnce(4)
-    const until = Date.parse(String(stored.pollBackoffUntil))
+  it('keeps a webhook backed off until its window ends', () => {
+    const until = pollStartedAt + minutes(16)
+    const stored = { pollBackoffUntil: new Date(until).toISOString() }
 
     expect(isPollBackedOff(stored, until - minutes(1))).toBe(true)
     expect(isPollBackedOff(stored, until)).toBe(false)
@@ -108,11 +113,6 @@ describe('poll source backoff', () => {
     expect(Date.parse(String(stored.pollBackoffUntil))).toBe(pollStartedAt + minutes(10))
   })
 
-  it('lets the next tick poll after one failure even when the failing poll ran long', async () => {
-    const stored = await failOnce(0)
-    expect(isPollBackedOff(stored, pollStartedAt + minutes(1.2))).toBe(false)
-  })
-
   it('ignores a missing or malformed window', () => {
     for (const config of [{}, { pollBackoffUntil: 'not-a-date' }, { pollBackoffUntil: 42 }, null]) {
       expect(isPollBackedOff(config, pollStartedAt)).toBe(false)

apps/sim/lib/webhooks/polling/utils.ts

@@ -2,7 +2,6 @@ import { db } from '@sim/db'
 import { account, webhook, workflow, workflowDeploymentVersion } from '@sim/db/schema'
 import type { Logger } from '@sim/logger'
 import { toNumberOrNull } from '@sim/utils/coerce'
-import { getErrorMessage } from '@sim/utils/errors'
 import { toRecord } from '@sim/utils/object'
 import { backoffWithJitter, parseRetryAfter } from '@sim/utils/retry'
 import { and, eq, isNull, ne, or, sql } from 'drizzle-orm'
@@ -56,7 +55,6 @@ export class PollFetchError extends Error {
   }
 }
 
-/** Reads the wait a rate-limited response asked for, in milliseconds. */
 export function readPollRetryAfterMs(retryAfterHeader: string | null, body: string): number | null {
   const fromHeader = parseRetryAfter(retryAfterHeader, POLL_RETRY_AFTER_MAX_MS)
   if (fromHeader !== null) return fromHeader
@@ -88,7 +86,7 @@ export async function recordPollSourceFailure(
       ...(retryAfterMs !== null ? { retryAfterMs } : {}),
     })
   } else {
-    logger.error(message, { error: getErrorMessage(error, 'Unknown error') })
+    logger.error(message, error)
   }
 
   const failures =