fix(design): retain unresolved links from spread props

Author: Bill Leoutsakos

scripts/design-conformance/control-inventory.ts

@@ -1423,6 +1423,8 @@ export function inspectControls(
     }
     const native = use.target.startsWith('native:')
     const nativeKind = native ? nativeRole(use.target.slice(7), use.inputs) : undefined
+    const unresolvedAnchor =
+      native && use.tag === 'a' && proof.unknown.has('Anchor href remains unresolved')
     const candidate =
       !!nativeKind ||
       (proof.relationships.has('polymorphic-renderer') && proof.unknown.size > 0) ||
@@ -1432,7 +1434,7 @@ export function inspectControls(
         /^on(?:click|doubleclick|pointerdown|mousedown|keydown|keyup)$/i.test(h)
       ) ||
       (native && use.tag === 'input' && !!use.inputs.type?.unresolved) ||
-      (native && use.tag === 'a' && !!use.inputs.href?.unresolved) ||
+      unresolvedAnchor ||
       !!use.inputs.role?.unresolved ||
       !!use.inputs.tabIndex?.unresolved ||
       !!use.inputs.tabIndex?.values?.some((v) => Number(v) >= 0)
@@ -1455,7 +1457,7 @@ export function inspectControls(
       (!native && proof.unknown.size > 0) ||
       !!use.inputs.role?.unresolved ||
       (native && use.tag === 'input' && !!use.inputs.type?.unresolved) ||
-      (native && use.tag === 'a' && !!use.inputs.href?.unresolved)
+      unresolvedAnchor
     const origin: ControlRecord['origin'] = use.hidden
       ? 'nonvisual'
       : central

scripts/design-scan/controls.test.ts

@@ -552,6 +552,18 @@ test('imperative anchors require href or an explicit interaction', () => {
   })
   expect(consumer(f.scan()).map((r) => r.inputs.href?.values)).toEqual([['/go']])
 })
+test('spread anchor href remains unresolved without inventing interaction for an omitted href', () => {
+  const f = fixture({
+    [location]:
+      "export const A=props=><><a {...props} className='rounded-lg'>Unknown</a><a {...props} href={undefined}>Text</a><a {...{href:'/go'}} className='rounded-lg'>Known</a></>",
+  })
+  const result = f.scan()
+  const records = consumer(result)
+  expect(records).toHaveLength(2)
+  expect(records.map((r) => r.origin)).toEqual(['unresolved', 'local-control'])
+  expect(records[0].inputs.className.values).toEqual(['rounded-lg'])
+  expect(result.unchecked.some((d) => d.reason === 'Anchor href remains unresolved')).toBe(true)
+})
 test('DOM class and uppercase attributes normalize before control review', () => {
   const f = fixture({
     [location]: