fix(computer-use): protect terminals, match protected bundle IDs case-insensitively, and remember unlisted app names

Author: waleedlatif1

apps/desktop/README.md

@@ -240,7 +240,8 @@ group with the **Computer Use** restriction. Older desktop builds omit this opti
 continue to work.
 
 The user grants Accessibility and Screen Recording through macOS; every app is then available except
-Sim, System Settings and password managers, which the helper refuses. With **Ask before using a new
+Sim, System Settings, password managers and terminals (shell access has its own Terminal control),
+which the helper refuses. With **Ask before using a new
 app** on, each app's first use is approved for the task or persistently, and persistent approvals are
 listed in Settings and can be revoked. Sign-out and deployment changes clear opt-in, the ask choice
 and approvals. The conversation shows the

apps/desktop/native/computer-use/ComputerUse.swift

@@ -142,15 +142,21 @@ func elementRect(_ element: AXUIElement) -> CGRect? {
           AXValueGetValue(unsafeBitCast(rawSize, to: AXValue.self), .cgSize, &size) else { return nil }
     return CGRect(origin: position, size: size)
 }
-/// Apps computer use never operates: macOS security settings and password managers.
+/// Apps computer use never operates, lowercased: macOS security settings, password managers, and
+/// terminals, whose shell access has its own Terminal control.
 let PROTECTED_APPS: Set<String> = [
-    "com.apple.systempreferences", "com.apple.keychainaccess", "com.apple.Passwords",
-    "com.1password.1password", "com.agilebits.onepassword7", "com.bitwarden.desktop", "org.keepassxc.keepassxc",
+    "com.apple.systempreferences", "com.apple.keychainaccess", "com.apple.passwords",
+    "com.1password.1password", "com.agilebits.onepassword7", "com.agilebits.onepassword-osx", "com.bitwarden.desktop",
+    "org.keepassxc.keepassxc", "com.lastpass.lastpass", "in.sinew.enpass-desktop", "me.proton.pass.electron",
+    "com.markmcguill.strongbox", "com.markmcguill.strongbox.mac",
+    "com.apple.terminal", "com.googlecode.iterm2", "dev.warp.warp-stable", "com.mitchellh.ghostty",
 ]
 func appFor(_ bundleId: String?, launch: Bool = false) async throws -> NSRunningApplication {
     let bundle = try required(bundleId, "bundleId")
-    guard bundle != Bundle.main.bundleIdentifier, !bundle.hasPrefix("com.simstudio."), !bundle.hasPrefix("ai.sim.desktop"), !PROTECTED_APPS.contains(bundle) else {
-        throw ComputerError("protected_app", "Computer use does not operate Sim, System Settings, or password managers.")
+    // Bundle identifiers match case-insensitively in Launch Services.
+    let key = bundle.lowercased()
+    guard key != Bundle.main.bundleIdentifier?.lowercased(), !key.hasPrefix("com.simstudio."), !key.hasPrefix("ai.sim.desktop"), !PROTECTED_APPS.contains(key) else {
+        throw ComputerError("protected_app", "Computer use does not operate Sim, System Settings, password managers, or terminals; use the terminal tool for shell work.")
     }
     var apps = NSRunningApplication.runningApplications(withBundleIdentifier: bundle).filter { !$0.isTerminated }
     if apps.isEmpty && launch {

apps/desktop/src/main/computer-use/service.ts

@@ -144,6 +144,7 @@ export class ComputerUseService {
 
   reset(): void {
     this.cancel()
+    this.appNames.clear()
     this.deps.config.set('computerUseEnabled', false)
     this.deps.config.set('computerUseAskForApps', false)
     this.deps.config.set('computerUseAllowedApps', [])
@@ -397,6 +398,8 @@ export class ComputerUseService {
       this.appNames.clear()
       for (const app of apps.apps) this.appNames.set(app.bundleId, app.name)
     }
+    /** An app outside the scanned folders keeps its bundle ID, so it is not rescanned on every action. */
+    if (!this.appNames.has(bundleId)) this.appNames.set(bundleId, bundleId)
     return this.appNames.get(bundleId) ?? bundleId
   }
 }

apps/docs/content/docs/desktop/index.mdx

@@ -98,13 +98,13 @@ To enable it when available:
 1. Turn **Use apps on this Mac** to **On**.
 2. Select **Allow** next to **Accessibility** (app interaction) and **Screen Recording** (screenshots), grant them in System Settings, then return to Sim.
 
-Sim can then use any app except password managers and macOS System Settings. To approve each app the first time Sim uses it, turn on **Ask before using a new app**; Sim then offers **Allow for This Task**, **Always Allow**, or **Cancel**.
+Sim can then use any app except terminals, password managers, and macOS System Settings; shell work goes through **Terminal** access instead. To approve each app the first time Sim uses it, turn on **Ask before using a new app**; Sim then offers **Allow for This Task**, **Always Allow**, or **Cancel**.
 
 Sim can read app windows and interact through clicks, text, keyboard shortcuts, scrolling, and supported accessibility controls. Screenshots and returned app content can be sent to your Sim deployment and model. Some actions require bringing the app to the foreground; app compatibility and macOS permissions can still limit what succeeds.
 
 The conversation shows the active app and action. Select **Stop**, or press **Cmd + Shift + Escape** when that shortcut is available, to cancel active and queued computer actions. Stopping cannot undo input already delivered to an app. Verify the app's current state before repeating an interrupted action.
 
-With **Ask before using a new app** on, use **Revoke** under **Approved apps** to remove a saved approval. Signing out or changing deployments clears the device opt-in and app approvals. Computer Use never operates Sim, macOS System Settings, or password managers.
+With **Ask before using a new app** on, use **Revoke** under **Approved apps** to remove a saved approval. Signing out or changing deployments clears the device opt-in and app approvals. Computer Use never operates Sim, macOS System Settings, password managers, or terminals.
 
 ### Terminal access
 

apps/sim/app/workspace/[workspaceId]/settings/components/desktop/computer-use.tsx

@@ -11,6 +11,11 @@ import { SettingsSection } from '@/app/workspace/[workspaceId]/settings/componen
 import { useUserPermissionConfig } from '@/ee/access-control/hooks/permission-groups'
 import { useComputerUseStatus } from '@/hooks/use-computer-use-status'
 
+const ON_OFF_OPTIONS = [
+  { value: 'off', label: 'Off' },
+  { value: 'on', label: 'On' },
+]
+
 /** The activity stays visible so an in-flight action can be stopped; the device controls need the permission group's consent. */
 export function ComputerUseSettings() {
   const { workspaceId } = useParams<{ workspaceId: string }>()
@@ -60,10 +65,6 @@ function ComputerUseSettingsControls() {
       setPending(false)
     }
   }
-  const onOff = [
-    { value: 'off', label: 'Off' },
-    { value: 'on', label: 'On' },
-  ]
   const askForApps = status?.askForApps
   const setAskForApps = bridge.setAskForApps
   return (
@@ -75,7 +76,7 @@ function ComputerUseSettingsControls() {
           </Label>
           <ChipSwitch
             aria-label='Use apps on this Mac'
-            options={onOff}
+            options={ON_OFF_OPTIONS}
             value={status?.enabled ? 'on' : 'off'}
             disabled={pending || !status}
             onChange={(value) =>
@@ -84,11 +85,11 @@ function ComputerUseSettingsControls() {
           />
         </div>
         <p className='text-[var(--text-muted)] text-sm'>
-          Works in any app except password managers and System Settings.
+          Sim can use any app except terminals, password managers, and System Settings.
         </p>
         {error && (
           <div className='flex items-center justify-between text-sm'>
-            <span>Couldn't reach the computer use helper.</span>
+            <span>Could not reach the Computer Use helper.</span>
             <Chip onClick={() => void refresh()}>Retry</Chip>
           </div>
         )}
@@ -124,7 +125,7 @@ function ComputerUseSettingsControls() {
                 </Label>
                 <ChipSwitch
                   aria-label='Ask before using a new app'
-                  options={onOff}
+                  options={ON_OFF_OPTIONS}
                   value={askForApps ? 'on' : 'off'}
                   disabled={pending}
                   onChange={(value) =>