Skip to content

Commit 85b731a

Browse files
authored
fix(credentials): point the AWS keyless hint at the policy audience, quote the docs client ID, and correct a stale comment (#9970)
1 parent c79ff1a commit 85b731a

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎apps/docs/content/docs/integrations/aws-credentials.mdx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ AWS accepts a token only when its audience is one of the identity provider's aud
5555
```bash
5656
aws iam add-client-id-to-open-id-connect-provider \
5757
--open-id-connect-provider-arn arn:aws:iam::<account ID>:oidc-provider/<issuer host and path> \
58-
--client-id <your audience>
58+
--client-id '<your audience>'
5959
```
6060

6161
A provider holds up to 100 audiences. Once no role relies on `sts.amazonaws.com` any more, you can remove it from the provider. Reconnecting the credential keeps its audience; clearing the field returns it to the default.

‎apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/aws-account-modal.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ function AwsAccountForm({
256256
<ChipModalField
257257
type='custom'
258258
title='Role trust policy'
259-
hint='Enter the Role ARN first; the policy fills in its account ID. Add the issuer and audience above as an IAM identity provider (once per AWS account; if the provider exists, add the audience to it), set this as the role’s trust policy, then grant the role the permissions your workflows need.'
259+
hint='Enter the Role ARN first; the policy fills in its account ID. Add the issuer above and the policy’s aud value as an IAM identity provider audience (once per AWS account; if the provider exists, add the audience to it), set this as the role’s trust policy, then grant the role the permissions your workflows need.'
260260
>
261261
{(aria) => (
262262
<ChipTextarea

‎apps/sim/lib/credentials/databricks-service-account.server.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -325,9 +325,10 @@ async function verifyWorkspaceIdentity(
325325

326326
/**
327327
* Sim signs tokens for any service principal a member names, and every Sim
328-
* tenant shares the issuer and audience, so a federation policy that matches on
329-
* a claim other than `sub` (a `subject_claim` of `sim_workspace_id`, say) would
330-
* let other Sim credentials act as the principal. Exchanging a subject no
328+
* tenant shares the issuer and can claim any audience (by default the same one),
329+
* so a federation policy that matches on a claim other than `sub` (a
330+
* `subject_claim` of `sim_workspace_id`, say) would let other Sim credentials act
331+
* as the principal. Exchanging a subject no
331332
* credential holds must be refused before the credential is saved.
332333
*/
333334
async function assertPolicyPinsSubject(

0 commit comments

Comments
 (0)