revert(mothership): keep the confirm trace outcome vocabulary unchanged

Drop the held_by_desktop outcome so this change needs no trace contract
update: the 409 paths record tool_call_not_found as before. Keep a route
test for a not-started report on a claimed call.

Author: waleedlatif1

apps/sim/app/api/copilot/confirm/route.test.ts

@@ -1,9 +1,3 @@
-import { trace } from '@opentelemetry/api'
-import {
-  BasicTracerProvider,
-  InMemorySpanExporter,
-  SimpleSpanProcessor,
-} from '@opentelemetry/sdk-trace-base'
 import { copilotHttpMock, copilotHttpMockFns } from '@sim/testing'
 import { encryptionMock, encryptionMockFns } from '@sim/testing/mocks/encryption.mock'
 import {
@@ -12,7 +6,7 @@ import {
 } from '@sim/testing/mocks/mothership-async-runs.mock'
 import { createMockRequest } from '@sim/testing/mocks/request.mock'
 import type { NextRequest } from 'next/server'
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { publishToolConfirmation, getTrustedWorkflowToolExecution } = vi.hoisted(() => ({
   publishToolConfirmation: vi.fn(),
@@ -33,9 +27,6 @@ vi.mock('@/lib/workflows/executor/execution-state', () => ({
   getTrustedWorkflowToolExecution,
 }))
 
-import { CopilotConfirmOutcome } from '@/lib/mothership/generated/trace-attribute-values-v1'
-import { TraceAttr } from '@/lib/mothership/generated/trace-attributes-v1'
-import { TraceSpan } from '@/lib/mothership/generated/trace-spans-v1'
 import { POST } from './route'
 
 const {
@@ -49,17 +40,6 @@ const {
 
 const encryptSecret = encryptionMockFns.mockEncryptSecret
 
-/** Records the confirm spans and returns a reader for the outcome the route recorded. */
-function recordConfirmOutcome(): () => unknown {
-  const exporter = new InMemorySpanExporter()
-  trace.setGlobalTracerProvider(
-    new BasicTracerProvider({ spanProcessors: [new SimpleSpanProcessor(exporter)] })
-  )
-  return () =>
-    exporter.getFinishedSpans().find((span) => span.name === TraceSpan.CopilotConfirmToolResult)
-      ?.attributes[TraceAttr.CopilotConfirmOutcome]
-}
-
 describe('Copilot Confirm API Route', () => {
   const existingRow = {
     toolCallId: 'tool-call-123',
@@ -71,10 +51,6 @@ describe('Copilot Confirm API Route', () => {
     claimedBy: 'workflow:execution-1',
   }
 
-  afterEach(() => {
-    trace.disable()
-  })
-
   beforeEach(() => {
     copilotHttpMockFns.mockAuthenticateCopilotRequestSessionOnly.mockResolvedValue({
       userId: 'user-1',
@@ -175,7 +151,6 @@ describe('Copilot Confirm API Route', () => {
   })
 
   it('rejects a native success before the desktop authorization claim', async () => {
-    const recordedOutcome = recordConfirmOutcome()
     getAsyncToolCall.mockResolvedValue({
       ...existingRow,
       toolName: 'browser_snapshot',
@@ -191,7 +166,6 @@ describe('Copilot Confirm API Route', () => {
     )
 
     expect(response.status).toBe(409)
-    expect(recordedOutcome()).toBe(CopilotConfirmOutcome.HeldByDesktop)
     expect(completeAsyncToolCall).not.toHaveBeenCalled()
     expect(detachAsyncToolCall).not.toHaveBeenCalled()
     expect(encryptSecret).not.toHaveBeenCalled()
@@ -244,7 +218,6 @@ describe('Copilot Confirm API Route', () => {
   ] as const)(
     'rejects a pending %s %s when the native authorization claim wins the race',
     async (toolName, status) => {
-      const recordedOutcome = recordConfirmOutcome()
       getAsyncToolCall.mockResolvedValue({
         ...existingRow,
         toolName,
@@ -264,7 +237,6 @@ describe('Copilot Confirm API Route', () => {
       expect(await response.json()).toEqual({
         error: 'The desktop app holds this tool call; only its own result settles it',
       })
-      expect(recordedOutcome()).toBe(CopilotConfirmOutcome.HeldByDesktop)
       expect(completePendingAsyncToolCall).toHaveBeenCalledOnce()
       expect(completeClaimedAsyncToolCall).not.toHaveBeenCalled()
       expect(completeAsyncToolCall).not.toHaveBeenCalled()
@@ -314,7 +286,6 @@ describe('Copilot Confirm API Route', () => {
   )
 
   it('refuses a not-started report for a call the desktop already claimed', async () => {
-    const recordedOutcome = recordConfirmOutcome()
     getAsyncToolCall.mockResolvedValue({
       ...existingRow,
       toolName: 'browser_snapshot',
@@ -335,7 +306,6 @@ describe('Copilot Confirm API Route', () => {
     expect(await response.json()).toEqual({
       error: 'The desktop app holds this tool call; only its own result settles it',
     })
-    expect(recordedOutcome()).toBe(CopilotConfirmOutcome.HeldByDesktop)
   })
 
   it('does not publish when another terminal transition wins indeterminate claim reconciliation', async () => {

apps/sim/app/api/copilot/confirm/route.ts

@@ -89,8 +89,7 @@ function acknowledgeSettledToolCall(
  * report raced that claim and lost), so only the claim's own result settles it. Final, not
  * retryable: the reporter stops.
  */
-function heldByAnotherReporterResponse(span: Span): NextResponse {
-  span.setAttribute(TraceAttr.CopilotConfirmOutcome, CopilotConfirmOutcome.HeldByDesktop)
+function heldByAnotherReporterResponse(): NextResponse {
   return NextResponse.json(
     { error: 'The desktop app holds this tool call; only its own result settles it' },
     { status: 409 }
@@ -286,7 +285,8 @@ export const POST = withRouteHandler((req: NextRequest) => {
           ? isWorkflowToolExecutionClaimable(existing.status, existing.permissionDecision)
           : existing.status === ASYNC_TOOL_STATUS.running || isPreclaimNativeTerminalOutcome
         if (isNativeClientTool && !isMutableClientToolCall) {
-          return heldByAnotherReporterResponse(span)
+          span.setAttribute(TraceAttr.CopilotConfirmOutcome, CopilotConfirmOutcome.ToolCallNotFound)
+          return heldByAnotherReporterResponse()
         }
         if (isWorkflowTool && !isMutableClientToolCall) {
           span.setAttribute(TraceAttr.CopilotConfirmOutcome, CopilotConfirmOutcome.ToolCallNotFound)
@@ -300,7 +300,8 @@ export const POST = withRouteHandler((req: NextRequest) => {
           data.notStarted === true &&
           existing.status !== ASYNC_TOOL_STATUS.pending
         ) {
-          return heldByAnotherReporterResponse(span)
+          span.setAttribute(TraceAttr.CopilotConfirmOutcome, CopilotConfirmOutcome.ToolCallNotFound)
+          return heldByAnotherReporterResponse()
         }
 
         let effectiveStatus = status
@@ -436,7 +437,8 @@ export const POST = withRouteHandler((req: NextRequest) => {
         }
 
         if (reconciledOutcome === 'conflict' && isPreclaimNativeTerminalOutcome) {
-          return heldByAnotherReporterResponse(span)
+          span.setAttribute(TraceAttr.CopilotConfirmOutcome, CopilotConfirmOutcome.ToolCallNotFound)
+          return heldByAnotherReporterResponse()
         }
 
         if (reconciledOutcome !== 'updated') {

apps/sim/lib/mothership/generated/trace-attribute-values-v1.ts

@@ -115,7 +115,6 @@ export type CopilotChatPersistOutcomeValue =
 export const CopilotConfirmOutcome = {
   Delivered: 'delivered',
   Forbidden: 'forbidden',
-  HeldByDesktop: 'held_by_desktop',
   InternalError: 'internal_error',
   RunNotFound: 'run_not_found',
   ToolCallNotFound: 'tool_call_not_found',