test(computer-use): cover the caret_unconfirmed refusal with an editor that ignores caret moves

Author: waleedlatif1

apps/desktop/native/computer-use/tests/Fixture.swift

@@ -9,9 +9,13 @@ final class MarkerView: NSView {
 }
 
 /// A field that ignores Accessibility focus requests but takes focus from a click, as SwiftUI sheets do.
-final class ClickFocusField: NSTextField {
+class ClickFocusField: NSTextField {
     override func setAccessibilityFocused(_ accessibilityFocused: Bool) {}
 }
+/// A click-only editor that also ignores Accessibility caret moves, so its caret cannot be confirmed.
+final class FixedCaretField: ClickFocusField {
+    override func setAccessibilitySelectedTextRange(_ accessibilitySelectedTextRange: NSRange) {}
+}
 final class FixtureDelegate: NSObject, NSApplicationDelegate {
     var window: NSWindow!
     var count = 0
@@ -36,6 +40,7 @@ final class FixtureDelegate: NSObject, NSApplicationDelegate {
         let secure = NSSecureTextField(string: "fixture-only-secret"); secure.setAccessibilityIdentifier("fixture-password"); secure.setAccessibilityLabel("Fixture password")
         let button = NSButton(title: "Increment", target: self, action: #selector(increment)); button.setAccessibilityIdentifier("fixture-increment")
         let clickField = ClickFocusField(string: ""); clickField.setAccessibilityLabel("Fixture click-focus field")
+        let caretField = FixedCaretField(string: String(repeating: "keep ", count: 40)); caretField.setAccessibilityLabel("Fixture fixed-caret field")
         let sheetButton = NSButton(title: "Show sheet", target: self, action: #selector(showSheet)); sheetButton.setAccessibilityIdentifier("fixture-show-sheet")
         let slider = NSSlider(value: 25, minValue: 0, maxValue: 100, target: nil, action: nil); slider.setAccessibilityLabel("Fixture slider")
         let time = NSDatePicker(); time.datePickerStyle = .textField; time.datePickerElements = .hourMinute; time.setAccessibilityLabel("Fixture time")
@@ -49,9 +54,9 @@ final class FixtureDelegate: NSObject, NSApplicationDelegate {
         scroll.documentView = document
         scroll.contentView.postsBoundsChangedNotifications = true
         NotificationCenter.default.addObserver(self, selector: #selector(scrolled(_:)), name: NSView.boundsDidChangeNotification, object: scroll.contentView)
-        for view in [field, secure, button, counter, clickField, sheetButton, slider, time, timeLabel, marker, scrollCounter, scroll] { stack.addArrangedSubview(view) }
+        for view in [field, secure, button, counter, clickField, caretField, sheetButton, slider, time, timeLabel, marker, scrollCounter, scroll] { stack.addArrangedSubview(view) }
         window.contentView!.addSubview(stack)
-        NSLayoutConstraint.activate([stack.leadingAnchor.constraint(equalTo: window.contentView!.leadingAnchor, constant: 30), stack.trailingAnchor.constraint(equalTo: window.contentView!.trailingAnchor, constant: -30), stack.topAnchor.constraint(equalTo: window.contentView!.topAnchor, constant: 30), field.widthAnchor.constraint(equalTo: stack.widthAnchor), secure.widthAnchor.constraint(equalTo: stack.widthAnchor), clickField.widthAnchor.constraint(equalTo: stack.widthAnchor), slider.widthAnchor.constraint(equalTo: stack.widthAnchor), scroll.widthAnchor.constraint(equalTo: stack.widthAnchor), scroll.heightAnchor.constraint(equalToConstant: 230), marker.widthAnchor.constraint(equalToConstant: 100), marker.heightAnchor.constraint(equalToConstant: 70)])
+        NSLayoutConstraint.activate([stack.leadingAnchor.constraint(equalTo: window.contentView!.leadingAnchor, constant: 30), stack.trailingAnchor.constraint(equalTo: window.contentView!.trailingAnchor, constant: -30), stack.topAnchor.constraint(equalTo: window.contentView!.topAnchor, constant: 30), field.widthAnchor.constraint(equalTo: stack.widthAnchor), secure.widthAnchor.constraint(equalTo: stack.widthAnchor), clickField.widthAnchor.constraint(equalTo: stack.widthAnchor), caretField.widthAnchor.constraint(equalTo: stack.widthAnchor), slider.widthAnchor.constraint(equalTo: stack.widthAnchor), scroll.widthAnchor.constraint(equalTo: stack.widthAnchor), scroll.heightAnchor.constraint(equalToConstant: 230), marker.widthAnchor.constraint(equalToConstant: 100), marker.heightAnchor.constraint(equalToConstant: 70)])
         window.makeKeyAndOrderFront(nil)
         window.makeFirstResponder(field)
         NSApplication.shared.activate()

apps/desktop/native/computer-use/tests/live.py

@@ -183,6 +183,15 @@ def batch(snapshot, steps):
         snapshot = state()
         call('type_text', bundleId=bundle, snapshotId=snapshot['snapshotId'], elementId=find(snapshot, role='AXTextField', label='Fixture click-focus field')['elementId'], text=' twice')
         assert find(state(), role='AXTextField', label='Fixture click-focus field').get('value') == 'clicked twice', 'Click-to-focus typed at the click point'
+        # An editor whose caret cannot be confirmed at the end gets no keystrokes after its focus click.
+        snapshot = state()
+        mutate('click', snapshot, **coordinate(snapshot, find(snapshot, role='AXTextField', label='Fixture editable text')))
+        snapshot = state()
+        caret_field = find(snapshot, role='AXTextField', label='Fixture fixed-caret field')
+        before_text = caret_field.get('value')
+        error = refused('type_text', snapshot, elementId=caret_field['elementId'], text='X')
+        assert error['code'] == 'caret_unconfirmed', error
+        assert find(state(), role='AXTextField', label='Fixture fixed-caret field').get('value') == before_text, 'Text reached an editor whose caret was not confirmed'
         # Select-all first makes the caret position moot: the click-focused editor's whole value is replaced.
         snapshot = state()
         mutate('click', snapshot, **coordinate(snapshot, find(snapshot, role='AXTextField', label='Fixture editable text')))
@@ -200,7 +209,7 @@ def batch(snapshot, steps):
         assert error['dispatchState'] == 'not_started', error
         assert find(state(), role='AXTextField', label='Fixture click-focus field').get('value') == 'replaced', 'A background app was clicked or typed into'
         call('activate_app', bundleId=bundle)
-        print('PASS: real fixture state, secure suppression, AX click/set/action, Unicode typing, keyboard chord, coordinate drag and scrolling, text refused by a slider, typing into a date picker, a window target typing into its focused editor, a title-bar click, a batch that applies, stops at a failing step, refuses before dispatch and stops when a sheet opens, click-to-focus for an editor that ignores Accessibility focus (and none in the background); every mutation verified in fresh state; screenshot=' + ('verified' if permissions['screenRecording'] else 'BLOCKED'))
+        print('PASS: real fixture state, secure suppression, AX click/set/action, Unicode typing, keyboard chord, coordinate drag and scrolling, text refused by a slider, typing into a date picker, a window target typing into its focused editor, a title-bar click, a batch that applies, stops at a failing step, refuses before dispatch and stops when a sheet opens, click-to-focus for an editor that ignores Accessibility focus (inserting at the end, refusing an unconfirmed caret, and none in the background); every mutation verified in fresh state; screenshot=' + ('verified' if permissions['screenRecording'] else 'BLOCKED'))
 finally:
     if fixture:
         fixture.terminate()