fix(files): lock the workspace row before bulk archive and folder restore

Their multi-row deleted_at updates fire the search-index trigger, which upserts the dispatch
queue row before later file rows are locked. A concurrent content write holds the workspace
row and a file row and then waits on that queue row, so the two could deadlock. The exclusive
Project lock used to hide this; take the workspace row first, the order every file writer uses.

Author: waleedlatif1

apps/sim/lib/uploads/contexts/workspace/workspace-file-folder-manager.ts

@@ -5,6 +5,7 @@ import { getErrorMessage, getPostgresErrorCode } from '@sim/utils/errors'
 import { generateId } from '@sim/utils/id'
 import { and, eq, inArray, isNull, min, sql } from 'drizzle-orm'
 import { type ListSortOrder, listOrderBy } from '@/lib/api/list-query'
+import { lockWorkspaceStorageForMutationInTx } from '@/lib/billing/storage'
 import { OrchestrationError } from '@/lib/core/orchestration/types'
 import type { DbOrTx, DbTransaction } from '@/lib/db/types'
 import { FolderCollectionLimitExceededError } from '@/lib/folders/errors'
@@ -308,6 +309,17 @@ async function acquireFileFolderMutationLock(tx: DbTransaction, owner: EditableF
   await lockFileDirectories(tx, [owner])
 }
 
+/**
+ * For operations that archive or restore many file rows: their search-index trigger upserts the
+ * dispatch queue row, so the workspace row must be locked first, the order
+ * {@link lockWorkspaceStorageForMutationInTx} requires of every file writer.
+ */
+async function acquireFileItemsMutationLock(tx: DbTransaction, owner: EditableFileOwner) {
+  await acquireFileFolderMutationLock(tx, owner)
+  if (owner.entityType === 'workspace')
+    await lockWorkspaceStorageForMutationInTx(tx, owner.entityId)
+}
+
 export function buildWorkspaceFileFolderPathMap(
   folders: Array<Pick<RawWorkspaceFileFolder, 'id' | 'name' | 'parentId'>>
 ): Map<string, string> {
@@ -1260,7 +1272,7 @@ async function restoreFileFolder<O extends EditableFileOwner>(
   folderId: string,
   tx: DbTransaction
 ) {
-  await acquireFileFolderMutationLock(tx, owner)
+  await acquireFileItemsMutationLock(tx, owner)
 
   const raw = await tx
     .select()
@@ -1433,7 +1445,7 @@ async function archiveFileItems(
   const explicitFileIds = Array.from(new Set(params.fileIds ?? []))
   const explicitFolderIds = Array.from(new Set(params.folderIds ?? []))
 
-  await acquireFileFolderMutationLock(tx, params.owner)
+  await acquireFileItemsMutationLock(tx, params.owner)
   await assertFileItemsBelongToOwner(params, tx)
 
   const activeFolders = await selectAffectedFileFolders(params.owner, explicitFolderIds, tx)