fix(mailchimp): parse tags as JSON only when they look like JSON and reject malformed JSON

Author: waleedlatif1

apps/sim/tools/mailchimp/mailchimp.test.ts

@@ -94,6 +94,12 @@ describe('Mailchimp request bodies', () => {
     expect(bodyOf(mailchimpAddMemberTagsTool, { ...params, tags: '2024' })).toEqual({
       tags: [{ name: '2024', status: 'active' }],
     })
+    expect(bodyOf(mailchimpAddMemberTagsTool, { ...params, tags: '1e3' })).toEqual({
+      tags: [{ name: '1e3', status: 'active' }],
+    })
+    expect(() =>
+      bodyOf(mailchimpAddMemberTagsTool, { ...params, tags: '[{"name":"VIP"}' })
+    ).toThrow()
     expect(() => bodyOf(mailchimpAddMemberTagsTool, { ...params, tags: '[]' })).toThrow()
   })
 

apps/sim/tools/mailchimp/types.ts

@@ -389,19 +389,24 @@ export function mailchimpMemberSegment(value: string): string {
 
 /**
  * Normalizes the tags input for the member tags endpoint, which requires `{ name, status }`
- * objects. Accepts a JSON array of tag objects or names, or a comma-separated list of names;
- * a tag without a status gets `defaultStatus`.
+ * objects. Accepts a JSON array (or object) of tag objects or names, or a comma-separated list of
+ * names kept as text; a tag without a status gets `defaultStatus`.
  */
 export function buildMemberTags(
   raw: unknown,
   defaultStatus: 'active' | 'inactive'
 ): Array<{ name: string; status: string }> {
   let parsed: unknown = raw
   if (typeof raw === 'string') {
-    try {
-      parsed = JSON.parse(raw)
-    } catch {
-      parsed = raw.split(',')
+    const trimmed = raw.trim()
+    if (trimmed.startsWith('[') || trimmed.startsWith('{')) {
+      try {
+        parsed = JSON.parse(trimmed)
+      } catch {
+        throw new Error('Tags look like JSON but could not be parsed')
+      }
+    } else {
+      parsed = trimmed.split(',')
     }
   }
   const items = Array.isArray(parsed) ? parsed : [parsed]