You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit cf4e2d4
Browse filesBrowse the repository at this point in the historyBrowse files
chore(audits): drop dead ESLint directives and redundant check:dead-code; fix the PPTX blend-group call they hid (#8876)
* chore(audits): drop dead ESLint directives and the redundant check:dead-code script
- Remove all 89 `eslint-disable` comments. Nothing runs ESLint (no eslint dependency or
config in any workspace; Next 16 `next build` has no lint step), so they suppressed
nothing. Reasons they carried are kept as plain `//` whys.
- `check:comment-hygiene` now rejects `eslint-disable`/`eslint-enable` comments so they
cannot return.
- Remove `check:dead-code`: `check:unused-exports` already runs knip with the same config
and a superset of its issue types, and `check:audits` skipped the alias.
- Ignore unused exports in the generated `apps/docs/components/icons.tsx` (a verbatim copy
of the sim icon set, whose export surface is ratcheted at the source) and shrink the
unused-exports baseline by its 66 entries.
* fix(pptx): stop calling the appended rect blend group as a function
* docs(skills): name both ESLint directives the comment audit rejects
* docs: name both ESLint directives in the comment rule
* test(pptx): cover the rect gradient blend-group path
Copy file name to clipboardExpand all lines: .agents/skills/you-might-not-need-a-comment/SKILL.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -33,7 +33,7 @@ This codebase's convention: **TSDoc for documentation; an inline `//` only for a
33
33
- A `//` comment that explains a **non-obvious why**: a workaround for an upstream bug, an ordering constraint, a perf reason, a spec/edge-case the code can't self-document (`// first-match wins — matches the old find() semantics`).
34
34
- Existing TSDoc `/** ... */` blocks on declarations — leave them (only tighten if verbose).
35
35
-`// boundary-raw-fetch:`, `// double-cast-allowed:`, `// boundary-raw-json:`, `// untyped-response:`, `-- migration-safe:` (SQL migrations), `// rq-lint-allow:`, `// client-boundary-allow:` and any other `<kebab-tag>: <reason>` annotation a script under `scripts/` greps for, in line-comment or block-comment form (e.g. the `/** svg-path-precision-exception: ... */` directive on icon paths) — these are load-bearing, never touch them.
36
-
-`// biome-ignore`, `// eslint-disable`, `// @ts-expect-error` and other tooling directives.
36
+
-`// biome-ignore`, `// @ts-expect-error` and other tooling directives. (Nothing runs ESLint, so `eslint-disable`/`eslint-enable` directives are dead; delete them — `check:comment-hygiene` rejects both.)
37
37
-`// TODO` / `// FIXME` that point at real, still-open work.
Copy file name to clipboardExpand all lines: CLAUDE.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ This file (also `AGENTS.md`) holds the repo-wide rules. Area detail lives in `.c
6
6
7
7
-**Package manager**: `bun` and `bunx`, never `npm` and `npx`.
8
8
-**Logging**: `createLogger` from `@sim/logger`; `logger.info` / `logger.warn` / `logger.error`, never `console.log`. Inside `withRouteHandler` the logger already carries the request ID — no manual `withMetadata({ requestId })`.
9
-
-**Comments**: name things so the code explains itself. TSDoc documents exported APIs and non-obvious modules. An inline `//` is only for a terse, non-obvious *why*, or for a script-enforced `// <tag>: <reason>` annotation (`boundary-raw-fetch`, `double-cast-allowed`, `boundary-raw-json`, `untyped-response`, `rq-lint-allow`, `client-boundary-allow`, `utils-lint-allow`, …). History belongs in the commit message. No `====` separators or commented-out code (`check:comment-hygiene` enforces this). The `/you-might-not-need-a-comment` skill applies this to a diff.
9
+
-**Comments**: name things so the code explains itself. TSDoc documents exported APIs and non-obvious modules. An inline `//` is only for a terse, non-obvious *why*, or for a script-enforced `// <tag>: <reason>` annotation (`boundary-raw-fetch`, `double-cast-allowed`, `boundary-raw-json`, `untyped-response`, `rq-lint-allow`, `client-boundary-allow`, `utils-lint-allow`, …). History belongs in the commit message. No `====` separators, commented-out code, or ESLint directives (`eslint-disable`/`eslint-enable`; nothing runs ESLint; `check:comment-hygiene` enforces all three). The `/you-might-not-need-a-comment` skill applies this to a diff.
10
10
-**ID generation**: `generateId()` (UUID v4, the default) or `generateShortId(size?)` (URL-safe, 21 chars by default) from `@sim/utils/id` — never `crypto.randomUUID()`, `nanoid`, or `uuid`. Both use `crypto.getRandomValues()`, so they also work in non-secure (HTTP) browsers. For other randomness, `@sim/utils/random` (`randomInt`, `randomFloat`, `randomItem`, `generateRandomBytes`, `generateRandomHex`) — never `Math.random()` or `crypto.randomBytes()`.
11
11
-**Common utilities**: use the shared helpers from the `@sim/utils/<module>` subpaths instead of inline implementations (`check:utils` bans most of the inline forms below):
12
12
-`sleep(ms)` from `@sim/utils/helpers` — never `new Promise(resolve => setTimeout(resolve, ms))`
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/terminal-session/terminal-session.tsx
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-tabs/resource-tabs.tsx
-3Lines changed: 0 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -363,7 +363,6 @@ export function ResourceTabs({
363
363
// The chat owner handles optimistic state and its single ordered persistence queue.
Copy file name to clipboardExpand all lines: apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/prompt-editor/prompt-editor.tsx
0 commit comments