fix(monaco): allow clearing tags on update and reject empty audience filter groups at any depth

Author: waleedlatif1

apps/docs/content/docs/integrations/monaco.mdx

@@ -217,7 +217,7 @@ Update fields on an existing Monaco contact by ID. Only the fields sent change.
 | `location` | string | No | Location of the contact \(max 256 characters\) |
 | `notes` | string | No | Notes about the contact \(max 1,125,000 characters\) |
 | `doNotContact` | boolean | No | Whether the contact has opted out of outreach |
-| `tags` | array | No | Tag IDs for the contact, as an array or comma-separated list. Replaces the contact's existing tags. |
+| `tags` | array | No | Tag IDs for the contact, as an array or comma-separated list. Replaces the contact's existing tags; send \[\] to remove them all. |
 | `country` | string | No | Country of the contact, as a country name or code \(max 128 characters\) |
 | `jobStartDate` | string | No | Start date of the contact's current job \(YYYY-MM-DD\) |
 | `clearFields` | array | No | Fields to clear on the contact, as an array or comma-separated list. Allowed: first_name, last_name, email, title, phone_number, linkedin_url, notes. |
@@ -596,7 +596,7 @@ Update fields on an existing Monaco account by ID. Only the fields sent change.
 | `businessModel` | string | No | Business model. One of: B2B, B2C. |
 | `companyStatus` | string | No | Operating status of the company. One of: active, acquired, out_of_business, ipo, unknown. |
 | `location` | string | No | Headquarters as "city, state, country" |
-| `tags` | array | No | Tag IDs for the account, as an array or comma-separated list. Replaces the account's existing tags. |
+| `tags` | array | No | Tag IDs for the account, as an array or comma-separated list. Replaces the account's existing tags; send \[\] to remove them all. |
 | `domains` | array | No | The account's complete list of domains, primary first, as an array or comma-separated list \(max 500\). Replaces the whole list: domains left out are removed. Send \[\] to remove them all. |
 | `resetFields` | array | No | Company fields to reset to the linked company's value, as an array or comma-separated list; later company updates fill them again. Allowed: linkedin_url, description, employee_count, founded_year, estimated_annual_revenue_usd, total_funding_usd, last_funding_round, last_funding_date, industries, business_model, company_status, location, domains. |
 | `clearFields` | array | No | Fields to clear on the account, as an array or comma-separated list. Clearing parent_account makes the account top-level and clearing company_id unlinks its company. Allowed: name, notes, owner, parent_account, company_id, linkedin_url, description, employee_count, founded_year, estimated_annual_revenue_usd, total_funding_usd, last_funding_round, last_funding_date, industries, business_model, company_status, location. |
@@ -859,7 +859,7 @@ Update a Monaco opportunity: rename it, change its owner, move it to another sta
 | `estimatedCloseDate` | string | No | Expected close date \(YYYY-MM-DD\) |
 | `actualCloseDate` | string | No | Actual date the opportunity was closed \(YYYY-MM-DD\) |
 | `notes` | string | No | Notes about the opportunity |
-| `tags` | array | No | Tag IDs for the opportunity, as an array or comma-separated list. Replaces the opportunity's existing tags. |
+| `tags` | array | No | Tag IDs for the opportunity, as an array or comma-separated list. Replaces the opportunity's existing tags; send \[\] to remove them all. |
 | `customFields` | json | No | Custom field values to set, as a JSON object keyed by `custom_field_<id>` \(e.g. \{"custom_field_<id>": "value"\}\). Custom fields are always updatable; use Get Field Schemas to find the keys. |
 
 #### Output

apps/sim/tools/generated/tool-metadata.ts

@@ -1,4 +1,4 @@
-import { toRecord } from '@sim/utils/object'
+import { isRecordLike, toRecord } from '@sim/utils/object'
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { MONACO_ACCESS_TOKEN_PARAM } from '@/tools/monaco/params'
 import {
@@ -15,6 +15,13 @@ import {
 } from '@/tools/monaco/utils'
 import type { ToolConfig } from '@/tools/types'
 
+/** Whether a filter list or expression, at any depth, has an empty group, which matches every contact. */
+function hasEmptyFilterGroup(value: unknown): boolean {
+  if (Array.isArray(value)) return value.length === 0 || value.some(hasEmptyFilterGroup)
+  if (isRecordLike(value) && Array.isArray(value.filters)) return hasEmptyFilterGroup(value.filters)
+  return false
+}
+
 export const monacoCreateAudienceTool: ToolConfig<
   MonacoCreateAudienceParams,
   MonacoAudienceResponse
@@ -79,9 +86,9 @@ export const monacoCreateAudienceTool: ToolConfig<
       const excludedIds = parseMonacoOptionalIdList(params.excludedIds, 'excludedIds')
       const sourceAudienceId = params.sourceAudienceId?.trim()
 
-      if (Array.isArray(filters) && filters.length === 0) {
+      if (filters !== undefined && hasEmptyFilterGroup(filters)) {
         throw new Error(
-          'filters must contain at least one rule; an empty list matches every contact'
+          'filters must not contain an empty list or group; an empty group matches every contact'
         )
       }
       if (contactIds && filters) {

apps/sim/tools/monaco/create_audience.ts

@@ -34,7 +34,7 @@ export const monacoDeleteAccountTool: ToolConfig<MonacoDeleteAccountParams, Mona
 
     transformResponse: async (_response, params) => ({
       success: true,
-      output: { id: params?.accountId.trim() ?? '', deleted: true },
+      output: { id: String(params?.accountId ?? '').trim(), deleted: true },
     }),
 
     outputs: {

apps/sim/tools/monaco/delete_account.ts

@@ -33,7 +33,7 @@ export const monacoDeleteContactTool: ToolConfig<MonacoDeleteContactParams, Mona
 
     transformResponse: async (_response, params) => ({
       success: true,
-      output: { id: params?.contactId.trim() ?? '', deleted: true },
+      output: { id: String(params?.contactId ?? '').trim(), deleted: true },
     }),
 
     outputs: {

apps/sim/tools/monaco/delete_contact.ts

@@ -35,7 +35,7 @@ export const monacoDeleteOpportunityTool: ToolConfig<
 
   transformResponse: async (_response, params) => ({
     success: true,
-    output: { id: params?.opportunityId.trim() ?? '', deleted: true },
+    output: { id: String(params?.opportunityId ?? '').trim(), deleted: true },
   }),
 
   outputs: {

apps/sim/tools/monaco/delete_opportunity.ts

@@ -42,7 +42,7 @@ export const monacoUpdateAccountTool: ToolConfig<
       required: false,
       visibility: 'user-or-llm',
       description:
-        "Tag IDs for the account, as an array or comma-separated list. Replaces the account's existing tags.",
+        "Tag IDs for the account, as an array or comma-separated list. Replaces the account's existing tags; send [] to remove them all.",
     },
     domains: {
       type: 'array',

apps/sim/tools/monaco/update_account.ts

@@ -59,7 +59,7 @@ export const monacoUpdateContactTool: ToolConfig<
       required: false,
       visibility: 'user-or-llm',
       description:
-        "Tag IDs for the contact, as an array or comma-separated list. Replaces the contact's existing tags.",
+        "Tag IDs for the contact, as an array or comma-separated list. Replaces the contact's existing tags; send [] to remove them all.",
     },
     country: {
       type: 'string',

apps/sim/tools/monaco/update_contact.ts

@@ -106,7 +106,7 @@ export const monacoUpdateOpportunityTool: ToolConfig<
       required: false,
       visibility: 'user-or-llm',
       description:
-        "Tag IDs for the opportunity, as an array or comma-separated list. Replaces the opportunity's existing tags.",
+        "Tag IDs for the opportunity, as an array or comma-separated list. Replaces the opportunity's existing tags; send [] to remove them all.",
       items: { type: 'string', description: 'Tag ID' },
     },
     customFields: {

apps/sim/tools/monaco/update_opportunity.ts

@@ -450,7 +450,7 @@ export function buildMonacoUpdateContactBody(params: MonacoUpdateContactParams):
   setMonacoString(body, 'location', params.location)
   setMonacoString(body, 'notes', params.notes)
   setMonacoValue(body, 'do_not_contact', params.doNotContact)
-  setMonacoValue(body, 'tags', parseOptionalMonacoList(params.tags, 'tags'))
+  setMonacoValue(body, 'tags', parseMonacoListAllowingEmpty(params.tags, 'tags'))
   setMonacoString(body, 'country', params.country)
   setMonacoString(body, 'job_start_date', params.jobStartDate)
   applyMonacoPatchClears(
@@ -468,7 +468,7 @@ function buildMonacoAccountWriteBody(params: MonacoAccountWriteParams): MonacoRe
   setMonacoString(body, 'status', params.status)
   setMonacoString(body, 'notes', params.notes)
   setMonacoString(body, 'owner', params.owner)
-  setMonacoValue(body, 'tags', parseOptionalMonacoList(params.tags, 'tags'))
+  setMonacoValue(body, 'tags', parseMonacoListAllowingEmpty(params.tags, 'tags'))
   setMonacoString(body, 'parent_account', params.parentAccount)
   setMonacoString(body, 'company_id', params.companyId)
   setMonacoValue(body, 'replace_edited_fields', params.replaceEditedFields)
@@ -760,11 +760,8 @@ export function buildMonacoOpportunityWriteBody(params: {
     body.estimated_value = { currency_code: currencyCode, amount_precise: params.amount }
   }
 
-  const hasTags =
-    params.tags !== undefined &&
-    params.tags !== null &&
-    !(typeof params.tags === 'string' && params.tags.trim() === '')
-  if (hasTags) body.tags = parseMonacoIdList(params.tags, 'tags')
+  const tags = parseMonacoListAllowingEmpty(params.tags, 'tags')
+  if (tags) body.tags = tags
 
   return body
 }