Skip to content

Commit d23e93d

Browse files
committed
fix(tabs): type layout checks and verify touch selection stability
1 parent 8ea2d4d commit d23e93d

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

‎apps/desktop/e2e/browser-chrome.spec.ts‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ mountBrowserChromeFixture(useBrowserPanelOcclusion);`,
137137
.poll(() => label.evaluate((element) => element.getBoundingClientRect().width))
138138
.toBeGreaterThanOrEqual(48)
139139
const neighbor = page.getByRole('tab').nth(2)
140-
const beforeHover = await neighbor.evaluate((element) => ({
140+
const beforeHover = await neighbor.evaluate((element: HTMLElement) => ({
141141
left: element.offsetLeft,
142142
width: element.offsetWidth,
143143
}))
@@ -150,7 +150,7 @@ mountBrowserChromeFixture(useBrowserPanelOcclusion);`,
150150
)
151151
.toBeGreaterThanOrEqual(48)
152152
expect(
153-
await neighbor.evaluate((element) => ({
153+
await neighbor.evaluate((element: HTMLElement) => ({
154154
left: element.offsetLeft,
155155
width: element.offsetWidth,
156156
}))
@@ -195,6 +195,14 @@ mountBrowserChromeFixture(useBrowserPanelOcclusion);`,
195195
)
196196
.toBeGreaterThanOrEqual(48)
197197
await page.screenshot({ path: testInfo.outputPath('crowded-tabs-touch.png') })
198+
const beforeSelection = await attention.evaluate(
199+
(element: HTMLElement) => element.offsetWidth
200+
)
201+
await attention.click()
202+
await expect(attention).toHaveAttribute('aria-selected', 'true')
203+
expect(await attention.evaluate((element: HTMLElement) => element.offsetWidth)).toBe(
204+
beforeSelection
205+
)
198206
} finally {
199207
await session.send('Emulation.setTouchEmulationEnabled', { enabled: false })
200208
await session.detach()

0 commit comments

Comments
 (0)