fix(mothership): preserve partial downloads during compilation

Author: icecrasher321

apps/sim/lib/execution/sandbox/run-task.ts

@@ -1,6 +1,7 @@
 import { AsyncLocalStorage } from 'node:async_hooks'
 import { createLogger } from '@sim/logger'
 import { generateShortId } from '@sim/utils/id'
+import { ContentRefusedError } from '@/lib/core/application'
 import {
   executeInIsolatedVM,
   type IsolatedVMBrokerHandler,
@@ -65,8 +66,16 @@ export async function runSandboxTask<TInput extends SandboxTaskInput>(
   }
   const brokers: Record<string, IsolatedVMBrokerHandler> = {}
   const runInCallerContext = AsyncLocalStorage.snapshot()
+  let brokerRefusal: ContentRefusedError | undefined
   for (const broker of task.brokers) {
-    brokers[broker.name] = (args) => runInCallerContext(() => broker.handle(brokerContext, args))
+    brokers[broker.name] = async (args) => {
+      try {
+        return await runInCallerContext(() => broker.handle(brokerContext, args))
+      } catch (error) {
+        if (error instanceof ContentRefusedError) brokerRefusal = error
+        throw error
+      }
+    }
   }
 
   const request: IsolatedVMExecutionRequest = {
@@ -124,6 +133,8 @@ export async function runSandboxTask<TInput extends SandboxTaskInput>(
       if (result.error.stack) err.stack = result.error.stack
       throw err
     }
+    // IPC carries strings; retain a matching host refusal without reclassifying user-thrown errors.
+    if (brokerRefusal && result.error.message === brokerRefusal.message) throw brokerRefusal
     throw new SandboxUserCodeError(
       result.error.message,
       result.error.name || 'SandboxTaskError',

apps/sim/lib/mothership/__integration__/content-delivery.integration.ts

@@ -149,6 +149,7 @@ import {
 } from '@/lib/uploads/contexts/workspace/workspace-file-manager'
 import type { WorkspaceFileSecretProvenance } from '@/lib/uploads/contexts/workspace/workspace-file-secret-provenance'
 import { WORKSPACE_FILES_DELEGATION_AUDIENCE } from '@/lib/workspace-files/application/authorization'
+import { downloadWorkspaceFileItems } from '@/lib/workspace-files/application/download-workspace-file-items'
 import { readWorkspaceFileContent } from '@/lib/workspace-files/application/read-workspace-file-content'
 import {
   getWorkspaceFileShares,
@@ -431,6 +432,59 @@ describe('content reaching Chat is admitted per item', () => {
       expect(read.body).toContain(fixture.files.entries)
     })
 
+    it.each(['uncached', 'cached', 'recovered', 'user-error', 'subsequent-error'] as const)(
+      'keeps generated-document refusals per item (%s archive)',
+      async (kind) => {
+        const input = fixture.files.unknown
+        const read = `await getFileBase64('${input}');`
+        const code =
+          kind === 'recovered'
+            ? `try { ${read} } catch {} pdf.addPage().drawText('safe fallback');`
+            : kind === 'user-error'
+              ? `const error = new Error('File cannot be sent to a model because its secret provenance is unavailable'); error.name = 'ContentRefusedError'; throw error;`
+              : kind === 'subsequent-error'
+                ? `try { ${read} } catch {} throw new Error('fixture compiler failure');`
+                : `${read} pdf.addPage().drawText('fixture render');`
+        const document = await uploadWorkspaceFile(
+          ws(),
+          fixture.ids.aliceId,
+          Buffer.from(`const archiveFixture = '${generateId()}'; ${code}`),
+          `archive-refusal-${generateId()}.pdf`,
+          'text/x-python-pdf',
+          { notifyWorkspaceChange: false, secretProvenance: { status: 'exact', entries: [] } }
+        )
+        if (kind === 'cached') {
+          const warmed = await downloadWorkspaceFileItems.execute({
+            principal: createSessionPrincipal({ userId: fixture.ids.aliceId }),
+            input: { workspaceId: ws(), fileIds: [document.id], folderIds: [] },
+          })
+          expect(warmed.renderedDocuments.get(document.id)?.subarray(0, 4).toString()).toBe('%PDF')
+        }
+        const route = `/api/v2/files/bulk-download?workspaceId=${ws()}&fileIds=`
+        const mixed = await cli('GET', `${route}${fixture.files.clean},${document.id}`)
+        if (kind === 'user-error' || kind === 'subsequent-error') {
+          expect(mixed.status).toBe(500)
+          expect(mixed.body).toContain('INTERNAL_ERROR')
+          return
+        }
+        expect(mixed.status, mixed.body).toBe(200)
+        expect(mixed.body).toContain(CANARY.clean)
+        expect(mixed.body).not.toContain(CANARY.unknown)
+        expect(mixed.registry.isPermanentlyIncomplete()).toBe(false)
+        if (kind === 'recovered') {
+          expect(mixed.body).toContain('%PDF')
+          expect(mixed.body).not.toContain('sim-download-report.json')
+        } else {
+          expect(mixed.body).not.toContain('%PDF')
+          expect(mixed.body).toContain('sim-download-report.json')
+          expect(mixed.body).toContain(document.id)
+          const alone = await cli('GET', `${route}${document.id}`)
+          expect(alone.status, alone.body).toBe(403)
+          expect(alone.body).not.toContain(CANARY.unknown)
+        }
+      }
+    )
+
     it('answers files search with locations and withheld unreadable previews (#5, misroute)', async () => {
       const read = await cli(
         'GET',

apps/sim/lib/workspace-files/application/download-workspace-file-items.ts

@@ -219,6 +219,10 @@ async function executeDownloadWorkspaceFileItems({
       renderedBytes += buffer.length
       renderedDocuments.set(file.id, buffer)
     } catch (error) {
+      if (error instanceof ContentRefusedError) {
+        filesToZip = filesToZip.filter((admitted) => admitted.id !== file.id)
+        continue
+      }
       if (error instanceof PayloadSizeLimitError) {
         validationError(
           allowance === MAX_RENDERED_DOCUMENT_BYTES