fix(browser-protocol): widen the renderer's wait grace to cover the closing snapshot

Author: waleedlatif1

apps/desktop/src/main/browser-agent/driver.test.ts

@@ -3100,28 +3100,27 @@ describe('credential protection', () => {
 
   it('gives a wait that runs to its timeout a full snapshot budget for its closing observation', async () => {
     const contents = await openPage()
+    let finishSnapshot: (value: unknown) => void = () => {}
     vi.mocked(contents.executeJavaScript).mockImplementation((expression: string) => {
       if (!isPageCall(expression, 'collectSnapshot')) return Promise.resolve(undefined)
-      return new Promise((resolve) =>
-        setTimeout(
-          () =>
-            resolve({
-              url: 'https://example.com/',
-              title: 'Example',
-              outline: '- heading "Order confirmed"',
-              truncated: false,
-              refIds: [],
-              refLineIndexes: {},
-              nextElementId: 1_000,
-            }),
-          8_000
-        )
-      )
+      return new Promise((resolve) => {
+        finishSnapshot = resolve
+      })
     })
     vi.useFakeTimers()
     try {
       const waiting = driver.executeTool('chat-test', 'browser_wait_for', { timeoutMs: 1_000 })
-      await vi.advanceTimersByTimeAsync(30_000)
+      await vi.advanceTimersByTimeAsync(9_000)
+      finishSnapshot({
+        url: 'https://example.com/',
+        title: 'Example',
+        outline: '- heading "Order confirmed"',
+        truncated: false,
+        refIds: [],
+        refLineIndexes: {},
+        nextElementId: 1_000,
+      })
+      await vi.advanceTimersByTimeAsync(1_000)
 
       expect(await waiting).toMatchObject({
         ok: true,

packages/browser-protocol/src/index.ts

@@ -65,7 +65,8 @@ export type BrowserToolName = (typeof BROWSER_TOOL_NAMES)[number]
 
 const BROWSER_WAIT_FOR_DEFAULT_TIMEOUT_MS = 10_000
 const BROWSER_WAIT_FOR_MAX_TIMEOUT_MS = 120_000
-const BROWSER_WAIT_FOR_RENDERER_GRACE_MS = 15_000
+/** Covers the desktop's wait grace and the snapshot a wait ends with (25s), plus transport. */
+const BROWSER_WAIT_FOR_RENDERER_GRACE_MS = 30_000
 export const BROWSER_TOOL_AUTHORIZATION_TIMEOUT_MS = 8_000
 export const BROWSER_NAVIGATION_NATIVE_WATCHDOG_MS = 60_000
 export const BROWSER_TOOL_QUEUE_WAIT_TIMEOUT_MS = BROWSER_NAVIGATION_NATIVE_WATCHDOG_MS