improvement(desktop): run the live desktop E2E against the merged background executor

- The dormancy check accepts the app's own registrations, refused while signed out and answered
  as not enabled once signed in, and still forbids inbox, doorbell, claim, lease and completion
- The app and realtime server run in their own sessions and stop through stop-session.sh

Author: waleedlatif1

.github/workflows/test-build.yml

@@ -510,15 +510,19 @@ jobs:
           # Bundle only: `bun run build` also fetches the macOS node-pty prebuilds for packaging,
           # which a Linux run does not use.
           (cd apps/desktop && bun run scripts/build.ts)
+          # Each app runs in its own session, and stop-session.sh returns once all of it has exited.
           (cd apps/realtime && PORT=3023 SIM_DB_ROLE=realtime ALLOWED_ORIGINS="$NEXT_PUBLIC_APP_URL" \
-            exec bun src/index.ts > "$report_dir/desktop-tools-realtime.log" 2>&1) &
+            exec setsid bun src/index.ts > "$report_dir/desktop-tools-realtime.log" 2>&1) &
           realtime_pid=$!
-          (cd apps/sim && exec node ../../node_modules/next/dist/bin/next dev --hostname 127.0.0.1 \
+          (cd apps/sim && exec setsid node ../../node_modules/next/dist/bin/next dev --hostname 127.0.0.1 \
             --port 3021 > "$report_dir/desktop-tools-next.log" 2>&1) &
           server_pid=$!
           finish() {
-            kill "$server_pid" "$realtime_pid" 2>/dev/null || true
+            status=$?
+            bash "$GITHUB_WORKSPACE/.github/scripts/stop-session.sh" "$server_pid" || status=1
+            bash "$GITHUB_WORKSPACE/.github/scripts/stop-session.sh" "$realtime_pid" || status=1
             wait "$server_pid" "$realtime_pid" 2>/dev/null || true
+            exit "$status"
           }
           trap finish EXIT
           started=$SECONDS

apps/desktop/e2e/desktop-tools-live-sim.spec.ts

@@ -539,7 +539,9 @@ test.describe('desktop tools against a live Sim', () => {
           typeof body.desktopCapabilities === 'object' && body.desktopCapabilities !== null
             ? body.desktopCapabilities
             : {}
-        body.desktopCapabilities = { ...desktop, deviceId, executor: 1 }
+        // The app offers its own install when it speaks the executor protocol; otherwise offer
+        // the device registered above, as such a desktop would.
+        body.desktopCapabilities = { deviceId, executor: 1, ...desktop }
       })
 
       let callId = ''
@@ -570,11 +572,20 @@ test.describe('desktop tools against a live Sim', () => {
       const [call] = await db.toolCalls(user.chats['Round trip'])
       expect(call).toMatchObject({ toolName: 'read_local_file', status: 'completed' })
       expect(call.persistSeq).not.toBeNull()
-      // From launch on, only the foreground claim reaches the desktop routes: no registry, inbox,
-      // lease or completion.
-      const desktopRoutes = proxy.seen(since, '/api/desktop/').map((entry) => entry.path)
-      expect(desktopRoutes.length).toBeGreaterThan(0)
-      expect(new Set(desktopRoutes)).toEqual(new Set(['/api/desktop/tool/authorize']))
+      // From launch on, the app only registers and claims the foreground call: no inbox, doorbell,
+      // executor claim, lease or completion. It registers once signed out (refused) and again on
+      // sign-in, which Sim answers as not enabled and does not record.
+      const registeredSignedIn = () =>
+        proxy
+          .seen(since, '/api/desktop/devices')
+          .some((entry) => entry.method === 'POST' && entry.status === 200)
+      await expect.poll(registeredSignedIn, { timeout: 30_000 }).toBe(true)
+      expect(await db.desktopDeviceCount(user.userId)).toBe(0)
+      const desktopRequests = proxy.seen(since, '/api/desktop/')
+      const desktopRoutes = new Set(desktopRequests.map((entry) => entry.path))
+      expect(desktopRoutes).toContain('/api/desktop/tool/authorize')
+      desktopRoutes.delete('/api/desktop/devices')
+      expect(desktopRoutes).toEqual(new Set(['/api/desktop/tool/authorize']))
       expect(proxy.rewrittenChatBodies).toBeGreaterThan(0)
       expect(monitor.lines.length).toBeGreaterThan(0)
       expect(monitor.publishesTo('desktop:inbox')).toEqual([])