fix(integrations): accept the No change dropdown value without block context, document the legacy Mailchimp landing page type, and type the ServiceNow path tests

Author: waleedlatif1

apps/docs/content/docs/integrations/mailchimp.mdx

@@ -1627,7 +1627,7 @@ Create a new landing page in Mailchimp
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
-| `landingPageType` | string | Yes | The type of landing page: "signup" or "product" |
+| `landingPageType` | string | Yes | The type of landing page: "signup" or "product" \("click-through" is kept for saved workflows but is not in the current API\) |
 | `landingPageTitle` | string | No | The title of the landing page \(e.g., "Join Our Newsletter"\) |
 
 #### Output

apps/sim/blocks/blocks/intercom.ts

@@ -188,10 +188,16 @@ export const IntercomBlock: BlockConfig = {
       id: 'role',
       title: 'Role',
       type: 'dropdown',
+      /**
+       * Update Contact leads with "No change" so a new block does not resend a role. Without block
+       * values (Copilot validation, catalogs) every option is listed, with "No change" last so
+       * the default stays Lead.
+       */
       options: (params) => [
         ...(params?.values.operation === 'update_contact' ? [{ label: 'No change', id: '' }] : []),
         { label: 'Lead', id: 'lead' },
         { label: 'User', id: 'user' },
+        ...(params ? [] : [{ label: 'No change', id: '' }]),
       ],
       condition: {
         field: 'operation',

apps/sim/blocks/blocks/pipedrive.ts

@@ -282,11 +282,17 @@ Return ONLY the timestamp string - no explanations, no quotes, no extra text.`,
       id: 'status',
       title: 'Status',
       type: 'dropdown',
+      /**
+       * Update Deal leads with "No change" so a new block does not reopen deals. Without block
+       * values (Copilot validation, catalogs) every option is listed, with "No change" last so
+       * the default stays Open.
+       */
       options: (params) => [
         ...(params?.values.operation === 'update_deal' ? [{ label: 'No change', id: '' }] : []),
         { label: 'Open', id: 'open' },
         { label: 'Won', id: 'won' },
         { label: 'Lost', id: 'lost' },
+        ...(params ? [] : [{ label: 'No change', id: '' }]),
       ],
       condition: { field: 'operation', value: ['create_deal', 'update_deal'] },
     },

apps/sim/tools/generated/tool-metadata.ts

@@ -39,7 +39,8 @@ export const mailchimpCreateLandingPageTool: ToolConfig<
       type: 'string',
       required: true,
       visibility: 'user-or-llm',
-      description: 'The type of landing page: "signup" or "product"',
+      description:
+        'The type of landing page: "signup" or "product" ("click-through" is kept for saved workflows but is not in the current API)',
     },
     landingPageTitle: {
       type: 'string',

apps/sim/tools/mailchimp/create_landing_page.ts

@@ -17,6 +17,7 @@ import { getIncidentTool } from '@/tools/servicenow/get_incident'
 import { listIncidentsTool } from '@/tools/servicenow/list_incidents'
 import { readRecordTool } from '@/tools/servicenow/read_record'
 import { searchKnowledgeTool } from '@/tools/servicenow/search_knowledge'
+import type { ServiceNowDeleteParams, ServiceNowReadParams } from '@/tools/servicenow/types'
 import { updateChangeStateTool } from '@/tools/servicenow/update_change_state'
 import { updateRecordTool } from '@/tools/servicenow/update_record'
 
@@ -859,8 +860,20 @@ describe('the limit guidance matches what the block actually sends', () => {
 })
 
 describe('ServiceNow URL path segments', () => {
+  function deleteUrl(params: ServiceNowDeleteParams): URL {
+    const { url } = deleteRecordTool.request
+    if (typeof url !== 'function') throw new Error('delete record url must be a builder')
+    return new URL(url(params))
+  }
+
+  function readUrl(params: ServiceNowReadParams): URL {
+    const { url } = readRecordTool.request
+    if (typeof url !== 'function') throw new Error('read record url must be a builder')
+    return new URL(url(params))
+  }
+
   it('keeps valid table names and sys_ids byte-identical', () => {
-    const url = urlOf(deleteRecordTool, {
+    const url = deleteUrl({
       ...auth,
       tableName: 'u_custom_table',
       sysId: '46d44a5dc0a8010e0115a9c2b1a3a8e5',
@@ -870,8 +883,8 @@ describe('ServiceNow URL path segments', () => {
 
   it('rejects a sys_id that would walk to another endpoint', () => {
     expect(() =>
-      urlOf(deleteRecordTool, { ...auth, tableName: 'incident', sysId: '../../sys_user/abc' })
+      deleteUrl({ ...auth, tableName: 'incident', sysId: '../../sys_user/abc' })
     ).toThrow()
-    expect(() => urlOf(readRecordTool, { ...auth, tableName: '..', sysId: 'abc' })).toThrow()
+    expect(() => readUrl({ ...auth, tableName: '..', sysId: 'abc' })).toThrow()
   })
 })