From 7ffc096c78eb04af314a41352bf9817da4cc41ff Mon Sep 17 00:00:00 2001 From: Emiliano Sanchez Date: Mon, 29 Jun 2026 19:45:36 -0300 Subject: [PATCH] Fix TS issues --- package-lock.json | 4 ++-- package.json | 2 +- src/sdkClient/sdkLifecycle.ts | 3 ++- src/sdkFactory/types.ts | 6 +----- src/storages/inLocalStorage/MySegmentsCacheInLocal.ts | 4 +--- src/utils/EventEmitter.d.ts | 3 +++ 6 files changed, 10 insertions(+), 12 deletions(-) create mode 100644 src/utils/EventEmitter.d.ts diff --git a/package-lock.json b/package-lock.json index 0c2b5034..24e3f32a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@splitsoftware/splitio-commons", - "version": "3.0.0", + "version": "3.0.1-rc.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@splitsoftware/splitio-commons", - "version": "3.0.0", + "version": "3.0.1-rc.1", "license": "Apache-2.0", "dependencies": { "@types/ioredis": "^4.28.0", diff --git a/package.json b/package.json index 9c031dfe..d387edfe 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@splitsoftware/splitio-commons", - "version": "3.0.0", + "version": "3.0.1-rc.1", "description": "Split JavaScript SDK common components", "main": "cjs/index.js", "module": "esm/index.js", diff --git a/src/sdkClient/sdkLifecycle.ts b/src/sdkClient/sdkLifecycle.ts index fa0cb602..6e4d1b95 100644 --- a/src/sdkClient/sdkLifecycle.ts +++ b/src/sdkClient/sdkLifecycle.ts @@ -1,5 +1,6 @@ import { releaseApiKey, validateAndTrackApiKey } from '../utils/inputValidation/apiKey'; import { ISdkFactoryContext } from '../sdkFactory/types'; +import { LOCALHOST_MODE } from '../utils/constants'; const COOLDOWN_TIME_IN_MILLIS = 1000; @@ -12,7 +13,7 @@ export function sdkLifecycleFactory(params: ISdkFactoryContext, isSharedClient?: let hasInit = false; let lastActionTime = 0; - const signalListener = platform.SignalListener && new platform.SignalListener(params); + const signalListener = platform.SignalListener && settings.mode !== LOCALHOST_MODE ? new platform.SignalListener(params) : undefined; function __cooldown(func: Function, time: number) { const now = Date.now(); diff --git a/src/sdkFactory/types.ts b/src/sdkFactory/types.ts index 1dd5c7f7..14bffc56 100644 --- a/src/sdkFactory/types.ts +++ b/src/sdkFactory/types.ts @@ -105,11 +105,7 @@ export interface ISdkFactoryParams { // Sdk client method factory. // It Allows to distinguish SDK clients with the client-side API (`IBrowserSDK` and `IBrowserAsyncSDK`) or server-side API (`ISDK` and `IAsyncSDK`). - sdkClientMethodFactory: (params: ISdkFactoryContext) => ( - { (): SplitIO.IBrowserClient & { init(): void }; (key: SplitIO.SplitKey): SplitIO.IBrowserClient & { init(): void }; } | - (() => SplitIO.IClient & { init(): void }) | - (() => SplitIO.IAsyncClient & { init(): void }) - ) + sdkClientMethodFactory: (params: ISdkFactoryContext) => ({ (): SplitIO.IBrowserClient; (key: SplitIO.SplitKey): SplitIO.IBrowserClient; } | (() => SplitIO.IClient) | (() => SplitIO.IAsyncClient)) // Impression observer factory. impressionsObserverFactory: () => IImpressionObserver diff --git a/src/storages/inLocalStorage/MySegmentsCacheInLocal.ts b/src/storages/inLocalStorage/MySegmentsCacheInLocal.ts index 0a1cc258..94ad2e55 100644 --- a/src/storages/inLocalStorage/MySegmentsCacheInLocal.ts +++ b/src/storages/inLocalStorage/MySegmentsCacheInLocal.ts @@ -8,12 +8,10 @@ import { StorageAdapter } from '../types'; export class MySegmentsCacheInLocal extends AbstractMySegmentsCacheSync { private readonly keys: MySegmentsKeyBuilder; - private readonly log: ILogger; private readonly storage: StorageAdapter; - constructor(log: ILogger, keys: MySegmentsKeyBuilder, storage: StorageAdapter) { + constructor(_log: ILogger, keys: MySegmentsKeyBuilder, storage: StorageAdapter) { super(); - this.log = log; this.keys = keys; this.storage = storage; } diff --git a/src/utils/EventEmitter.d.ts b/src/utils/EventEmitter.d.ts new file mode 100644 index 00000000..754737bd --- /dev/null +++ b/src/utils/EventEmitter.d.ts @@ -0,0 +1,3 @@ +import SplitIO from '../../types/splitio'; + +export declare const EventEmitter: new () => SplitIO.IEventEmitter;