From d785d96db8f23ea14546c46234fb87275c6fba47 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Tue, 18 Aug 2026 14:20:34 +0000 Subject: [PATCH] test: migrate `stats/base/dists/geometric/stdev` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 --- .../stats/base/dists/geometric/stdev/test/test.js | 13 ++----------- .../base/dists/geometric/stdev/test/test.native.js | 13 ++----------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.js index 67949a8f4e65..26b483101ee7 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var stdev = require( './../lib' ); @@ -68,8 +67,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function returns the standard deviation of a geometric distribution', function test( t ) { var expected; - var delta; - var tol; var i; var p; var y; @@ -78,13 +75,7 @@ tape( 'the function returns the standard deviation of a geometric distribution', p = data.p; for ( i = 0; i < expected.length; i++ ) { y = stdev( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.native.js index 4ffa0235a0c4..01cb3d2fb274 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/geometric/stdev/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -77,8 +76,6 @@ tape( 'if provided a success probability `p` outside of `[0,1]`, the function re tape( 'the function returns the standard deviation of a geometric distribution', opts, function test( t ) { var expected; - var delta; - var tol; var i; var p; var y; @@ -87,13 +84,7 @@ tape( 'the function returns the standard deviation of a geometric distribution', p = data.p; for ( i = 0; i < expected.length; i++ ) { y = stdev( p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });