From 42b0a39f3758bdbfb6ed15ac05d66e93f365cd95 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 18 Aug 2026 21:21:06 +0000 Subject: [PATCH 1/3] test: migrate `stats/base/dists/levy/logpdf` to ULP-based assertions Replaces the relative-tolerance delta/tol checks in the fixture-based value tests with `isAlmostSameValue` at the minimum required ULP bound (0, i.e. exact match, for all three fixture sets). --- .../dists/levy/logpdf/test/test.factory.js | 32 +++--------------- .../dists/levy/logpdf/test/test.logpdf.js | 32 +++--------------- .../dists/levy/logpdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 85 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js index 21afb5908c0f..2e7a63436d32 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var EPS = require( '@stdlib/constants/float64/eps' ); @@ -145,8 +145,6 @@ tape( 'if provided a nonpositive `c`, the created function always returns `NaN`' tape( 'the created function evaluates the logpdf for `x` given positive `mu`', function test( t ) { var expected; var logpdf; - var delta; - var tol; var mu; var c; var x; @@ -161,13 +159,7 @@ tape( 'the created function evaluates the logpdf for `x` given positive `mu`', f logpdf = factory( mu[i], c[i] ); y = logpdf( x[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); @@ -176,8 +168,6 @@ tape( 'the created function evaluates the logpdf for `x` given positive `mu`', f tape( 'the created function evaluates the logpdf for `x` given negative `mu`', function test( t ) { var expected; var logpdf; - var delta; - var tol; var mu; var c; var x; @@ -192,13 +182,7 @@ tape( 'the created function evaluates the logpdf for `x` given negative `mu`', f logpdf = factory( mu[i], c[i] ); y = logpdf( x[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); @@ -207,8 +191,6 @@ tape( 'the created function evaluates the logpdf for `x` given negative `mu`', f tape( 'the created function evaluates the logpdf for `x` given large variance ( = large `c`)', function test( t ) { var expected; var logpdf; - var delta; - var tol; var mu; var c; var x; @@ -223,13 +205,7 @@ tape( 'the created function evaluates the logpdf for `x` given large variance ( logpdf = factory( mu[i], c[i] ); y = logpdf( x[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js index 467b43924426..00d46f4f92b4 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js @@ -21,8 +21,8 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var EPS = require( '@stdlib/constants/float64/eps' ); @@ -104,8 +104,6 @@ tape( 'if provided a nonpositive `c`, the function returns `NaN`', function test tape( 'the function evaluates the logpdf for `x` given positive `mu`', function test( t ) { var expected; - var delta; - var tol; var mu; var x; var c; @@ -119,13 +117,7 @@ tape( 'the function evaluates the logpdf for `x` given positive `mu`', function for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); @@ -133,8 +125,6 @@ tape( 'the function evaluates the logpdf for `x` given positive `mu`', function tape( 'the function evaluates the logpdf for `x` given negative `mu`', function test( t ) { var expected; - var delta; - var tol; var mu; var x; var c; @@ -148,13 +138,7 @@ tape( 'the function evaluates the logpdf for `x` given negative `mu`', function for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); @@ -162,8 +146,6 @@ tape( 'the function evaluates the logpdf for `x` given negative `mu`', function tape( 'the function evaluates the logpdf for `x` given large variance ( = large `c` )', function test( t ) { var expected; - var delta; - var tol; var mu; var x; var c; @@ -177,13 +159,7 @@ tape( 'the function evaluates the logpdf for `x` given large variance ( = large for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js index a41f28aeddfe..d3a2803bee0b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js @@ -23,11 +23,10 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // FIXTURES // @@ -104,8 +103,6 @@ tape( 'if provided a nonpositive `c`, the function returns `NaN`', opts, functio tape( 'the function evaluates the logpdf for `x` given positive `mu`', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var x; var c; @@ -119,13 +116,7 @@ tape( 'the function evaluates the logpdf for `x` given positive `mu`', opts, fun for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); if ( expected[i] !== null && !(expected[i] === NINF && y === NINF ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); @@ -133,8 +124,6 @@ tape( 'the function evaluates the logpdf for `x` given positive `mu`', opts, fun tape( 'the function evaluates the logpdf for `x` given negative `mu`', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var x; var c; @@ -148,13 +137,7 @@ tape( 'the function evaluates the logpdf for `x` given negative `mu`', opts, fun for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); if ( expected[i] !== null && !(expected[i] === NINF && y === NINF ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); @@ -162,8 +145,6 @@ tape( 'the function evaluates the logpdf for `x` given negative `mu`', opts, fun tape( 'the function evaluates the logpdf for `x` given large variance ( = large `c` )', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var x; var c; @@ -177,13 +158,7 @@ tape( 'the function evaluates the logpdf for `x` given large variance ( = large for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 2.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } t.end(); From 37157d31e73b0925cca683433193ed83621df0b7 Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 19 Aug 2026 00:09:19 -0700 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js | 4 ++-- .../@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js index 2e7a63436d32..cffc812e5ca6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.factory.js @@ -158,7 +158,7 @@ tape( 'the created function evaluates the logpdf for `x` given positive `mu`', f for ( i = 0; i < x.length; i++ ) { logpdf = factory( mu[i], c[i] ); y = logpdf( x[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } @@ -181,7 +181,7 @@ tape( 'the created function evaluates the logpdf for `x` given negative `mu`', f for ( i = 0; i < x.length; i++ ) { logpdf = factory( mu[i], c[i] ); y = logpdf( x[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js index 00d46f4f92b4..b3590388c891 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.logpdf.js @@ -116,7 +116,7 @@ tape( 'the function evaluates the logpdf for `x` given positive `mu`', function c = positiveMean.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } @@ -137,7 +137,7 @@ tape( 'the function evaluates the logpdf for `x` given negative `mu`', function c = negativeMean.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } From 202c03ea663d09631ec8bb0af36c41ff50f1b569 Mon Sep 17 00:00:00 2001 From: Athan Date: Wed, 19 Aug 2026 00:10:25 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../@stdlib/stats/base/dists/levy/logpdf/test/test.native.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js index d3a2803bee0b..b915322adbd5 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/levy/logpdf/test/test.native.js @@ -115,7 +115,7 @@ tape( 'the function evaluates the logpdf for `x` given positive `mu`', opts, fun c = positiveMean.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); - if ( expected[i] !== null && !(expected[i] === NINF && y === NINF ) ) { + if ( expected[i] !== null && !( expected[i] === NINF && y === NINF ) ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } } @@ -136,7 +136,7 @@ tape( 'the function evaluates the logpdf for `x` given negative `mu`', opts, fun c = negativeMean.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], mu[i], c[i] ); - if ( expected[i] !== null && !(expected[i] === NINF && y === NINF ) ) { + if ( expected[i] !== null && !( expected[i] === NINF && y === NINF ) ) { t.strictEqual( isAlmostSameValue( y, expected[ i ], 0 ), true, 'returns expected value' ); } }