diff --git a/tensorboard/webapp/app_routing/store/app_routing_selectors.ts b/tensorboard/webapp/app_routing/store/app_routing_selectors.ts index de2bf3f5a08..3b37511d2ab 100644 --- a/tensorboard/webapp/app_routing/store/app_routing_selectors.ts +++ b/tensorboard/webapp/app_routing/store/app_routing_selectors.ts @@ -131,3 +131,20 @@ export const getExperimentIdToExperimentAliasMap = createSelector( return Object.fromEntries(map.entries()); } ); + +/** + * Returns a map from experiment id to its user-defined alias text, e.g. the + * aliases set in the compare view URL (`/compare/alias1:eid1,alias2:eid2`). + * Empty when the route does not define experiment aliases. + */ +export const getExperimentIdToAliasTextMap = createSelector( + getExperimentIdToExperimentAliasMap, + (aliasMap): Record => { + return Object.fromEntries( + Object.entries(aliasMap).map(([experimentId, alias]) => [ + experimentId, + alias.aliasText, + ]) + ); + } +); diff --git a/tensorboard/webapp/app_routing/store/app_routing_selectors_test.ts b/tensorboard/webapp/app_routing/store/app_routing_selectors_test.ts index f171f874941..e642574cc72 100644 --- a/tensorboard/webapp/app_routing/store/app_routing_selectors_test.ts +++ b/tensorboard/webapp/app_routing/store/app_routing_selectors_test.ts @@ -211,6 +211,44 @@ describe('app_routing_selectors', () => { }); }); + describe('getExperimentIdToAliasTextMap', () => { + beforeEach(() => { + selectors.getExperimentIdToExperimentAliasMap.release(); + selectors.getExperimentIdToAliasTextMap.release(); + }); + + it('returns a map of id to alias text for COMPARE route', () => { + const state = buildStateFromAppRoutingState( + buildAppRoutingState({ + activeRoute: buildRoute({ + routeKind: RouteKind.COMPARE_EXPERIMENT, + params: { + experimentIds: 'exp1:123,exp2:234', + }, + }), + }) + ); + + expect(selectors.getExperimentIdToAliasTextMap(state)).toEqual({ + 123: 'exp1', + 234: 'exp2', + }); + }); + + it('returns an empty map for non-compare route', () => { + const state = buildStateFromAppRoutingState( + buildAppRoutingState({ + activeRoute: buildRoute({ + routeKind: RouteKind.UNKNOWN, + params: {}, + }), + }) + ); + + expect(selectors.getExperimentIdToAliasTextMap(state)).toEqual({}); + }); + }); + describe('getRegisteredRouteKinds', () => { beforeEach(() => { selectors.getRegisteredRouteKinds.release(); diff --git a/tensorboard/webapp/runs/actions/runs_actions.ts b/tensorboard/webapp/runs/actions/runs_actions.ts index 5d361e14004..33c2e49e0d0 100644 --- a/tensorboard/webapp/runs/actions/runs_actions.ts +++ b/tensorboard/webapp/runs/actions/runs_actions.ts @@ -41,6 +41,7 @@ export const fetchRunsSucceeded = createAction( runsForAllExperiments: Run[]; newRuns: ExperimentIdToRuns; expNameByExpId?: Record; + expAliasByExpId?: Record; }>() ); @@ -84,6 +85,7 @@ export const runGroupByChanged = createAction( experimentIds: string[]; groupBy: GroupBy; expNameByExpId?: Record; + expAliasByExpId?: Record; }>() ); diff --git a/tensorboard/webapp/runs/effects/runs_effects.ts b/tensorboard/webapp/runs/effects/runs_effects.ts index 969a07a0236..0ea393c098e 100644 --- a/tensorboard/webapp/runs/effects/runs_effects.ts +++ b/tensorboard/webapp/runs/effects/runs_effects.ts @@ -35,6 +35,7 @@ import * as hparamsActions from '../../hparams/_redux/hparams_actions'; import { getActiveRoute, getDashboardExperimentNames, + getExperimentIdToAliasTextMap, getExperimentIdsFromRoute, getRuns, getRunsLoadState, @@ -226,8 +227,11 @@ export class RunsEffects { } return {newRuns, runsForAllExperiments}; }), - withLatestFrom(this.store.select(getDashboardExperimentNames)), - tap(([runsData, expNameByExpId]) => { + withLatestFrom( + this.store.select(getDashboardExperimentNames), + this.store.select(getExperimentIdToAliasTextMap) + ), + tap(([runsData, expNameByExpId, expAliasByExpId]) => { const {newRuns, runsForAllExperiments} = runsData; this.store.dispatch( actions.fetchRunsSucceeded({ @@ -235,6 +239,7 @@ export class RunsEffects { newRuns, runsForAllExperiments, expNameByExpId, + expAliasByExpId, }) ); }), diff --git a/tensorboard/webapp/runs/effects/runs_effects_test.ts b/tensorboard/webapp/runs/effects/runs_effects_test.ts index 1971cfe0347..5ac6a3f88a0 100644 --- a/tensorboard/webapp/runs/effects/runs_effects_test.ts +++ b/tensorboard/webapp/runs/effects/runs_effects_test.ts @@ -30,6 +30,7 @@ import * as hparamsActions from '../../hparams/_redux/hparams_actions'; import { getActiveRoute, getDashboardExperimentNames, + getExperimentIdToAliasTextMap, getExperimentIdsFromRoute, getRuns, getRunsLoadState, @@ -110,6 +111,7 @@ describe('runs_effects', () => { }); store.overrideSelector(getExperimentIdsFromRoute, null); store.overrideSelector(getActiveRoute, buildRoute()); + store.overrideSelector(getExperimentIdToAliasTextMap, {}); }); afterEach(() => { @@ -176,6 +178,7 @@ describe('runs_effects', () => { 456: 'exp2', 123: 'exp1', }, + expAliasByExpId: {}, }), ]); }); @@ -262,6 +265,7 @@ describe('runs_effects', () => { 456: 'exp2', 123: 'exp1', }, + expAliasByExpId: {}, }), ]); }); @@ -354,6 +358,7 @@ describe('runs_effects', () => { 456: 'exp1', 123: 'exp2', }, + expAliasByExpId: {}, }), ]); }); @@ -391,6 +396,7 @@ describe('runs_effects', () => { runsForAllExperiments: [...createFooRuns()], newRuns: {}, expNameByExpId: {123: 'exp1'}, + expAliasByExpId: {}, }), ]); @@ -399,6 +405,46 @@ describe('runs_effects', () => { expect(actualActions.length).toBe(2); }); + it('includes experiment aliases in fetchRunsSucceeded', () => { + store.overrideSelector(getActiveRoute, buildRoute()); + store.overrideSelector(getExperimentIdsFromRoute, ['123']); + store.overrideSelector(getDashboardExperimentNames, {123: 'exp1'}); + store.overrideSelector(getExperimentIdToAliasTextMap, { + 123: 'alias1', + }); + const createFooRuns = () => [ + createRun({ + id: 'foo/runA', + name: 'runA', + }), + ]; + + selectSpy + .withArgs(getRuns, {experimentId: '123'}) + .and.returnValue(of(createFooRuns())); + store.overrideSelector(getRunsLoadState, { + state: DataLoadState.LOADED, + lastLoadedTimeInMs: 0, + }); + store.refreshState(); + + action.next(buildNavigatedAction()); + + expect(actualActions).toEqual([ + actions.fetchRunsRequested({ + experimentIds: ['123'], + requestedExperimentIds: [], + }), + actions.fetchRunsSucceeded({ + experimentIds: ['123'], + runsForAllExperiments: [...createFooRuns()], + newRuns: {}, + expNameByExpId: {123: 'exp1'}, + expAliasByExpId: {123: 'alias1'}, + }), + ]); + }); + it('dispatches fetchRunsSucceeded even if data is already loaded', () => { const createFooRuns = () => [ createRun({ @@ -434,6 +480,7 @@ describe('runs_effects', () => { runsForAllExperiments: [...createFooRuns()], newRuns: {}, expNameByExpId: {foo: 'exp1'}, + expAliasByExpId: {}, }), ]); }); @@ -515,6 +562,7 @@ describe('runs_effects', () => { 456: {runs: createBarRuns()}, }, expNameByExpId: {456: 'exp1', 123: 'exp2'}, + expAliasByExpId: {}, }), actions.fetchRunsSucceeded({ experimentIds: ['123'], @@ -523,6 +571,7 @@ describe('runs_effects', () => { 123: {runs: createFooRuns()}, }, expNameByExpId: {456: 'exp1', 123: 'exp2'}, + expAliasByExpId: {}, }), ]); }); @@ -652,6 +701,7 @@ describe('runs_effects', () => { }, }, expNameByExpId: {foo: 'exp1', bar: 'exp2'}, + expAliasByExpId: {}, }), actions.fetchRunsSucceeded({ experimentIds: ['foo', 'bar'], @@ -665,6 +715,7 @@ describe('runs_effects', () => { }, }, expNameByExpId: {foo: 'exp1', bar: 'exp2'}, + expAliasByExpId: {}, }), ]); }); diff --git a/tensorboard/webapp/runs/store/runs_reducers.ts b/tensorboard/webapp/runs/store/runs_reducers.ts index 149e1babf2f..2c9baa45e8e 100644 --- a/tensorboard/webapp/runs/store/runs_reducers.ts +++ b/tensorboard/webapp/runs/store/runs_reducers.ts @@ -206,7 +206,7 @@ const dataReducer: ActionReducer = createReducer( }), on( runsActions.fetchRunsSucceeded, - (state, {runsForAllExperiments, expNameByExpId}) => { + (state, {runsForAllExperiments, expNameByExpId, expAliasByExpId}) => { const groupKeyToColorId = new Map(state.groupKeyToColorId); const defaultRunColorIdForGroupBy = new Map( state.defaultRunColorIdForGroupBy @@ -223,7 +223,8 @@ const dataReducer: ActionReducer = createReducer( groupBy, runsForAllExperiments, state.runIdToExpId, - expNameByExpId + expNameByExpId, + expAliasByExpId ); Object.entries(groups.matches).forEach(([groupId, runs]) => { @@ -252,7 +253,7 @@ const dataReducer: ActionReducer = createReducer( runsActions.runGroupByChanged, ( state: RunsDataState, - {experimentIds, groupBy, expNameByExpId} + {experimentIds, groupBy, expNameByExpId, expAliasByExpId} ): RunsDataState => { // Reset the groupKeyToColorId const groupKeyToColorId = new Map(); @@ -268,7 +269,8 @@ const dataReducer: ActionReducer = createReducer( groupBy, allRuns, state.runIdToExpId, - expNameByExpId + expNameByExpId, + expAliasByExpId ); Object.entries(groups.matches).forEach(([groupId, runs]) => { diff --git a/tensorboard/webapp/runs/store/utils.ts b/tensorboard/webapp/runs/store/utils.ts index 1a208094cba..03c012dd8e8 100644 --- a/tensorboard/webapp/runs/store/utils.ts +++ b/tensorboard/webapp/runs/store/utils.ts @@ -16,11 +16,19 @@ import {GroupBy, GroupByKey, Run, RunGroup} from '../types'; import {ExperimentId, RunId} from './runs_types'; +/** + * Groups runs according to `groupBy`. + * + * For `GroupByKey.REGEX_BY_EXP`, the regex is first matched against the + * user-defined experiment alias (e.g. set in the compare view URL), when + * available, and falls back to the experiment name otherwise. + */ export function groupRuns( groupBy: GroupBy, runs: Run[], runIdToExpId: Readonly>, - expNameByExpId?: Record + expNameByExpId?: Record, + expAliasByExpId?: Record ): RunGroup { const matches: {[id: string]: Run[]} = {}; const nonMatches: Run[] = []; @@ -79,8 +87,8 @@ export function groupRuns( case GroupByKey.REGEX_BY_EXP: if ( !groupBy.regexString || - !expNameByExpId || - Object.keys(expNameByExpId).length === 0 + ((!expNameByExpId || Object.keys(expNameByExpId).length === 0) && + (!expAliasByExpId || Object.keys(expAliasByExpId).length === 0)) ) { break; } @@ -92,9 +100,14 @@ export function groupRuns( } for (const run of runs) { - // Tries to match against experiment alias of the run. - const experimentName = expNameByExpId[runIdToExpId[run.id]]; - const matchesList = experimentName.match(regExp); + // Tries to match against the experiment alias of the run first, then + // falls back to the experiment name. + const experimentId = runIdToExpId[run.id]; + const experimentAlias = expAliasByExpId?.[experimentId]; + const experimentName = expNameByExpId?.[experimentId]; + const matchesList = + (experimentAlias ? experimentAlias.match(regExp) : null) ?? + (experimentName ? experimentName.match(regExp) : null); if (matchesList) { const hasCapturingGroup = matchesList.length > 1; // In case regex string does not have a capturing group, we use pseudo diff --git a/tensorboard/webapp/runs/store/utils_test.ts b/tensorboard/webapp/runs/store/utils_test.ts index 2803fac3fb5..baeaac27914 100644 --- a/tensorboard/webapp/runs/store/utils_test.ts +++ b/tensorboard/webapp/runs/store/utils_test.ts @@ -440,6 +440,106 @@ describe('run store utils test', () => { nonMatches: [buildRun({id: 'eid4/gamma', name: 'foo3bar'})], }); }); + + it('groups runs by experiment alias when available', () => { + const actual = groupRuns( + {key: GroupByKey.REGEX_BY_EXP, regexString: '^([^_]+)'}, + [ + buildRun({id: 'eid1/alpha', name: 'alpha'}), + buildRun({id: 'eid2/alpha', name: 'alpha'}), + buildRun({id: 'eid3/alpha', name: 'alpha'}), + ], + { + 'eid1/alpha': 'eid1', + 'eid2/alpha': 'eid2', + 'eid3/alpha': 'eid3', + }, + { + eid1: '20261015T143202', + eid2: '20261021T155814', + eid3: '20261015T010521', + }, + { + eid1: 'heads16', + eid2: 'heads16_resumed', + eid3: 'baseline', + } + ); + + expect(actual).toEqual({ + matches: { + '["heads16"]': [ + buildRun({id: 'eid1/alpha', name: 'alpha'}), + buildRun({id: 'eid2/alpha', name: 'alpha'}), + ], + '["baseline"]': [buildRun({id: 'eid3/alpha', name: 'alpha'})], + }, + nonMatches: [], + }); + }); + + it('falls back to experiment name when the alias does not match', () => { + const actual = groupRuns( + {key: GroupByKey.REGEX_BY_EXP, regexString: 'foo(\\d+)'}, + [ + buildRun({id: 'eid1/alpha', name: 'alpha'}), + buildRun({id: 'eid2/alpha', name: 'alpha'}), + buildRun({id: 'eid3/alpha', name: 'alpha'}), + ], + { + 'eid1/alpha': 'eid1', + 'eid2/alpha': 'eid2', + 'eid3/alpha': 'eid3', + }, + { + eid1: 'foo1', + eid2: 'foo2', + eid3: 'bar', + }, + { + eid1: 'foo2', + eid2: 'no_match', + } + ); + + expect(actual).toEqual({ + matches: { + '["2"]': [ + // Alias "foo2" takes precedence over name "foo1". + buildRun({id: 'eid1/alpha', name: 'alpha'}), + // Alias does not match, so the name "foo2" is used. + buildRun({id: 'eid2/alpha', name: 'alpha'}), + ], + }, + nonMatches: [buildRun({id: 'eid3/alpha', name: 'alpha'})], + }); + }); + + it('groups runs by experiment alias when no names are provided', () => { + const actual = groupRuns( + {key: GroupByKey.REGEX_BY_EXP, regexString: 'foo'}, + [ + buildRun({id: 'eid1/alpha', name: 'alpha'}), + buildRun({id: 'eid2/alpha', name: 'alpha'}), + ], + { + 'eid1/alpha': 'eid1', + 'eid2/alpha': 'eid2', + }, + {}, + { + eid1: 'foo', + eid2: 'bar', + } + ); + + expect(actual).toEqual({ + matches: { + pseudo_group: [buildRun({id: 'eid1/alpha', name: 'alpha'})], + }, + nonMatches: [buildRun({id: 'eid2/alpha', name: 'alpha'})], + }); + }); }); }); diff --git a/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog.ng.html b/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog.ng.html index 8541a95bfa1..ff77b1b4c46 100644 --- a/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog.ng.html +++ b/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog.ng.html @@ -29,7 +29,7 @@

Color runs by regex

Experiment NameExperiment Alias / Name diff --git a/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts b/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts index 18c8f6a2067..8e6612000c8 100644 --- a/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts +++ b/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts @@ -36,6 +36,7 @@ import { getDarkModeEnabled, getDashboardExperimentNames, getEnableColorByExperiment, + getExperimentIdToAliasTextMap, } from '../../../selectors'; import {selectors as settingsSelectors} from '../../../settings/'; import {runGroupByChanged} from '../../actions'; @@ -83,6 +84,7 @@ export class RegexEditDialogContainer { private readonly runIdToEid$: Observable>; private readonly allRuns$: Observable; private readonly expNameByExpId$: Observable>; + private readonly expAliasByExpId$: Observable>; readonly enableColorByExperiment; // Tentative regex string and type are used because we don't want to change the state @@ -123,6 +125,7 @@ export class RegexEditDialogContainer { this.allRuns$, this.runIdToEid$, this.expNameByExpId$, + this.expAliasByExpId$, this.store.select(settingsSelectors.getColorPalette), this.store.select(getDarkModeEnabled) ), @@ -133,6 +136,7 @@ export class RegexEditDialogContainer { allRuns, runIdToEid, expNameByExpId, + expAliasByExpId, colorPalette, darkModeEnabled, ]) => { @@ -144,7 +148,8 @@ export class RegexEditDialogContainer { groupBy, allRuns, runIdToEid, - expNameByExpId + expNameByExpId, + expAliasByExpId ); const groupKeyToColorString = new Map(); const colorRunPairList: ColorGroup[] = []; @@ -177,6 +182,7 @@ export class RegexEditDialogContainer { }>(MAT_DIALOG_DATA); this.expNameByExpId$ = this.store.select(getDashboardExperimentNames); + this.expAliasByExpId$ = this.store.select(getExperimentIdToAliasTextMap); this.enableColorByExperiment = this.store.selectSignal( getEnableColorByExperiment ); @@ -225,7 +231,8 @@ export class RegexEditDialogContainer { // Assigned last: both derived signals subscribe eagerly, and depend on // fields assigned above (groupByRegexTypeObs$, allRuns$, runIdToEid$, - // expNameByExpId$) via the lazy `defer()` in colorRunPairListObs$. + // expNameByExpId$, expAliasByExpId$) via the lazy `defer()` in + // colorRunPairListObs$. this.groupByRegexType = toSignal(this.groupByRegexTypeObs$, { requireSync: true, }); @@ -247,17 +254,21 @@ export class RegexEditDialogContainer { this.groupByRegexStringObs$, this.groupByRegexTypeObs$, this.expNameByExpId$, - ]).subscribe(([regexString, key, expNameByExpId]) => { - if (regexString) { - this.store.dispatch( - runGroupByChanged({ - experimentIds: this.experimentIds, - groupBy: {key, regexString}, - expNameByExpId, - }) - ); - } - }); + this.expAliasByExpId$, + ]) + .pipe(take(1)) + .subscribe(([regexString, key, expNameByExpId, expAliasByExpId]) => { + if (regexString) { + this.store.dispatch( + runGroupByChanged({ + experimentIds: this.experimentIds, + groupBy: {key, regexString}, + expNameByExpId, + expAliasByExpId, + }) + ); + } + }); } } diff --git a/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_test.ts b/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_test.ts index 55b82147532..1375c3dad17 100644 --- a/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_test.ts +++ b/tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_test.ts @@ -38,10 +38,11 @@ import { getRunIdsForExperiment, getRuns, getEnableColorByExperiment, + getExperimentIdToAliasTextMap, } from '../../../selectors'; import {selectors as settingsSelectors} from '../../../settings'; import {buildColorPalette} from '../../../settings/testing'; -import {KeyType, sendKey, SendKeyArgs} from '../../../testing/dom'; +import {KeyType, sendKey, sendKeys, SendKeyArgs} from '../../../testing/dom'; import {provideMockTbStore} from '../../../testing/utils'; import {runGroupByChanged} from '../../actions'; import {buildRun} from '../../store/testing'; @@ -105,6 +106,9 @@ describe('regex_edit_dialog', () => { store.overrideSelector(getDashboardExperimentNames, { rose: 'exp_name_rose', }); + store.overrideSelector(getExperimentIdToAliasTextMap, { + rose: 'alias_rose', + }); store.overrideSelector(getEnableColorByExperiment, true); actualActions = []; // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads. @@ -157,6 +161,7 @@ describe('regex_edit_dialog', () => { runGroupByChanged({ experimentIds: ['rose'], expNameByExpId: {rose: 'exp_name_rose'}, + expAliasByExpId: {rose: 'alias_rose'}, groupBy: {key: GroupByKey.REGEX, regexString: 'test(\\d+)'}, }) ); @@ -183,6 +188,7 @@ describe('regex_edit_dialog', () => { runGroupByChanged({ experimentIds: ['rose'], expNameByExpId: {rose: 'exp_name_rose'}, + expAliasByExpId: {rose: 'alias_rose'}, groupBy: {key: GroupByKey.REGEX, regexString: 'test'}, }) ); @@ -208,16 +214,46 @@ describe('regex_edit_dialog', () => { ); buttons[1].nativeElement.click(); - expect(matSelect.nativeNode.textContent).toBe('Experiment Name'); + expect(matSelect.nativeNode.textContent).toBe('Experiment Alias / Name'); expect(dispatchSpy).toHaveBeenCalledWith( runGroupByChanged({ experimentIds: ['rose'], expNameByExpId: {rose: 'exp_name_rose'}, + expAliasByExpId: {rose: 'alias_rose'}, groupBy: {key: GroupByKey.REGEX_BY_EXP, regexString: 'test'}, }) ); }); + it('dispatches only once on save, even if store values change afterwards', () => { + const fixture = createComponent(['rose']); + fixture.detectChanges(); + + const input = fixture.debugElement.query(By.css('input')); + const keyArgs: SendKeyArgs = { + key: 'test', + prevString: '', + type: KeyType.CHARACTER, + startingCursorIndex: 0, + }; + sendKey(fixture, input, keyArgs); + const buttons = fixture.debugElement.queryAll( + By.css('div[mat-dialog-actions] button') + ); + buttons[1].nativeElement.click(); + const dispatchCountAfterSave = dispatchSpy.calls.count(); + expect(dispatchCountAfterSave).toBeGreaterThan(0); + + // A later change in the store (e.g. navigating to another compare URL) + // must not re-dispatch the saved regex. + store.overrideSelector(getDashboardExperimentNames, { + rose: 'new_exp_name_rose', + }); + store.refreshState(); + + expect(dispatchSpy.calls.count()).toBe(dispatchCountAfterSave); + }); + it('show only one dropdown option if colorByExperiment flag is disabled', () => { const fixture = createComponent(['rose']); store.overrideSelector(getEnableColorByExperiment, false); @@ -281,6 +317,10 @@ describe('regex_edit_dialog', () => { fixture.detectChanges(); const input = fixture.debugElement.query(By.css('input')); + // Type the regex first (emits input events), then press Enter, like a + // user would. sendKey() fires keydown (which saves) before the input + // event, so the text must already be known to the dialog. + sendKeys(fixture, input, 'test'); const keyArgs: SendKeyArgs = { key: 'Enter', prevString: 'test', @@ -293,6 +333,7 @@ describe('regex_edit_dialog', () => { runGroupByChanged({ experimentIds: ['rose'], expNameByExpId: {rose: 'exp_name_rose'}, + expAliasByExpId: {rose: 'alias_rose'}, groupBy: {key: GroupByKey.REGEX, regexString: 'test'}, }) ); @@ -315,6 +356,7 @@ describe('regex_edit_dialog', () => { runGroupByChanged({ experimentIds: ['rose'], expNameByExpId: {rose: 'exp_name_rose'}, + expAliasByExpId: {rose: 'alias_rose'}, groupBy: {key: GroupByKey.REGEX, regexString: 'test regex string'}, }) ); diff --git a/tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ng.html b/tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ng.html index 14724abeee2..2bbee0ac539 100644 --- a/tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ng.html +++ b/tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ng.html @@ -66,7 +66,7 @@ > By Run Name By Experiment Name By Experiment Alias / Name