perf(run-engine): pass the records gate its arguments positionally

The gate took an options object, so every resume allocated a literal to ask a
question that is answered no for every organisation today. Two positional
arguments make the disabled path allocate nothing, which is what the earlier
claim of costing nothing needed in order to be true rather than nearly true.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: d-cs

internal-packages/run-engine/src/engine/systems/waitpointSystem.ts

@@ -38,11 +38,15 @@ export type WaitpointSystemOptions = {
    * transitioning from, so it costs nothing to pass. The run id rides along for logging and for
    * any future per-run override.
    *
+   * Positional rather than an options object, deliberately: an object literal here would be
+   * allocated on every resume, including the ones that exist only to be told no. Two arguments
+   * make the disabled path genuinely free rather than nearly free.
+   *
    * Defaults to never. A record set is only reachable through the snapshot store, so until the
    * ticket that wires that store supplies this predicate there is no run for which one could
    * exist, and no resume does any of this work.
    */
-  completedWaitpointRecordsEnabled?: (args: { runId: string; organizationId: string }) => boolean;
+  completedWaitpointRecordsEnabled?: (runId: string, organizationId: string) => boolean;
 };
 
 type WaitpointContinuationWaitpoint = Pick<Waitpoint, "id" | "type" | "completedAfter" | "status">;
@@ -66,7 +70,7 @@ export class WaitpointSystem {
   private readonly executionSnapshotSystem: ExecutionSnapshotSystem;
   private readonly enqueueSystem: EnqueueSystem;
   private readonly coordinator: WaitpointCoordinator;
-  private readonly recordsEnabled: (args: { runId: string; organizationId: string }) => boolean;
+  private readonly recordsEnabled: (runId: string, organizationId: string) => boolean;
 
   constructor(private readonly options: WaitpointSystemOptions) {
     this.$ = options.resources;
@@ -807,7 +811,7 @@ export class WaitpointSystem {
     // nothing to build, and deciding that by walking its blocking waitpoints made every resume
     // for every organisation pay a scan proportional to its fan-in to reach the same answer.
     // Defaults to never, so today this returns here for everyone.
-    if (!this.recordsEnabled({ runId, organizationId })) {
+    if (!this.recordsEnabled(runId, organizationId)) {
       return undefined;
     }
 

internal-packages/run-engine/src/engine/tests/completedWaitpointRecordsGate.test.ts

@@ -34,7 +34,7 @@ vi.setConfig({ testTimeout: 60_000 });
 function engineWith(
   prisma: never,
   redisOptions: never,
-  completedWaitpointRecordsEnabled?: (args: { runId: string; organizationId: string }) => boolean
+  completedWaitpointRecordsEnabled?: (runId: string, organizationId: string) => boolean
 ) {
   return new RunEngine({
     prisma,
@@ -65,8 +65,8 @@ describe("the completed-waitpoint records gate", () => {
     "is consulted exactly once per resume, with the run's organisation",
     async ({ prisma, redisOptions }) => {
       const consulted: { runId: string; organizationId: string }[] = [];
-      const engine = engineWith(prisma as never, redisOptions as never, (args) => {
-        consulted.push(args);
+      const engine = engineWith(prisma as never, redisOptions as never, (runId, organizationId) => {
+        consulted.push({ runId, organizationId });
         return false;
       });
 

internal-packages/run-engine/src/engine/types.ts

@@ -85,9 +85,11 @@ export type RunEngineOptions = {
    * run id rides along for logging and for any future per-run override; resolving the
    * organisation from it would put a read back on the path this gate keeps free.
    *
+   * Positional arguments, so the disabled path allocates nothing at all.
+   *
    * Omitted means never, so no resume builds a record set.
    */
-  completedWaitpointRecordsEnabled?: (args: { runId: string; organizationId: string }) => boolean;
+  completedWaitpointRecordsEnabled?: (runId: string, organizationId: string) => boolean;
   queue: {
     redis: RedisOptions;
     shardCount?: number;