Fixing issue with newer JDBC driver compatibility

Oracle JDBC 23.x no longer supports { ? = call ?.method() } escape syntax for object method calls — it emits ":2.method()" which PL/SQL rejects on a bind variable.

Author: Jacek Gębal

src/main/java/org/utplsql/api/outputBuffer/DefaultOutputBuffer.java

@@ -1,7 +1,6 @@
 package org.utplsql.api.outputBuffer;
 
 import oracle.jdbc.OracleCallableStatement;
-import oracle.jdbc.OracleConnection;
 import oracle.jdbc.OracleTypes;
 import org.utplsql.api.reporter.Reporter;
 
@@ -28,10 +27,12 @@ class DefaultOutputBuffer extends AbstractOutputBuffer {
 
     @Override
     protected CallableStatement getLinesCursorStatement(Connection conn) throws SQLException {
-        OracleConnection oraConn = conn.unwrap(OracleConnection.class);
-        OracleCallableStatement cstmt = (OracleCallableStatement) oraConn.prepareCall("{? = call ?.get_lines_cursor() }");
+        Reporter reporter = getReporter();
+        String plsql = "DECLARE l_rep " + reporter.getTypeName() + "; "
+                + "BEGIN l_rep := :2; :1 := l_rep.get_lines_cursor(); END;";
+        OracleCallableStatement cstmt = (OracleCallableStatement) conn.prepareCall(plsql);
         cstmt.registerOutParameter(1, OracleTypes.CURSOR);
-        cstmt.setORAData(2, getReporter());
+        cstmt.setORAData(2, reporter);
         return cstmt;
     }
 }

src/main/java/org/utplsql/api/reporter/inspect/ReporterInspector310.java

@@ -1,16 +1,8 @@
 package org.utplsql.api.reporter.inspect;
 
-import oracle.jdbc.OracleCallableStatement;
-import oracle.jdbc.OracleConnection;
-import oracle.jdbc.OracleType;
-import org.utplsql.api.compatibility.CompatibilityProxy;
-import org.utplsql.api.reporter.Reporter;
 import org.utplsql.api.reporter.ReporterFactory;
 
-import java.sql.Connection;
-import java.sql.PreparedStatement;
-import java.sql.ResultSet;
-import java.sql.SQLException;
+import java.sql.*;
 import java.util.*;
 
 /**
@@ -48,7 +40,7 @@ private ReporterInfo getReporterInfo(String reporterNameWithOwner) throws SQLExc
         String reporterName = reporterNameWithOwner.substring(reporterNameWithOwner.indexOf(".") + 1).toUpperCase();
 
         ReporterInfo.Type type = ReporterInfo.Type.SQL;
-        String description = getDescription(reporterName);
+        String description = getDescription(reporterNameWithOwner);
 
         if (registeredReporterFactoryMethods.containsKey(reporterName)) {
             type = ReporterInfo.Type.SQL_WITH_JAVA;
@@ -58,16 +50,12 @@ private ReporterInfo getReporterInfo(String reporterNameWithOwner) throws SQLExc
         return new ReporterInfo(reporterName, type, description);
     }
 
-    private String getDescription(String reporterName) throws SQLException {
-        CompatibilityProxy compatibilityProxy = new CompatibilityProxy(connection);
-        Reporter reporter = reporterFactory.createReporter(reporterName).init(connection, compatibilityProxy, reporterFactory);
-        OracleConnection oraCon = connection.unwrap(OracleConnection.class);
-
-        try (OracleCallableStatement stmt = (OracleCallableStatement) oraCon.prepareCall("{ ? = call ?.get_description() }")) {
-            stmt.registerOutParameter(1, OracleType.VARCHAR2);
-            stmt.setORAData(2, reporter);
+    private String getDescription(String reporterNameWithOwner) throws SQLException {
+        String plsql = "DECLARE l_obj " + reporterNameWithOwner + " := " + reporterNameWithOwner + "(); "
+                + "BEGIN :1 := l_obj.get_description(); END;";
+        try (CallableStatement stmt = connection.prepareCall(plsql)) {
+            stmt.registerOutParameter(1, Types.VARCHAR);
             stmt.execute();
-
             return stmt.getString(1);
         }
     }