diff --git a/.changeset/plain-font-names.md b/.changeset/plain-font-names.md new file mode 100644 index 00000000..d9f807a2 --- /dev/null +++ b/.changeset/plain-font-names.md @@ -0,0 +1,5 @@ +--- +'@youversion/platform-react-ui': patch +--- + +Keep the reader font labels Inter and Untitled Serif in every language. diff --git a/packages/ui/src/components/bible-reader.test.tsx b/packages/ui/src/components/bible-reader.test.tsx index 357947b2..5cd20b54 100644 --- a/packages/ui/src/components/bible-reader.test.tsx +++ b/packages/ui/src/components/bible-reader.test.tsx @@ -29,6 +29,7 @@ import { } from '@/lib/verse-html-utils'; import { installResizeObserverStub } from '@/test/dom-stubs'; +import i18n from '@/i18n'; installResizeObserverStub(); @@ -460,6 +461,40 @@ it('keeps chapter targets canonical while semantic icons follow RTL interface di ).toContain('8.29289'); }); +it('keeps Inter and Untitled Serif in Arabic and Welsh reader font settings', async () => { + const previousLanguage = i18n.language; + + function renderFontSettings(): ReturnType { + return render( + , + ); + } + + try { + await i18n.changeLanguage('ar'); + const arabic = renderFontSettings(); + expect(screen.getByRole('button', { name: /Inter/ })).toBeInTheDocument(); + expect(screen.queryByText('إدخال')).not.toBeInTheDocument(); + arabic.unmount(); + + await i18n.changeLanguage('cy'); + renderFontSettings(); + expect(screen.getByRole('button', { name: /Untitled Serif/ })).toBeInTheDocument(); + expect(screen.queryByText('Serif Dideitl')).not.toBeInTheDocument(); + } finally { + await i18n.changeLanguage(previousLanguage); + } +}); + describe('BibleReader version picker language', () => { it('seeds the version picker with defaultLanguageId instead of the browser language', () => { const { overrides, requestedLanguages } = overridesRecordingVersionLanguage(); diff --git a/packages/ui/src/components/bible-reader.tsx b/packages/ui/src/components/bible-reader.tsx index c074b518..b8ad48f8 100644 --- a/packages/ui/src/components/bible-reader.tsx +++ b/packages/ui/src/components/bible-reader.tsx @@ -1379,6 +1379,9 @@ function UserMenu() { ); } +const INTER_FONT_NAME = 'Inter'; +const UNTITLED_SERIF_FONT_NAME = 'Untitled Serif'; + export function BibleThemeSettingsContent({ theme, fontSize, @@ -1464,7 +1467,7 @@ export function BibleThemeSettingsContent({ > {t('fontLabel')} - {t('interFontName')} + {INTER_FONT_NAME}