chore(upstream): adopt pstack operator-pronoun fixes - #19
Conversation
Adopt the operator-neutral pronoun and in-chat status tick fixes from pstack f5bdd6826fd0a0d9cbc4347134c3a74a200b9d9d (cursor/plugins #362). Skip upstream's model-default and budget changes; mstack keeps portable role configuration and its own default example. The migration tests previously equated the working tree with released content, which broke on any unreleased skill edit. Legacy fixtures and digest-provenance assertions now read the latest released tag; the post-install shared-copy assertion reads the working tree because the installer stages from it. Verified: node scripts/skill-baseline.mjs --check, node scripts/check-upstream.mjs --source <pstack@f5bdd68>, npm test (206 tests, 205 pass, 0 fail; 1 skipped-by-count nuance: 206 total).
|
Found two blocking issues. 1) The skills CI matrix fails: scripts/install-migration.test.mjs:97 and scripts/migration-integration.test.mjs:13 call git show v0.4.1, but .github/workflows/validate.yml uses the default shallow checkout and does not fetch tags. CI reports fatal: invalid object name 'v0.4.1', causing the skills jobs to fail. Please make the tests independent of a local tag, or explicitly fetch the tag/full history. 2) The upstream job checks out the wrong commit: this PR updates profiles/upstreams.json and both manifests to f5bdd6826fd0a0d9cbc4347134c3a74a200b9d9d, while .github/workflows/validate.yml still checks out pstack at 7366ac128bdf95f45e6734f412b49a4031800169. Strict validation fails with a source/profile pin mismatch. Please update the workflow ref. Fix both issues and rerun required checks before merging. |
1 participant
Upstream pstack fixed gendered pronouns for the human operator and reworded the audit tick to post status in chat (cursor/plugins #362, pinned commit \ 5bdd68). The same wording ships in this repository's meta-mode playbooks, and the gendered text is confusing for an agent reading instructions about an unknown operator.
This adopts only that prose fix. It skips the two other upstream changes by design: the grok-4.6 model defaults conflict with mstack's portable role configuration and its provider-neutral default example, and the setup budget ask maps Cursor-specific effort tokens that do not transfer across Harnesses.
\profiles/upstreams.json\ pins the new pstack commit, and both baseline manifests record the reviewed refresh. The migration tests had coupled the working tree to released content; legacy fixtures and digest-provenance assertions now read the latest released tag (\�0.4.1), while the post-install shared-copy assertion keeps reading the working tree because the installer stages from it.
Verification:
ode scripts/skill-baseline.mjs --check\ passes.
ode scripts/check-upstream.mjs --source \ reports no drift; all four artifact groups, the 12 reviewed adaptations, and the 47 canonical skill bodies match.
pm test: 206 tests, 0 failures.
Agent: union-alpha via opencode