Repository navigation
Look for the resource keys link the cloud engine now gives in the cloud tests - #38
Merged
Merged
Conversation
…ud tests #35 moved the resource keys explainer link in the cloud request engine's messages from _info__resource_keys.html to _services__cloud__resource_keys.html. test_missing_property_service_element_not_found and test_missing_property_service_not_found_anywhere still looked for the old link, so they failed in every Test job of the publish.
jwrosewell
marked this pull request as ready for review
November 4, 2026 23:04
Merged
jwrosewell
added a commit
that referenced
this pull request
Nov 4, 2026
Releases what has collected on `rc` since #37: - [#38](#38) Look for the resource keys link the cloud engine now gives in the cloud tests The publish of #37 ([run 41918913736](https://github.com/51Degrees/51degrees-python/actions/runs/41918913736)) failed in every Test job on the two cloud tests #38 fixes, so it pushed nothing to PyPI and made no tags. This release changes only those tests, and its publish builds and releases the packages #37 changed, at the versions #37 would have given them. No commit asks for a major or minor version change, so the publish moves only patch numbers. The last release into `main` was #37, merged at 21:40 UTC on 4 November 2026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish of release #37 (run 41918913736) failed in all 15 Test jobs, on Ubuntu, Windows and macOS, so nothing was pushed to PyPI. In every one of them the only failures were two device detection cloud integration tests:
test_missing_property_service_element_not_foundtest_missing_property_service_not_found_anywhereBoth check that the error raised for a missing property links to the resource keys explainer, and both looked for
https://51degrees.com/documentation/_info__resource_keys.html. #35 moved that link in the cloud request engine's messages (cloudengine.pyandclouddata.py) tohttps://51degrees.com/documentation/_services__cloud__resource_keys.html, followed by the campaign tags. Both addresses answer 200.Change
The two assertions in
device-detection/fiftyone_devicedetection_cloud/tests/test_cloud.py(lines 124 and 175) now look for the new link. A code search of the repository finds the old link nowhere else.How it is checked
The pull request builds passed these two tests after #35 merged. For example, the integration tests in the full build of #36 (run 41881062372) ran
test_cloud.pyand passed all 14 tests. The publish, which installs the packages it has just built, failed them. Why the pull request builds did not see the new link is not yet established, so a pull request build cannot prove this change.The publish's Test stage does prove it, and its Package job runs only when every Test job passes, so nothing reaches PyPI unless these two tests pass.
What remains
rc.