This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Implement new factory - #106
Draft
Alan Lu (cag) wants to merge 31 commits into
Draft
Conversation
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
October 21, 2020 23:07
1f69dbf to
4246a9d
Compare
Merged
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
November 26, 2020 03:10
4246a9d to
d6d2fdd
Compare
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
December 23, 2020 03:12
ee0a328 to
c36effc
Compare
Alan Lu (cag)
changed the base branch from
development
to
handle-contract-versions
December 23, 2020 03:15
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
December 23, 2020 03:18
c36effc to
0bf6a84
Compare
Germán Martínez (germartinez)
force-pushed
the
handle-contract-versions
branch
from
December 24, 2020 14:59
0ffdb2d to
06a2562
Compare
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
December 28, 2020 22:14
a642d32 to
319acd4
Compare
Contributor
Author
|
Ugh, this is still not ready, and generalizing Okay, I'll resolve this by requiring the owner to either be the Note to self: rename from facade to adapter because that contract now has a more complicated interface and it's only used to ease working with the Safe relay. |
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
December 30, 2020 20:23
1ba2cad to
4368c56
Compare
Alan Lu (cag)
marked this pull request as ready for review
January 6, 2021 18:58
Alan Lu (cag)
force-pushed
the
new-factory
branch
from
January 6, 2021 19:09
0d086ef to
d92fc7f
Compare
Germán Martínez (germartinez)
marked this pull request as draft
September 3, 2021 16:42
Richard Meissner (rmeissner)
removed their request for review
July 8, 2025 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Just listing everything that this should handle)