Fix multi-host profiling and resolve profiler tracer collisions - #455
Open
richaguptaa17 wants to merge 1 commit into
Open
Fix multi-host profiling and resolve profiler tracer collisions#455richaguptaa17 wants to merge 1 commit into
richaguptaa17 wants to merge 1 commit into
Conversation
richaguptaa17
commented
Jul 31, 2026
richaguptaa17
commented
- Enable ML Diagnostics profiler on secondary TPU worker processes by removing the jax.process_index() == 0 lock from _ml_diagnostics_profiler_enabled().
- Refactor Profiler class in max_utils.py with active state tracking (_active). When both enable_ml_diagnostics and enable_profiler are True, prioritize ML Diagnostics and skip the standalone JAX profiler with a log warning to avoid RuntimeError tracer collisions.
- Enable ML Diagnostics profiler on secondary TPU worker processes by removing the jax.process_index() == 0 lock from _ml_diagnostics_profiler_enabled(). - Refactor Profiler class in max_utils.py with active state tracking (_active). When both enable_ml_diagnostics and enable_profiler are True, prioritize ML Diagnostics and skip the standalone JAX profiler with a log warning to avoid RuntimeError tracer collisions.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mbohlool
approved these changes
Aug 5, 2026
entrpn
approved these changes
Aug 6, 2026
| trace_dir = self.config.tensorboard_dir | ||
| if trace_dir.startswith("gs://"): | ||
| local_dir = os.path.join("/tmp/profiler_traces", self.config.run_name) | ||
| if os.path.exists(local_dir): |
There was a problem hiding this comment.
In a multi-host setup, won't non-master hosts upload their trace files to the same GCS prefix and overwrite each other?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.