Skip to content

develop the acro_summarise() function - #65

Open
mahaalbashir wants to merge 6 commits into
mainfrom
64-developing-the-acro_summarise-function
Open

develop the acro_summarise() function#65
mahaalbashir wants to merge 6 commits into
mainfrom
64-developing-the-acro_summarise-function

Conversation

@mahaalbashir

Copy link
Copy Markdown
Collaborator
  1. The acro_summarise() function uses the acro pivot_table function to create the output and do the risk assessments.
  2. It works with piping.

@mahaalbashir mahaalbashir linked an issue Jul 27, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f942c8d) to head (3940674).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          198       270   +72     
=========================================
+ Hits           198       270   +72     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahaalbashir
mahaalbashir requested a review from jim-smith July 27, 2026 21:33
Comment thread tests/testthat/test-acro_summarise.R Outdated
mahaalbashir and others added 2 commits July 28, 2026 11:04
Co-authored-by: Jim-smith <jim-smith@users.noreply.github.com>
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
@mahaalbashir
mahaalbashir requested a review from jim-smith July 28, 2026 10:50

@jim-smith jim-smith Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests that she acro_summarise behave exactly like R summarise are great.
Is there a way of checking the risk assessments produced and fed back to the researcher?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jim-smith I added three tests:

  1. Check the summary when the status is Pass
  2. Check the summary when the status is Fail
  3. Check the summary when suppression is enabled (status review)

Do you think of any other test cases that we can add?

@jim-smith

Copy link
Copy Markdown
Collaborator

@mahaalbashir
just thinking about how we let people know about these - and make the help etc available when researchers are (virtually) in TREs without internet access.

  1. Do we need manually provide the vignette's or are these automatically created from the docstrings?
  2. Should there be more updates/documents/example notebooks showing or discussing how to use acro from within the tidy verse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developing the acro_summarise() function

2 participants