develop the acro_summarise() function - #65
Open
mahaalbashir wants to merge 6 commits into
Open
Conversation
mahaalbashir
commented
Jul 27, 2026
Collaborator
- The acro_summarise() function uses the acro pivot_table function to create the output and do the risk assessments.
- It works with piping.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 198 270 +72
=========================================
+ Hits 198 270 +72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jim-smith
reviewed
Jul 28, 2026
Co-authored-by: Jim-smith <jim-smith@users.noreply.github.com> Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
jim-smith
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
All the tests that she acro_summarise behave exactly like R summarise are great.
Is there a way of checking the risk assessments produced and fed back to the researcher?
Collaborator
Author
There was a problem hiding this comment.
@jim-smith I added three tests:
- Check the summary when the status is Pass
- Check the summary when the status is Fail
- Check the summary when suppression is enabled (status review)
Do you think of any other test cases that we can add?
Collaborator
|
@mahaalbashir
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.