fix: Novice badge icon theme token + readable badge hover in all themes (#500) - #537
Open
RounakKumarAgarwal wants to merge 1 commit into
Open
RounakKumarAgarwal wants to merge 1 commit into
RounakKumarAgarwal wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #500
1. Novice badge icon color (the reported issue)
The Novice badge icon was hardcoded to
text-blue-500, so it stayed blue in every theme instead of adapting. Changed to thetext-primarytheme token (matching the fallback icon, which already usestext-primary). Applied in bothProfile.tsxandBadgeUnlocked.tsx.2. Badge hover contrast (found while verifying)
While testing, I noticed the badge box used
hover:bg-accent, which in the High Contrast theme turns the box background pure yellow — making the badge label and icon unreadable on hover. Replaced it withhover:border-primary hover:shadow-md, which highlights the badge on hover without a background swap, so the label and each badge's distinct icon color stay readable in all themes.Changes
Profile.tsx: Novice icon →text-primary; badge box hover →hover:border-primary hover:shadow-md.BadgeUnlocked.tsx: Novice icon →text-primary.Testing
npm run build— no new errors.Screendrecordings/ScreenShots
-Before Screenshots

-After
BadgeAfter.mp4