Fix test shader vulkan_tensor_postprocessing.spv - #26
Open
perim wants to merge 1 commit into
Open
Conversation
Coded by Qwen using pi.dev
roman-berger-arm
left a comment
roman-berger-arm
left a comment
Collaborator
There was a problem hiding this comment.
This is an input issue, the behaviour of this is valid otherwise as gsls defines the result of clamp with min > max as UB or poison. Therefore, these changes should not be merged
Collaborator
There was a problem hiding this comment.
The glsl spec says that the result of such a clamp is undefined before std450 and poison after. So in my eyes the current behaviour is valid for all versions before std450. We can return something nonsensical to represent the poison nature of the result, but otherwise I'm not sure if this should be worked around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coded by Qwen using pi.dev