Fix ocio.bat: create build/install directories if missing - #2346
Open
hikmetba-bit wants to merge 1 commit into
Open
hikmetba-bit wants to merge 1 commit into
hikmetba-bit wants to merge 1 commit into
Conversation
Without --configure, cmake -B never runs, so BUILD_PATH and INSTALL_PATH are never created. The subsequent cmake --build, cmake --install, and ctest steps then fail with errors like "C:/TEMP/OCIO/build/Release is not a directory". Explicitly create both directories after they are resolved, regardless of whether --configure was passed. Fixes AcademySoftwareFoundation#2031 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2031.
Without
--configure,cmake -Bnever runs, soBUILD_PATHandINSTALL_PATHare never created on disk. The subsequentcmake --build,cmake --install, andcteststeps then fail with an error likeC:/TEMP/OCIO/build/Release is not a directory, as reported in the issue.Fix
Explicitly create both directories with
mkdirright after they are resolved, regardless of whether--configurewas passed on that run.Test plan
ocio.bat --helpbefore and after the change to confirm the script still parses correctly.cmd /c "if NOT EXIST ... mkdir ...") that the two added lines create nested build/install directories that don't yet exist, and are a no-op when they already exist.🤖 Generated with Claude Code