fix: SG-44988: Fix annotations drawn on empty canvas with new annotation package - #1422
Open
eloisebrosseau wants to merge 1 commit into
Open
eloisebrosseau wants to merge 1 commit into
eloisebrosseau wants to merge 1 commit into
Conversation
Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
eloisebrosseau
requested review from
bernie-laberge and
cedrik-fuoco-adsk
as code owners
September 21, 2026 21:22
cedrik-fuoco-adsk
approved these changes
Sep 22, 2026
| self._current_source_name = name | ||
| paint_node, frame = self._find_paint_node() | ||
| if paint_node is None: | ||
| return |
Contributor
There was a problem hiding this comment.
Should we event.reject() here like on line 886 or not ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SG-44988: Fix annotations drawn on empty canvas with new annotation package
Summarize your change.
The Mu annotation package uses a tag so that
imagesAtPixelonly returns RVPaint nodes associated with the active view instead of any image rendered at that pixel. This is useful to properly detect the source we are currently on when there a multiple images (e.g. stack or layout view), and also contributes to correctly detecting an empty canvas. This behaviour was missing from the new annotation package._find_paint_node()was also mistakenly returning the first paint node from the list of RVPaint nodes if none were found from the view node info. It should have simply returned None instead of an arbitrary paint node. This caused strokes to be registered when clicking on empty Sequence view canvas because the Default Layout node was the first in that list.Note that a typo in the bindings for committing text was also fixed from
before-graph-view-changedtobefore-graph-view-change.Describe the reason for the change.
With the new annotation package, strokes were registered on empty canvas or on the wrong node.
Describe what you have tested and on which operating system.
Drawing was tested on macOS for the following: