Make the Windows debug postfix optional - #2040
Open
darbyjohnston wants to merge 1 commit into
Open
darbyjohnston wants to merge 1 commit into
darbyjohnston wants to merge 1 commit into
Conversation
The "_d" postfix on Windows debug builds is what a debug Python
interpreter looks for, but a debug build of OTIO is also loaded by a
release interpreter: pybind11 undefines _DEBUG around Python.h unless
Py_DEBUG is defined, so the modules are compiled against the release
ABI. That interpreter looks only for the name without the postfix, and
cannot import them:
ModuleNotFoundError: No module named 'opentimelineio._opentime'
The postfix was set with a plain set(), which nothing on the command
line can override. As a cache variable it keeps "_d" by default, so a
debug interpreter works as before, and can be set empty with
-DOTIO_DEBUG_POSTFIX= for a release one.
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
==========================================
+ Coverage 83.25% 83.47% +0.21%
==========================================
Files 180 182 +2
Lines 13479 13517 +38
Branches 1253 1254 +1
==========================================
+ Hits 11222 11283 +61
+ Misses 2085 2061 -24
- Partials 172 173 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the Windows debug postfix an option, so either debug or release libraries can be used.
Assisted-by: Claude:claude-opus-5 [implementation, testing]